From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: Simon Tournier <zimon.toutoune@gmail.com>,
guix-devel@gnu.org, 65866@debbugs.gnu.org
Subject: Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts)
Date: Thu, 14 Sep 2023 18:51:42 +0200 [thread overview]
Message-ID: <878r987l5t.fsf@gnu.org> (raw)
In-Reply-To: <87r0n4wp0d.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 11 Sep 2023 14:20:18 -0400")
Hi!
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> So given there's no technical reasons not to use libgit2, I'd use that
> and keep the closure size down.
For the record, that’s a 6% increase:
--8<---------------cut here---------------start------------->8---
$ guix size guix | tail -1
total: 633.0 MiB
$ guix size guix git-minimal | tail -1
total: 675.7 MiB
--8<---------------cut here---------------end--------------->8---
(Of course it all adds up; I’m not saying we can dismiss it.)
In the context of <https://issues.guix.gnu.org/65866> plus the lack of
GC in libgit2 discussed in <https://issues.guix.gnu.org/65720>, my
inclination is to include that hard dependency on Git.
That’s not a happy choice for me, but it has the advantage of solving
two immediate problems.
I would revisit it as soon as libgit2 supports shallow clones (which is
coming, as you write) and GC (or a workaround to that effect). SHA256
may also soon be a requirement: we’ll need to be able to clone repos
that use it.
How does that sound?
Ludo’.
next prev parent reply other threads:[~2023-09-14 16:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 15:17 hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts) Simon Tournier
2023-09-11 17:51 ` wolf
2023-09-11 18:26 ` Maxim Cournoyer
2023-09-11 22:48 ` comparing commit-relation using Scheme+libgit2 vs shellout plumbing Git Simon Tournier
2023-09-12 11:07 ` Attila Lendvai
2023-09-14 10:30 ` Ludovic Courtès
2023-09-14 11:56 ` Simon Tournier
2023-09-11 17:52 ` hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts) Simon Tournier
2023-09-11 18:20 ` Maxim Cournoyer
2023-09-12 9:06 ` Josselin Poiret
2023-09-12 12:56 ` Maxim Cournoyer
2023-09-12 14:08 ` wolf
2023-09-14 10:22 ` Ludovic Courtès
2023-09-14 16:51 ` Ludovic Courtès [this message]
2023-09-14 17:28 ` Simon Tournier
2023-09-17 2:16 ` Maxim Cournoyer
2023-09-18 13:56 ` [bug#65866] " Ludovic Courtès
2023-09-18 14:45 ` Simon Tournier
2023-09-19 14:43 ` bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts Ludovic Courtès
2023-09-19 17:09 ` Simon Tournier
2023-09-11 19:35 ` hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts) Vagrant Cascadian
2023-09-11 21:23 ` Csepp
2023-09-12 7:44 ` Simon Tournier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r987l5t.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=65866@debbugs.gnu.org \
--cc=guix-devel@gnu.org \
--cc=maxim.cournoyer@gmail.com \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).