From: Vagrant Cascadian <vagrant@debian.org>
To: "Simon Tournier" <zimon.toutoune@gmail.com>,
guix-devel@gnu.org, "Ludovic Courtès" <ludo@gnu.org>
Subject: Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts)
Date: Mon, 11 Sep 2023 12:35:29 -0700 [thread overview]
Message-ID: <874jk0jyf2.fsf@wireframe> (raw)
In-Reply-To: <871qf4ivsr.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]
On 2023-09-11, Simon Tournier wrote:
> On Mon, 11 Sep 2023 at 16:23, Ludovic Courtès <ludo@gnu.org> wrote:
>> Note that the patch series adds a hard dependency on Git.
>> This is because the existing ‘git-fetch’ code depends on Git,
>> which is itself motivated by the fact that Git supports
>> shallow clones and libgit2/Guile-Git doesn’t.
...
> Personally, I do not have a strong opinion about the Big Plan™. I note
> that the introduction of Git as a hard dependency is a slippery slope
> considering the current state of libgit2. Here, it starts with “git
> clone”, then “git gc” (unsupported by libgit2) is also in the pipes
> (#65720 [1]).
What about making git an optional dependency, and only calling out to
"git gc" if git is available in PATH? Maybe possible also with shallow
clones?
Then you have the best/worst of both worlds! Speaking to the worst, you
have at least two disparate codepaths for a seemingly similar operation,
and that might be annoying...
live well,
vagrant
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2023-09-11 19:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 15:17 hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts) Simon Tournier
2023-09-11 17:51 ` wolf
2023-09-11 18:26 ` Maxim Cournoyer
2023-09-11 22:48 ` comparing commit-relation using Scheme+libgit2 vs shellout plumbing Git Simon Tournier
2023-09-12 11:07 ` Attila Lendvai
2023-09-14 10:30 ` Ludovic Courtès
2023-09-14 11:56 ` Simon Tournier
2023-09-11 17:52 ` hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts) Simon Tournier
2023-09-11 18:20 ` Maxim Cournoyer
2023-09-12 9:06 ` Josselin Poiret
2023-09-12 12:56 ` Maxim Cournoyer
2023-09-12 14:08 ` wolf
2023-09-14 10:22 ` Ludovic Courtès
2023-09-14 16:51 ` Ludovic Courtès
2023-09-14 17:28 ` Simon Tournier
2023-09-17 2:16 ` Maxim Cournoyer
2023-09-18 13:56 ` [bug#65866] " Ludovic Courtès
2023-09-18 14:45 ` Simon Tournier
2023-09-19 14:43 ` bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts Ludovic Courtès
2023-09-19 17:09 ` Simon Tournier
2023-09-11 19:35 ` Vagrant Cascadian [this message]
2023-09-11 21:23 ` hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts) Csepp
2023-09-12 7:44 ` Simon Tournier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jk0jyf2.fsf@wireframe \
--to=vagrant@debian.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).