From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 2OosBj86A2Wm8QAA9RJhRA:P1 (envelope-from ) for ; Thu, 14 Sep 2023 18:52:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 2OosBj86A2Wm8QAA9RJhRA (envelope-from ) for ; Thu, 14 Sep 2023 18:52:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C8F493CE8B for ; Thu, 14 Sep 2023 18:52:14 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=X+aX+WPz; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694710334; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=ej+RWM1R2CZTHsJg6J/jBSDXePUVe/ByfcQ+ZmWrtcs=; b=jxjIjxYckUxoJKX0YbUeYcZhMuOVOGAQvXFnSaqFaybpDJbciTPIQm9t1m4iGsDNQWWS7X mzCtmol2CfGDgMTTeDsvfhb2XtXmhgQEVkPewPspQYtNsTPhRnpznyPAHq8C4sxyLfWCb3 ehvtrOUzAE9WytfA3nu9sxA+cDj6bzSqRp4sV4rKp8GybFqOCRXmR3BFqvfmlI+NoneJam vp86VCP62RM8KYuq/YSddFPXsd9z74OnmQNDld7X8Rm1pIHLzYPv/AJyJIXEZhzVZQ4ZMl nAc/8SisK43XTH2ZbRpFAZe+cSy7PgILZcVi0nbQSWBk9PYNlaS7b7/wb2uHbw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=X+aX+WPz; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694710334; a=rsa-sha256; cv=none; b=GodwToowyj6LhngeMGgu/DGOtx7EjN1wILs3HYCeh8K/n0h98E3gc7vbVr3LZO6AD3zX5i 1JeG0bBezxHvzpddMX9ND5f8mS8uqZyMEJT3ABiAzyn6BLOWqMUDap1dN00co5FEF/bWvg fq73DA6vjsI2Al/kqZ2QktrJoDrRaawKXv4okLttz/GXv7Xm7mowSvDoPwwXNx0j/DHRnu 4EgWfD/GybBJz84SdcPGUYlPX1NkhwxOz/ucx1iGHW7scoBWJGgbxK/vkk/YstN83+Godr RrwQFHws349WMz3G/Q9RWcc2mvlYQsw37/f7hrdzGSpNuHwkjfZDXCbiaRGrWg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgpZD-0005CI-8D; Thu, 14 Sep 2023 12:51:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgpZC-0005C0-CM for guix-devel@gnu.org; Thu, 14 Sep 2023 12:51:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgpZC-00046k-1A; Thu, 14 Sep 2023 12:51:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=ej+RWM1R2CZTHsJg6J/jBSDXePUVe/ByfcQ+ZmWrtcs=; b=X+aX+WPzrldd4AtJ7Y8y ioTBv9KAQLPLMpttUi2s4c9RtpkWjWnZKKgTqhHldXNq72+tDa1XJHIm/wat52+im6C05cQtGtP4D 4Ne5vcNrHzWF1ZhyiUbpPlM4KzpvsLWHQVP69zWLcHTIZLiLn/K7h0xZ2AWKrJRgoOVK6WXoI+1eA iBWJpMJNqeJHvAE4q9sH+6+gBOrwd+o6Y7eYFwLdG/AbAV55roDecbj52jCSPwTbQKterJusfUxpK mfFB8okfQj7p3pDRn/yeYWPtMjyfHFjt9Q5NDJMzI3f3uwZ06TfNKAOYkVN6FsPG1CxhJxDDfR71R nRPjqgRBhqhE1g==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Cc: Simon Tournier , guix-devel@gnu.org, 65866@debbugs.gnu.org Subject: Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts) References: <871qf4ivsr.fsf@gmail.com> <87r0n4wp0d.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Octidi 28 Fructidor an 231 de la =?utf-8?Q?R=C3=A9vo?= =?utf-8?Q?lution=2C?= jour du =?utf-8?Q?Ma=C3=AFs?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 14 Sep 2023 18:51:42 +0200 In-Reply-To: <87r0n4wp0d.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 11 Sep 2023 14:20:18 -0400") Message-ID: <878r987l5t.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -2.31 X-Spam-Score: -2.31 X-Migadu-Queue-Id: C8F493CE8B X-TUID: ZIj393l61ZKy Hi! Maxim Cournoyer skribis: > So given there's no technical reasons not to use libgit2, I'd use that > and keep the closure size down. For the record, that=E2=80=99s a 6% increase: --8<---------------cut here---------------start------------->8--- $ guix size guix | tail -1 total: 633.0 MiB $ guix size guix git-minimal | tail -1 total: 675.7 MiB --8<---------------cut here---------------end--------------->8--- (Of course it all adds up; I=E2=80=99m not saying we can dismiss it.) In the context of plus the lack of GC in libgit2 discussed in , my inclination is to include that hard dependency on Git. That=E2=80=99s not a happy choice for me, but it has the advantage of solvi= ng two immediate problems. I would revisit it as soon as libgit2 supports shallow clones (which is coming, as you write) and GC (or a workaround to that effect). SHA256 may also soon be a requirement: we=E2=80=99ll need to be able to clone repos that use it. How does that sound? Ludo=E2=80=99.