From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: Add xulrunner and conkeror. Date: Sun, 06 Jul 2014 12:16:45 +0200 Message-ID: <877g3qokqa.fsf@gnu.org> References: <87bnt2hnmp.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3jV6-00014A-Ql for guix-devel@gnu.org; Sun, 06 Jul 2014 06:16:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X3jV2-0005Ql-8w for guix-devel@gnu.org; Sun, 06 Jul 2014 06:16:52 -0400 Received: from hera.aquilenet.fr ([2a01:474::1]:33128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3jV1-0005Qd-V8 for guix-devel@gnu.org; Sun, 06 Jul 2014 06:16:48 -0400 In-Reply-To: <87bnt2hnmp.fsf@gmail.com> (Cyrill Schenkel's message of "Sun, 06 Jul 2014 10:55:58 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Cyrill Schenkel Cc: Guix-devel Cyrill Schenkel skribis: > From 45e7d3afb7247c3fc82fb9d1b275254bde054911 Mon Sep 17 00:00:00 2001 > From: Cyrill Schenkel > Date: Sun, 6 Jul 2014 10:40:05 +0200 > Subject: [PATCH] gnu: Add xulrunner and conkeror. > > * gnu-system.am (GNU_SYSTEM_MODULES, dist_patch_DATA): Add new package an= d patch. > * gnu/packages/conkeror.scm: New file. > * gnu/packages/patches/xulrunner-install.patch: New file. > * gnu/packages/xulrunner.scm: New file. Wow, great! This is among the last packages I regularly use that I missed. [...] > + (package > + (name "conkeror") > + (version "1.0pre1") > + (source (origin > + (method url-fetch) > + (uri > + (string-append "http://repo.or.cz/w/conkeror.git/snapshot= /" > + "8a26fff5896a3360549e2adfbf06b1d57e909266" > + ".tar.gz")) Normally we provide only released versions. If the last official release is too old or broken, could you add a comment stating why we take this one? > + (native-inputs `(("tar" ,tar) > + ("gzip" ,gzip))) This should not be needed because these are implicit inputs. > + (description " Conkeror is a highly-programmable web browser based on ^ Extra space. > +Mozilla XULRunner which is the base of all Mozilla products including > +Firefox. Conkeror has a sophisticated keyboard system for running comman= ds and > +interacting with web page content, modelled after Emacs and Lynx. It is > +self-documenting and extensible with JavaScript. > + > +It comes with builtin support for several Web 2.0 sites like several Goo= gle > +services (Search, Gmail, Maps, Reader, etc.), Del.icio.us, Reddit, Last.= fm and > +YouTube. For easier editing of form fields, it can spawn external editor= s. For > +this feature the recommended conkeror-spawn-process-helper package needs= to be > +installed. > + > +Despite its very similar sounding name, Conkeror is not related to the K= DE web > +browser and file manager Konqueror in any way. ") If you could make it one paragraph shorter, that=E2=80=99d be great. > + (license (list license:gpl2 > + license:lgpl2.1)))) Could you add a comment saying if this is dual-licensing, or something else? Also, did you mean =E2=80=98gpl2+=E2=80=99 and =E2=80=98lgpl2.1+=E2= =80=99? If the result is a combination of GPLv2 and LGPLv2.1 files, then it should be simply license:gpl2(+). > --- /dev/null > +++ b/gnu/packages/patches/xulrunner-install.patch Please add a couple of lines saying what it does, and what the upstream status is. > +(define-module (gnu packages xulrunner) This one looks good. I=E2=80=99m wondering if it would make sense to take xulrunner from the IceCat sources, but I=E2=80=99m not sure IceCat modifies xulrunner itself. Ideas? Thank you! Ludo=E2=80=99.