From: Ricardo Wurmus <rekado@elephly.net>
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel@gnu.org, guix-commits@gnu.org
Subject: Re: branch master updated: gnu: Add r-loomr.
Date: Wed, 09 Sep 2020 18:02:30 +0200 [thread overview]
Message-ID: <877dt36iqx.fsf@elephly.net> (raw)
In-Reply-To: <20200909145626.7782.91114@vcs0.savannah.gnu.org>
Hi Roel,
> This is an automated email from the git hooks/post-receive script.
>
> roelj pushed a commit to branch master
> in repository guix.
>
> The following commit(s) were added to refs/heads/master by this push:
> new 1f56ec0 gnu: Add r-loomr.
> 1f56ec0 is described below
>
> commit 1f56ec08af704bdc7aa3e143bf5ce351c5306dea
> Author: Roel Janssen <roel@gnu.org>
> AuthorDate: Wed Sep 9 16:56:02 2020 +0200
>
> gnu: Add r-loomr.
>
> * gnu/packages/bioinformatics.scm (r-loomr): New variable.
This is not free software. See
https://github.com/mojaveazure/loomR/pull/24
Aside from this, I would like to say two things:
> gnu/packages/bioinformatics.scm | 26 ++++++++++++++++++++++++++
Let’s please not add R packages to (gnu packages bioinformatics) when it
can be avoided. (In this case there’s no CRAN package, so it’s fine.)
> +(define-public r-loomr
> + (package
> + (name "r-loomr")
> + (version "0.2.0-beta")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/mojaveazure/loomR/archive/"
> + version ".tar.gz"))
This is not okay as these generated tarballs are not stable. I haven’t
seen these patches on guix-patches before — maybe I missed them. But we
have been avoiding these kind of URLs since a long time and had I seen
the patches on guix-patches I and other would probably have pointed this
out.
Can you please revert this ASAP?
--
Ricardo
next parent reply other threads:[~2020-09-09 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200909145626.7782.91114@vcs0.savannah.gnu.org>
2020-09-09 16:02 ` Ricardo Wurmus [this message]
2020-09-10 9:13 ` branch master updated: gnu: Add r-loomr Roel Janssen
2020-09-10 10:38 ` Ricardo Wurmus
2020-09-10 12:01 ` zimoun
2020-09-10 12:23 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dt36iqx.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=guix-commits@gnu.org \
--cc=guix-devel@gnu.org \
--cc=roel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).