From: Ricardo Wurmus <rekado@elephly.net>
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel@gnu.org, guix-commits@gnu.org
Subject: Re: branch master updated: gnu: Add r-loomr.
Date: Thu, 10 Sep 2020 12:38:41 +0200 [thread overview]
Message-ID: <87k0x16hn2.fsf@elephly.net> (raw)
In-Reply-To: <436d649127861cd5e0f642551ece6729ed7500cb.camel@gnu.org>
Roel Janssen <roel@gnu.org> writes:
>> > commit 1f56ec08af704bdc7aa3e143bf5ce351c5306dea
>> > Author: Roel Janssen <roel@gnu.org>
>> > AuthorDate: Wed Sep 9 16:56:02 2020 +0200
>> >
>> > gnu: Add r-loomr.
>> >
>> > * gnu/packages/bioinformatics.scm (r-loomr): New variable.
>>
>> This is not free software. See
>>
>> https://github.com/mojaveazure/loomR/pull/24
>
>
> Oh shoot. I'm sorry I didn't see this discussion!
It’s really not obvious. I know because it happened to me too. In 2018
I added r-loomr with commit fab43c6b84635200070c708d4220132be18dd239.
Then in 2019 I removed it with commit
bc70516bbae8a6388f3ed19008d3e10efd1577a7 after noticing that the author
only used GPL in the DESCRIPTION file to stop the CRAN tools from
complaining.
It’s definitely unusual and very easy to miss.
>> Aside from this, I would like to say two things:
>>
>> > gnu/packages/bioinformatics.scm | 26 ++++++++++++++++++++++++++
>>
>> Let’s please not add R packages to (gnu packages bioinformatics) when
>> it
>> can be avoided. (In this case there’s no CRAN package, so it’s
>> fine.)
>
> Where would I add a non-CRAN and non-Bioconductor package to? Perhaps
> this situation won't occur again, and should raise a flag, because I
> think I've never had this case before.
We don’t have any good place for those packages. It would be good to
have a dumping ground for packages like that, and for those that are on
CRAN but unusually depend on Bioconductor packages.
> I will default to submitting patches to guix-patches again. I thought
> it was trivial enough to just push. My mistake.
I’d say if it’s on CRAN you can go ahead and push directly (after
running “guix lint” to catch some obvious mistakes). Bioconductor
packages need a little extra care because they are sometimes playing
loose with licenses and included third-party code; but if you feel
you’ve checked things carefully then you can also push those directly.
For third-party R packages we don’t benefit from even the little bit of
quality control that CRAN and Bioconductor impose, so we need to be
extra careful. There it helps to send patches to guix-patches and push
them after some time.
--
Ricardo
next prev parent reply other threads:[~2020-09-10 10:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200909145626.7782.91114@vcs0.savannah.gnu.org>
2020-09-09 16:02 ` branch master updated: gnu: Add r-loomr Ricardo Wurmus
2020-09-10 9:13 ` Roel Janssen
2020-09-10 10:38 ` Ricardo Wurmus [this message]
2020-09-10 12:01 ` zimoun
2020-09-10 12:23 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0x16hn2.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=guix-commits@gnu.org \
--cc=guix-devel@gnu.org \
--cc=roel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).