From: ludo@gnu.org (Ludovic Courtès)
To: "Tomáš Čech" <sleep_walker@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: sdcv: Add new variable.
Date: Wed, 18 Mar 2015 09:39:49 +0100 [thread overview]
Message-ID: <874mpilmwa.fsf@gnu.org> (raw)
In-Reply-To: <1426497533-7895-1-git-send-email-sleep_walker@gnu.org> ("Tomáš Čech"'s message of "Mon, 16 Mar 2015 10:18:53 +0100")
Tomáš Čech <sleep_walker@gnu.org> skribis:
> * gnu/packages/dictionaries.scm (sdcv): New variable.
You pushed it already but I have some comments anyway:
> +(define-public sdcv
> + (package
> + (name "sdcv")
> + (version "0.5.0-beta4")
The policy is to provide only stable versions, unless there’s a very
good reason to do otherwise. Could we use the previous version until
0.5.0 is out?
> + (synopsis "Command line variant of StarDict")
Could you change it to be self-contained–i.e., without referring to
StarDict (which I don’t know, and perhaps is not very well known.)
> + (description
> + "Sdcv is command line dictionary utility, which supports StarDict dictinary
> +format.")
Typo: “dictionary”.
Please expound, explaining what it does concretely. Perhaps get
inspiration from the README or web page.
TIA,
Ludo’.
next prev parent reply other threads:[~2015-03-18 8:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 9:18 [PATCH] gnu: sdcv: Add new variable Tomáš Čech
2015-03-16 9:54 ` Andreas Enge
2015-03-16 10:23 ` Tomáš Čech
2015-03-18 8:39 ` Ludovic Courtès [this message]
2015-03-18 12:25 ` Tomáš Čech
2015-03-18 13:28 ` Ludovic Courtès
2015-03-18 14:56 ` Tomáš Čech
2015-03-18 15:30 ` [PATCH] Revert "gnu: Add sdcv." Tomáš Čech
2015-03-19 16:02 ` [PATCH] gnu: sdcv: Add new variable Ludovic Courtès
2015-03-22 21:40 ` Tomáš Čech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mpilmwa.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=sleep_walker@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).