From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: sdcv: Add new variable. Date: Wed, 18 Mar 2015 09:39:49 +0100 Message-ID: <874mpilmwa.fsf@gnu.org> References: <1426497533-7895-1-git-send-email-sleep_walker@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YY9W8-000322-9L for guix-devel@gnu.org; Wed, 18 Mar 2015 04:39:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YY9W5-00081J-3g for guix-devel@gnu.org; Wed, 18 Mar 2015 04:39:56 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YY9W5-00080q-0o for guix-devel@gnu.org; Wed, 18 Mar 2015 04:39:53 -0400 In-Reply-To: <1426497533-7895-1-git-send-email-sleep_walker@gnu.org> (=?utf-8?B?IlRvbcOhxaEJxIxlY2giJ3M=?= message of "Mon, 16 Mar 2015 10:18:53 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= Cc: guix-devel@gnu.org Tom=C3=A1=C5=A1 =C4=8Cech skribis: > * gnu/packages/dictionaries.scm (sdcv): New variable. You pushed it already but I have some comments anyway: > +(define-public sdcv > + (package > + (name "sdcv") > + (version "0.5.0-beta4") The policy is to provide only stable versions, unless there=E2=80=99s a very good reason to do otherwise. Could we use the previous version until 0.5.0 is out? > + (synopsis "Command line variant of StarDict") Could you change it to be self-contained=E2=80=93i.e., without referring to StarDict (which I don=E2=80=99t know, and perhaps is not very well known.) > + (description > + "Sdcv is command line dictionary utility, which supports StarDict d= ictinary > +format.") Typo: =E2=80=9Cdictionary=E2=80=9D. Please expound, explaining what it does concretely. Perhaps get inspiration from the README or web page. TIA, Ludo=E2=80=99.