Re: [PATCH] gnu: sdcv: Add new variable.

["Tomáš Čech" <sleep_walker@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 2124 bytes --]

On Wed, Mar 18, 2015 at 09:39:49AM +0100, Ludovic Courtès wrote:
>Tomáš Čech <sleep_walker@gnu.org> skribis:
>
>> * gnu/packages/dictionaries.scm (sdcv): New variable.
>
>You pushed it already but I have some comments anyway:

Oh, I took that there are no objections already. Sorry about that.
>
>> +(define-public sdcv
>> +  (package
>> +    (name "sdcv")
>> +    (version "0.5.0-beta4")
>
>The policy is to provide only stable versions, unless there’s a very
>good reason to do otherwise.  Could we use the previous version until
>0.5.0 is out?

Previous version of this tool is 0.4.2, which is 8 years old, it won't work with recent compilers (it's their statement, not my experiment though), could suffer with allignment issues on more exotic architectures (ARM among them).

I can add comment with the reasoning.

>> +    (synopsis "Command line variant of StarDict")
>
>Could you change it to be self-contained–i.e., without referring to
>StarDict (which I don’t know, and perhaps is not very well known.)

sdcv stands for - StarDict Command line Variant
This is where I took the synopsis from.

It's hard to believe that you have never heard of StarDict. I'm not
aware of any offline sotfware dictionary software which does not
support StarDict dictionary format and doesn't state it's relation to
stardict - be it GoldenDict, QStardict or this sdcv.

Is "Command line offline dictionary" satisfactory?
>> +    (description
>> +     "Sdcv is command line dictionary utility, which supports StarDict dictinary
>> +format.")
>
>Typo: “dictionary”.

Thanks.

>
>Please expound, explaining what it does concretely.  Perhaps get
>inspiration from the README or web page.

I'm afraid that their web or README is useless for this case.

Is this satisfactory?:
"Sdcv is command line dictionary utility with support of StarDict
dictionary format.  For word in one language it can find translation
in all installed dictionaries at the same time and without specifying
original language.  With proper dictionary it can also work as
encyclopedic dictionary."

[-- Attachment #2: Type: application/pgp-signature, Size: 181 bytes --]