From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id GFUuI0Vs/2TY8AAA9RJhRA:P1 (envelope-from ) for ; Mon, 11 Sep 2023 21:36:37 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id GFUuI0Vs/2TY8AAA9RJhRA (envelope-from ) for ; Mon, 11 Sep 2023 21:36:37 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6EC3644540 for ; Mon, 11 Sep 2023 21:36:37 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debian.org header.s=1.vagrant.user header.b=NycuPti3; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694460997; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=jtMK88H/VIuqdIu+KWHQnJTrWKk2GI95ik8kS8HPb1Y=; b=lDLkd3RXAGkj7r1l63r1c9HH24QF6nS4APVt2WRjTYH0SSVoFxlicWdnbtlls215dkmUEh wnbhMW/F4+Cr/DV2bIJjRgjHeXWJuBRdALsfHcf6ePUiG793GwxbdJaaZpG6j92i1rBhxZ kCOr8pTRr+19ns5a6mOAh29Y2qUR/mLefLYPsF15WnUEVZClP+MHcJq1Hx3ToW7myo5cXY FCwa96Eup/kkgi+QPeq4S4wN3RPlciwEyXB8ntOrB1omZkaimeBP8X1MC9hkuGVvIsIfH0 eVjqBsv6BI7OY3SnigsVAQUDE98WdJMCcPlg5p2PKFf3IdJEgt/Ps37yaBqUdQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694460997; a=rsa-sha256; cv=none; b=H4QkJwTMasUtOmhEragqzwkcCnycgqJPBktcei8rO8uXhJr4dYwqnQ/mKQk9HrwTQ95JMY gYVbcytZmoSYvmUwEVCJP4YoBkRVZ4gO2R0UjGcRDr+HLJg9mqr0Lz0zCdGKgw5PpGZDIF KVU5CIHcYaG5L62d69uMWvlS9R3+SGw7lgkvuNoEZuY6Q5swI+R6Axg8d1wk0mtOmn9fYL 1z2RSgBKcmCScpH4dkLmQ4QiZbg58ORYG6nytM9GnZFUlFlNglsEHA5UHNkGmnuuQbbs/I hwGluaFZyhCp5y7QdSWCBGiyzCV0urPUKsQI7ZVSZ3hGBbCbT7e2QMjx3MFLVg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debian.org header.s=1.vagrant.user header.b=NycuPti3; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfmhO-0002e7-8i; Mon, 11 Sep 2023 15:35:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfmhM-0002dd-05 for guix-devel@gnu.org; Mon, 11 Sep 2023 15:35:52 -0400 Received: from cascadia.aikidev.net ([2600:3c01:e000:267:0:a171:de7:c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfmhH-0003ij-2b; Mon, 11 Sep 2023 15:35:51 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 542331AD5D; Mon, 11 Sep 2023 12:35:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1694460936; bh=uKR9n+nmzqKggKidbij5WF14l39Yv1Z6zmOP+xvlZhA=; h=From:To:Subject:In-Reply-To:References:Date:From; b=NycuPti3jpxTXEIVN06XkStu5barWcWcwPGTwf0epNcbYxwDgLUcMTkjFV1gl1kQv nfat3ly3NAEaRy8lLz8GqRqnpdeFefsVH85hRer9kvGArikaCFE6oEprh1yqozwUMp pfYsIGlBbkO9FkXOMO1hqIFpCAQQBOixigzDGgY7JIhXViHY8ieA5WqRu9V0uoFfeM yG41kzbDGDU+ckbMt1NEet+MRuEjRj94tRt2hwGgzTB5tbr24YDlONNgakteigqvc9 GJE9TvMLah9bguEaYU4UtUAqo59iGbHPI/NSPAPCgte8gXES71RRc7zc9pcPqt6Mp7 58g54+FocIl/Q== From: Vagrant Cascadian To: Simon Tournier , guix-devel@gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts) In-Reply-To: <871qf4ivsr.fsf@gmail.com> References: <871qf4ivsr.fsf@gmail.com> Date: Mon, 11 Sep 2023 12:35:29 -0700 Message-ID: <874jk0jyf2.fsf@wireframe> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: none client-ip=2600:3c01:e000:267:0:a171:de7:c; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -12.97 X-Spam-Score: -12.97 X-Migadu-Queue-Id: 6EC3644540 X-Migadu-Scanner: mx0.migadu.com X-TUID: /d3BdJh1zbjg --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2023-09-11, Simon Tournier wrote: > On Mon, 11 Sep 2023 at 16:23, Ludovic Court=C3=A8s wrote: >> Note that the patch series adds a hard dependency on Git. >> This is because the existing =E2=80=98git-fetch=E2=80=99 code depends on= Git, >> which is itself motivated by the fact that Git supports >> shallow clones and libgit2/Guile-Git doesn=E2=80=99t. ... > Personally, I do not have a strong opinion about the Big Plan=E2=84=A2. = I note > that the introduction of Git as a hard dependency is a slippery slope > considering the current state of libgit2. Here, it starts with =E2=80=9C= git > clone=E2=80=9D, then =E2=80=9Cgit gc=E2=80=9D (unsupported by libgit2) is= also in the pipes > (#65720 [1]). What about making git an optional dependency, and only calling out to "git gc" if git is available in PATH? Maybe possible also with shallow clones? Then you have the best/worst of both worlds! Speaking to the worst, you have at least two disparate codepaths for a seemingly similar operation, and that might be annoying... live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZP9sAQAKCRDcUY/If5cW qprlAQDYZ/HllAWciMXq7ELO6jeFJC5AgJpZuCZJ/BHrU8ldWgEAtbIRCCT/FsoZ pW3MZ1TmtuoZzz69XybimioOAuULogg= =9+zW -----END PGP SIGNATURE----- --=-=-=--