From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add eXpress.
Date: Tue, 21 Apr 2015 17:40:44 +0200
Message-ID: <87383tij5v.fsf@gnu.org>
References: <idjbnioxlb6.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56505)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YkaI6-0006SN-D6
	for guix-devel@gnu.org; Tue, 21 Apr 2015 11:40:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YkaI2-0004ZU-JD
	for guix-devel@gnu.org; Tue, 21 Apr 2015 11:40:50 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36382)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YkaI2-0004ZQ-HQ
	for guix-devel@gnu.org; Tue, 21 Apr 2015 11:40:46 -0400
In-Reply-To: <idjbnioxlb6.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Thu, 16 Apr 2015 15:19:25 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: Guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> From 16e9535b2dad21cd585b6da94296f94164103de0 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 16 Apr 2015 15:16:57 +0200
> Subject: [PATCH 1/2] gnu: Add bamtools.
>
> * gnu/packages/bioinformatics.scm (bamtools): New variable.

OK.

> From c65294547718078189bc920be8e5b07d57470060 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 16 Apr 2015 15:18:10 +0200
> Subject: [PATCH 2/2] gnu: Add eXpress.
>
> * gnu/packages/bioinformatics.scm (express): New variable.

[...]

> +       (alist-cons-after
> +        'unpack 'use-shared-boost-libs-and-set-bamtools-paths
> +        (lambda* (#:key inputs #:allow-other-keys)
> +          (substitute* "CMakeLists.txt"
> +            (("set\\(Boost_USE_STATIC_LIBS ON\\)")
> +             "set(Boost_USE_STATIC_LIBS OFF)")

I think the same effect can be achieved by passing
-DBoost_USE_STATIC_LIBS=3DOFF to cmake (i.e., as #:configure-flags.)
It might be slightly more elegant, but no big deal.

OK!

Ludo=E2=80=99.