unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Pjotr Prins <pjotr.public12@thebird.nl>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] build: ruby: Add 'gem-flags' key to ruby build system
Date: Sat, 18 Jul 2015 17:20:28 +0200	[thread overview]
Message-ID: <87380lo5kz.fsf@gnu.org> (raw)
In-Reply-To: <20150713134451.GA29236@thebird.nl> (Pjotr Prins's message of "Mon, 13 Jul 2015 15:44:51 +0200")

Pjotr Prins <pjotr.public12@thebird.nl> skribis:

> From ce8cfeadc8a661ff0fe0b96dc241d0063ed49ba3 Mon Sep 17 00:00:00 2001
> From: pjotrp <pjotr.public01@thebird.nl>
> Date: Mon, 13 Jul 2015 15:32:36 +0200
> Subject: [PATCH] build: ruby: Add 'gem-flags' key to ruby build system
>
> * guix/build-system/ruby.scm (build): add 'gem-flags' key
> * guix/build/ruby-build-system.scm (build): use 'gem-flags' key

[...]

>      (zero? (system* "gem" "install" "--local"
> -                    "--bindir" (string-append out "/bin")))))
> +                    "--bindir" (string-append out "/bin") "--"
> +                    (string-join (cond (null? gem-flags)('())(gem-flags)))))))

The ‘cond’ form is syntactically invalid, and ‘gem-flags’ is not a
procedure so it cannot be called.  So I’ve changed that, also removing
the “--”.  Pushed as 6e9f291.

Thanks!

Ludo’.

  parent reply	other threads:[~2015-07-18 15:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13 13:44 [PATCH] build: ruby: Add 'gem-flags' key to ruby build system Pjotr Prins
2015-07-17 21:05 ` Pjotr Prins
2015-07-18 15:20 ` Ludovic Courtès [this message]
2015-07-19  9:29   ` Pjotr Prins
2015-07-19 20:44     ` Ludovic Courtès
2015-07-20  6:37       ` Pjotr Prins
2015-07-20 17:43       ` Thompson, David

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87380lo5kz.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=pjotr.public12@thebird.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).