From: "Thompson, David" <dthompson2@worcester.edu>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] build: ruby: Add 'gem-flags' key to ruby build system
Date: Mon, 20 Jul 2015 13:43:09 -0400 [thread overview]
Message-ID: <CAJ=RwfZrfdNDP+kFbn9xiDjQeMgyYCg_kZ35CfmcsmVti3J9mw@mail.gmail.com> (raw)
In-Reply-To: <877fpvnahp.fsf@gnu.org>
On Sun, Jul 19, 2015 at 4:44 PM, Ludovic Courtès <ludo@gnu.org> wrote:
> Pjotr Prins <pjotr.public12@thebird.nl> skribis:
>
>> On Sat, Jul 18, 2015 at 05:20:28PM +0200, Ludovic Courtès wrote:
>>> > (zero? (system* "gem" "install" "--local"
>>> > - "--bindir" (string-append out "/bin")))))
>>> > + "--bindir" (string-append out "/bin") "--"
>>> > + (string-join (cond (null? gem-flags)('())(gem-flags)))))))
>>>
>>> , and ‘gem-flags’ is not a procedure so it cannot be called. So
>>> I’ve changed that, also removing the “--”. Pushed as 6e9f291.
>>
>> The "--" is required when gem-flags is passed in. It is optional when
>> gem-flags is empty. Do you think gem authors should always prepend the
>> "--" in front of the other options? I would think it is a builder
>> thing if we can abstract it away. Right? If that is so, we can leave it
>> there since it is harmless if gem-flags is empty.
>
> My guess is that there are options like --bindir (maybe “--docdir”?) for
> which “--” does not need to be added, and others for which it is
> needed. That’s why I left it out (also: users can easily add “--” but
> cannot remove it if it’s hard-coded.)
>
> Now, Dave and you definitely know this better than me, so I’ll rely on
> your judgment. Thoughts?
I don't really use the 'gem' tool directly most of the time, but not
hardcoding '--' sounds reasonable based on your thoughts above.
- Dave
prev parent reply other threads:[~2015-07-20 17:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 13:44 [PATCH] build: ruby: Add 'gem-flags' key to ruby build system Pjotr Prins
2015-07-17 21:05 ` Pjotr Prins
2015-07-18 15:20 ` Ludovic Courtès
2015-07-19 9:29 ` Pjotr Prins
2015-07-19 20:44 ` Ludovic Courtès
2015-07-20 6:37 ` Pjotr Prins
2015-07-20 17:43 ` Thompson, David [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ=RwfZrfdNDP+kFbn9xiDjQeMgyYCg_kZ35CfmcsmVti3J9mw@mail.gmail.com' \
--to=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).