From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] build: ruby: Add 'gem-flags' key to ruby build system Date: Sat, 18 Jul 2015 17:20:28 +0200 Message-ID: <87380lo5kz.fsf@gnu.org> References: <20150713134451.GA29236@thebird.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGTuj-0006QA-QN for guix-devel@gnu.org; Sat, 18 Jul 2015 11:20:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZGTug-0005xv-Kv for guix-devel@gnu.org; Sat, 18 Jul 2015 11:20:33 -0400 In-Reply-To: <20150713134451.GA29236@thebird.nl> (Pjotr Prins's message of "Mon, 13 Jul 2015 15:44:51 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Pjotr Prins Cc: guix-devel Pjotr Prins skribis: > From ce8cfeadc8a661ff0fe0b96dc241d0063ed49ba3 Mon Sep 17 00:00:00 2001 > From: pjotrp > Date: Mon, 13 Jul 2015 15:32:36 +0200 > Subject: [PATCH] build: ruby: Add 'gem-flags' key to ruby build system > > * guix/build-system/ruby.scm (build): add 'gem-flags' key > * guix/build/ruby-build-system.scm (build): use 'gem-flags' key [...] > (zero? (system* "gem" "install" "--local" > - "--bindir" (string-append out "/bin"))))) > + "--bindir" (string-append out "/bin") "--" > + (string-join (cond (null? gem-flags)('())(gem-flags)= )))))) The =E2=80=98cond=E2=80=99 form is syntactically invalid, and =E2=80=98gem-= flags=E2=80=99 is not a procedure so it cannot be called. So I=E2=80=99ve changed that, also remov= ing the =E2=80=9C--=E2=80=9D. Pushed as 6e9f291. Thanks! Ludo=E2=80=99.