unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Ben Woodcroft <donttrustben@gmail.com>, guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add seqtk.
Date: Fri, 09 Sep 2016 13:37:45 +0100	[thread overview]
Message-ID: <871t0ts0yu.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20160909110834.8581-1-donttrustben@gmail.com>

Ben Woodcroft <donttrustben@gmail.com> writes:

> Well, despite the lightness of my touch, it seems the licensing is in now in
> order.  I've updated the package, here's an updated patch.  Better?

I don't think this was intended to be a commit message? :)

The program seems to bundle {khash,kseq}.h from htslib. Could you try
replacing them with the files directly from htslib? There are quite a
few examples of doing this already in bioinformatics.scm.

I also think the original description from github is better:
"Toolkit for processing sequences in FASTA/Q formats".

Other than that LGTM.

Thanks!
Marius

  reply	other threads:[~2016-09-09 12:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-24  5:07 [PATCH] Add seqtk Ben Woodcroft
2015-06-24 12:09 ` Mark H Weaver
2015-07-18  7:51   ` Ben Woodcroft
2015-07-18  9:07     ` John Darrington
2016-09-09 11:08       ` [PATCH] gnu: " Ben Woodcroft
2016-09-09 12:37         ` Marius Bakke [this message]
2016-09-09 12:54           ` Marius Bakke
2016-09-10  4:03           ` Ben Woodcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871t0ts0yu.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me \
    --to=mbakke@fastmail.com \
    --cc=donttrustben@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).