unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ben Woodcroft <b.woodcroft@uq.edu.au>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add seqtk.
Date: Sat, 18 Jul 2015 17:51:01 +1000	[thread overview]
Message-ID: <55AA0565.7080205@uq.edu.au> (raw)
In-Reply-To: <87zj3pi9zs.fsf@netris.org>

On 24/06/15 22:09, Mark H Weaver wrote:
> However, there's a bigger problem here.  Some of the code is not clearly
> licensed or has invalid copyright notices:
>
> * The copyright notice on kstring.h lacks copyright dates.
>
> * The copyright dates in seqtk.c and LICENSE are incorrect
>    ("20082-2012").
>
> * ksw.h and trimadap.c lack any copyright notice at all.  The mere
>    presence of a LICENSE file is not enough, especially given the lack of
>    any statement about the code license in the README.
>
> Would you be willing to ask the author to fix these issues?
I did this almost a month ago
https://github.com/lh3/seqtk/pull/60

But no response as yet. I think the common sense here is that it is 
expat licensed, WDYT? It would be a shame to exclude this software as it 
is quite well used in bioinformatics generally, but I'm happy to defer 
to your decision.

  reply	other threads:[~2015-07-18  7:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-24  5:07 [PATCH] Add seqtk Ben Woodcroft
2015-06-24 12:09 ` Mark H Weaver
2015-07-18  7:51   ` Ben Woodcroft [this message]
2015-07-18  9:07     ` John Darrington
2016-09-09 11:08       ` [PATCH] gnu: " Ben Woodcroft
2016-09-09 12:37         ` Marius Bakke
2016-09-09 12:54           ` Marius Bakke
2016-09-10  4:03           ` Ben Woodcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55AA0565.7080205@uq.edu.au \
    --to=b.woodcroft@uq.edu.au \
    --cc=guix-devel@gnu.org \
    --cc=mhw@netris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).