From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: Add seqtk. Date: Fri, 09 Sep 2016 13:37:45 +0100 Message-ID: <871t0ts0yu.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> References: <20150718090748.GA26418@jocasta.intra> <20160909110834.8581-1-donttrustben@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biL4C-00032d-Lr for guix-devel@gnu.org; Fri, 09 Sep 2016 08:38:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1biL49-0004n6-K6 for guix-devel@gnu.org; Fri, 09 Sep 2016 08:38:00 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:57653) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biL47-0004gv-B6 for guix-devel@gnu.org; Fri, 09 Sep 2016 08:37:57 -0400 In-Reply-To: <20160909110834.8581-1-donttrustben@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ben Woodcroft , guix-devel@gnu.org Ben Woodcroft writes: > Well, despite the lightness of my touch, it seems the licensing is in now in > order. I've updated the package, here's an updated patch. Better? I don't think this was intended to be a commit message? :) The program seems to bundle {khash,kseq}.h from htslib. Could you try replacing them with the files directly from htslib? There are quite a few examples of doing this already in bioinformatics.scm. I also think the original description from github is better: "Toolkit for processing sequences in FASTA/Q formats". Other than that LGTM. Thanks! Marius