From: zimoun <zimon.toutoune@gmail.com>
To: Christopher Baines <mail@cbaines.net>
Cc: Guix Devel <guix-devel@gnu.org>
Subject: Re: Fix incorrect date and commit in Data Service
Date: Tue, 17 Nov 2020 23:44:40 +0100 [thread overview]
Message-ID: <86wnyjmwmf.fsf@gmail.com> (raw)
In-Reply-To: <86zh3fmytq.fsf@gmail.com>
Hi again again,
On Tue, 17 Nov 2020 at 22:57, zimoun <zimon.toutoune@gmail.com> wrote:
>> Well, the Data Service should filter out the messages only containing
>> the header X-Git-Rev (commit hash) and use the date (Date) of the
>> message, which is, IMHO, the most accurate way to do. Instead of rely
>> on the date of message containing such headers:
>>
>> X-Git-Oldrev: 3b026eb3b1dd92c653d1a640b1280b96cfea3084
>> X-Git-Newrev: b5e51a06de08f446a07f678ff806cd71a355f7
>>
>> which can miss the correct commit introducing a change of derivation.
>
> The file data-service/branch-updated-emails.scm contains:
>
> (x-git-newrev (assq-ref headers 'x-git-newrev)))
>
> which is the issue. Instead, it should be
>
> (x-git-rev (assq-ref headers 'x-git-rev)))
>
> but maybe some filtering should be applied.
Following the discussion we add on IRC, if process all the commits is
too much for the Data Service, undetermined yet, processing all the
“state” could be only done for failing packages. Because it is the
concrete case where I (maybe we?) want exactness.
Thank you for all the explanations. Things clearer now. :-)
All the best,
simon
next prev parent reply other threads:[~2020-11-17 22:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 13:26 Data Services: use cases zimoun
2020-10-13 8:44 ` Pierre Neidhardt
2020-10-21 9:27 ` Ludovic Courtès
2020-10-21 9:39 ` Pierre Neidhardt
2020-10-21 10:19 ` zimoun
2020-11-16 19:28 ` Christopher Baines
2020-11-16 20:24 ` zimoun
2020-11-16 20:54 ` Christopher Baines
2020-11-16 21:12 ` zimoun
2020-11-16 21:50 ` Christopher Baines
2020-11-16 22:38 ` zimoun
2020-11-17 21:43 ` zimoun
2020-11-17 21:57 ` Fix incorrect date and commit in Data Service zimoun
2020-11-17 22:44 ` zimoun [this message]
2020-11-16 19:26 ` Data Services: use cases Christopher Baines
2020-11-16 19:20 ` Christopher Baines
2020-11-17 7:48 ` Pierre Neidhardt
2020-11-17 8:04 ` Christopher Baines
2020-11-17 8:49 ` Pierre Neidhardt
2020-11-17 19:34 ` Christopher Baines
2020-11-17 19:42 ` Pierre Neidhardt
2020-11-16 19:17 ` Christopher Baines
2020-11-16 20:34 ` zimoun
2020-11-16 21:08 ` Christopher Baines
2020-11-17 13:19 ` Linking to the data service Ludovic Courtès
2020-11-17 16:26 ` zimoun
2020-11-17 16:18 ` Data Services: use cases zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86wnyjmwmf.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=guix-devel@gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).