unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Christopher Baines <mail@cbaines.net>
Cc: Guix Devel <guix-devel@gnu.org>
Subject: Re: Data Services: use cases
Date: Mon, 16 Nov 2020 23:38:21 +0100	[thread overview]
Message-ID: <86o8jxorky.fsf@gmail.com> (raw)
In-Reply-To: <875z65m0of.fsf@cbaines.net>

On Mon, 16 Nov 2020 at 21:50, Christopher Baines <mail@cbaines.net> wrote:

>> The first commit producing j5llsz…-ghc-haddock is not
>> 3922208091 but 12dc9f58c4.  And then compare:
>>
>>                 author date              commit date
>> 3922208091|Thu Jul 23 14:03:19 2020|Fri Jul 24 14:21:31 2020
>> 12dc9f58c4|Fri Jul 24 09:56:25 2020|Fri Jul 24 14:21:30 2020
>>
>> I have not checked what guix-commits says.  Maybe the mess is
>> overthere.
>
> The author date and commit date won't necessarily match the date
> whatever branch is updated (and it's when that branch was updated that
> the Guix Data Service tries to store).

Yes.

> Generally, the author date will match or precede the commit date, which
> will match or precede the date the commit hit whatever branch.

Yes.


> Taking 3922208091 as an example, I pulled the commit dates in UTC [1]:
>
> AuthorDate:        Thu Jul 23 12:03:19 2020
> CommitDate:        Fri Jul 24 12:21:31 2020
> Guix Data Service: 2020-07-24 12:22:11 [2]

My point was: 3922208091 could not be the “correct“ and the correct one
could be 12dc9f58c4.  By correct, read the one introducing the output
j5llsz…-ghc-haddock.  And git show says:

                 author date              commit date
 3922208091|Thu Jul 23 14:03:19 2020|Fri Jul 24 14:21:31 2020
 12dc9f58c4|Fri Jul 24 09:56:25 2020|Fri Jul 24 14:21:30 2020

In the final Git tree history, the commit introducing
j5llsz…-ghc-haddock, i.e., changing from one row to another in the
output-history page, is the commit 12dc9f58c4.  Because of this 1 sec.
difference.

The question is what is the header email date?  But…

> 1: TZ=UTC git show --pretty=fuller 3922208091
> 2:
> https://data.guix.gnu.org/revision/39222080911eaf3d7f74effe4467c1a04464aef3

…the revision 12dc9f58c4 is not available.  See:

http://data.guix.gnu.org/revision/12dc9f58c422c06bf9950f21c54ca3df1dc40af1

Maybe that the explanation.  I do not know.


> I think the author date says something about when the commit was
> originally created. Rebasing and adding the Signed-off-by by bit will
> update the commit date (but not the author date). Finally, the Guix
> Data

Exact.

> Service will store when the branch was updated (it uses the date of the
> email as a proxy for this).

Now, after this discussion, I am not convinced anymore that the email
header date is the right thing because we (user) do not have this
information when debugging locally; only the Git checkout.  Anyway.


All is clear and I am ready to move on. :-) Thanks for all the explanations.


Cheers,
simon


  reply	other threads:[~2020-11-16 22:50 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-12 13:26 Data Services: use cases zimoun
2020-10-13  8:44 ` Pierre Neidhardt
2020-10-21  9:27   ` Ludovic Courtès
2020-10-21  9:39     ` Pierre Neidhardt
2020-10-21 10:19     ` zimoun
2020-11-16 19:28       ` Christopher Baines
2020-11-16 20:24         ` zimoun
2020-11-16 20:54           ` Christopher Baines
2020-11-16 21:12             ` zimoun
2020-11-16 21:50               ` Christopher Baines
2020-11-16 22:38                 ` zimoun [this message]
2020-11-17 21:43                   ` zimoun
2020-11-17 21:57                     ` Fix incorrect date and commit in Data Service zimoun
2020-11-17 22:44                       ` zimoun
2020-11-16 19:26     ` Data Services: use cases Christopher Baines
2020-11-16 19:20   ` Christopher Baines
2020-11-17  7:48     ` Pierre Neidhardt
2020-11-17  8:04       ` Christopher Baines
2020-11-17  8:49         ` Pierre Neidhardt
2020-11-17 19:34           ` Christopher Baines
2020-11-17 19:42             ` Pierre Neidhardt
2020-11-16 19:17 ` Christopher Baines
2020-11-16 20:34   ` zimoun
2020-11-16 21:08     ` Christopher Baines
2020-11-17 13:19       ` Linking to the data service Ludovic Courtès
2020-11-17 16:26         ` zimoun
2020-11-17 16:18       ` Data Services: use cases zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86o8jxorky.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).