From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0DHbBPBStF8VeQAA0tVLHw (envelope-from ) for ; Tue, 17 Nov 2020 22:47:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id SNjUAPBStF9eFwAAB5/wlQ (envelope-from ) for ; Tue, 17 Nov 2020 22:47:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 985BB9405D2 for ; Tue, 17 Nov 2020 22:47:11 +0000 (UTC) Received: from localhost ([::1]:60630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kf9kk-0002Yf-Dd for larch@yhetil.org; Tue, 17 Nov 2020 17:47:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kf9kA-0002Bw-Vh for guix-devel@gnu.org; Tue, 17 Nov 2020 17:46:34 -0500 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:33249) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kf9k9-00084e-BA for guix-devel@gnu.org; Tue, 17 Nov 2020 17:46:34 -0500 Received: by mail-wr1-x42d.google.com with SMTP id u12so17981923wrt.0 for ; Tue, 17 Nov 2020 14:46:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=OV83BysILU+3XveQklfiBJF9cjXw/vm75qaHqQcH+YY=; b=n56RN2g20R4L3TCLwhebD1Q5ATuZ1aVF15vbLVq3YcETZImApEuf+5k4G2WQBtJIBO UPF3HsG0nYBlANLjn1ekCOQaPiqns/62ai68zdrnro53l+toWOUCKgo4aS3wOoCK46Ak hDK88GrFy8sde1I5u8lwNpBmfJvmnOU12PbwbT+iklfquUWYOFMtvaVTmq9uPP2se6f9 6IoEpqKg2VY5iUZ05BjG8SU9R5nhkUVR3a5uJ6iBJ28XrC2iNJVfZm5dFNeU7eUuCmop sHC26BBx0cfK+CR3bkznHaNppHsuWZvAfF4iLKYfg3e3qqzQRiU7XCQN5h7il4XWuYyi FcQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=OV83BysILU+3XveQklfiBJF9cjXw/vm75qaHqQcH+YY=; b=UNOmNGM0JrsrK2j9dJAvQBBDOWoAvLxjYavSvrJfkBkSsd1oxb1v3kSPHqdqMhn3CD p7qK9mmWPuHxS5MK+9QpuSbx/2K1vgDz4uJ9045AY+fuzn85B0AMe14LYmldtjT9NHlS SV1rDVJiJxOEO8iKZcRyP8v5jqo9KmJNNNL/7Yng0PgUQHEdzN6ygAJIPACpRHdqeLKj PV+oWnw3bOBrQynSQyNcusVL1gTVO8FNFhzCXHu1U9T+S9CwqWK62ZNiI315avakWxEC zr9FOxc2VtBSx7zNhOLj5c+nDr1eat7hmpbVhy+0BzmYvgHMkaJvvuB5mo+gpzr6nyvg lOZQ== X-Gm-Message-State: AOAM5332U48kRB0Bi6I1Wfp/rglx3M9D0jHRCM/h+4ynK5ntxRo1dcHo e+2umroVqjHbqqei0sWhKeS8kgG6GyUsEw== X-Google-Smtp-Source: ABdhPJzB6ujvq589og4wbP6IfMItw1IZpWq8QLVxuG2kY0AhIEI3SDz6Rog0nSQHyoTcp7EVlaF8HA== X-Received: by 2002:adf:fe46:: with SMTP id m6mr1857503wrs.254.1605653189851; Tue, 17 Nov 2020 14:46:29 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id t17sm300200wmi.3.2020.11.17.14.46.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 14:46:29 -0800 (PST) From: zimoun To: Christopher Baines Subject: Re: Fix incorrect date and commit in Data Service In-Reply-To: <86zh3fmytq.fsf@gmail.com> References: <868scbvalo.fsf@gmail.com> <87d01m3475.fsf@ambrevar.xyz> <87a6wg7wto.fsf@gnu.org> <87k0ulm78x.fsf@cbaines.net> <86a6vhqcc3.fsf@gmail.com> <87blfxm39q.fsf@cbaines.net> <86v9e5ovjp.fsf@gmail.com> <875z65m0of.fsf@cbaines.net> <86o8jxorky.fsf@gmail.com> <863617oe1h.fsf@gmail.com> <86zh3fmytq.fsf@gmail.com> Date: Tue, 17 Nov 2020 23:44:40 +0100 Message-ID: <86wnyjmwmf.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=zimon.toutoune@gmail.com; helo=mail-wr1-x42d.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix Devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=n56RN2g2; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -1.71 X-TUID: XZawsV27znOu Hi again again, On Tue, 17 Nov 2020 at 22:57, zimoun wrote: >> Well, the Data Service should filter out the messages only containing >> the header X-Git-Rev (commit hash) and use the date (Date) of the >> message, which is, IMHO, the most accurate way to do. Instead of rely >> on the date of message containing such headers: >> >> X-Git-Oldrev: 3b026eb3b1dd92c653d1a640b1280b96cfea3084 >> X-Git-Newrev: b5e51a06de08f446a07f678ff806cd71a355f7 >> >> which can miss the correct commit introducing a change of derivation. > > The file data-service/branch-updated-emails.scm contains: > > (x-git-newrev (assq-ref headers 'x-git-newrev))) > > which is the issue. Instead, it should be > > (x-git-rev (assq-ref headers 'x-git-rev))) > > but maybe some filtering should be applied. Following the discussion we add on IRC, if process all the commits is too much for the Data Service, undetermined yet, processing all the =E2=80=9Cstate=E2=80=9D could be only done for failing packages. Because i= t is the concrete case where I (maybe we?) want exactness. Thank you for all the explanations. Things clearer now. :-) All the best, simon