From: zimoun <zimon.toutoune@gmail.com>
To: Josselin Poiret <dev@jpoiret.xyz>, kiasoc5 <kiasoc5@disroot.org>,
guix-devel@gnu.org, Danny Milosavljevic <dannym@scratchpost.org>
Subject: Re: git guix checkout automation for contributors
Date: Tue, 27 Sep 2022 10:38:35 +0200 [thread overview]
Message-ID: <868rm5w6t0.fsf@gmail.com> (raw)
In-Reply-To: <878rm5c1od.fsf@jpoiret.xyz>
Hi,
On Mon, 26 Sep 2022 at 22:37, Josselin Poiret <dev@jpoiret.xyz> wrote:
>> When running “guix time-machine” (inferiors), all the machinery
>> “./bootstrap && ./configure --localstatevar=/var && make” is
>> transparently done. We discussed that at the 10 Years event with
>> Josselin.
>
> Yes! Although FTR none of bootstrap, configure or make are actually run
> when using time-machine, it's a totally different way of building :).
Yeah, I simplified since it is somehow a detail. :-) Interested reader
can read Josselin’s explanations [1] about the differences.
1: <https://yhetil.org/guix/87let6roxo.fsf@jpoiret.xyz>
> The upshot is that we could even provide a flag like `guix time-machine
> --issue=NNNNN` that would provide the corresponding guix branch at
> https://git.guix-patches.cbaines.net/guix-patches/, and benefit from the
> built substitutes if there are. It would need some more formal URL and
> discussion around this feature, but everything's in place for it to
> happen.
Well, I think it would be better to have another subcommand. There is a
“guix review” draft somewhere but I do not currently find it.
It could be nice to see if it already just work using ’guix time-machine
-C channels.scm’ where the file channels.scm points to some QA.
>> Therefore, we could imagine something similar for helping people to
>> contribute:
>>
>> 1. use (test?) unmerged patches
>> 2. update and/or create new patches
>
> I think the second part would need a bit of work though, refer to Chris'
> mail [1] for what would need to be done (namely, making `git send-email`
> easier and refactoring the contribution guidelines).
I do not think git-send-email is the major roadblock here. From what I
have seen two steps appear more difficult for infrequent contributors:
a) commit message
b) correct format-patch
About a) it could be nice to have a tool roughly checking. For
instance, we have Emacs yasnippets for adding packages; we could imagine
a tool that check is the commit message respect some standards; at least
help to detect many common “mistakes“.
About b), from the feedback I get, people used to Merge/Pull Request do
not get at first why this step is required; since they usually git-pull
and send a request. Then, many patches do not contain some base-commit
information because people miss the option --base; implicitly
self-contained with MR/PR. Idem the missing --reroll-count.
Cheers,
simon
next prev parent reply other threads:[~2022-09-27 13:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.14689.1664114844.1079.guix-devel@gnu.org>
2022-09-25 21:40 ` git guix checkout automation for contributors kiasoc5
2022-09-26 10:55 ` zimoun
2022-09-26 20:37 ` Josselin Poiret
2022-09-27 8:38 ` zimoun [this message]
2022-09-25 14:06 Danny Milosavljevic
2022-09-25 15:04 ` Danny Milosavljevic
2022-09-25 16:36 ` Maxime Devos
2022-10-01 17:18 ` Ludovic Courtès
2022-10-05 3:18 ` Maxim Cournoyer
2022-11-02 18:41 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868rm5w6t0.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=dannym@scratchpost.org \
--cc=dev@jpoiret.xyz \
--cc=guix-devel@gnu.org \
--cc=kiasoc5@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).