From: Maxime Devos <maximedevos@telenet.be>
To: Danny Milosavljevic <dannym@scratchpost.org>,
Guix-devel <guix-devel@gnu.org>
Subject: Re: git guix checkout automation for contributors
Date: Sun, 25 Sep 2022 18:36:54 +0200 [thread overview]
Message-ID: <487f1f43-cedd-eccb-6dbf-1317a800dde5@telenet.be> (raw)
In-Reply-To: <20220925170453.34c12c0c@scratchpost.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 2583 bytes --]
On 25-09-2022 17:04, Danny Milosavljevic wrote:
> Also, this doesn't work:
>
> On Sun, 25 Sep 2022 16:06:06 +0200
> Danny Milosavljevic<dannym@scratchpost.org> wrote:
>
> (1) install the guix system
> (2) log in as regular user
> (3c) git clone --depth=1https://git.savannah.gnu.org/git/guix.git guix \
> && cd guix \
> && guix shell
This issue had been reported in <https://issues.guix.gnu.org/50960#13>:
Liliana Marie Prikler wrote:
> What would happen on the top-level of the Guix source tree or deep
> inside the tree of a guile package that deals with manifests, that
> aren't necessarily related to Guix? I think we should try searching
> for something less ambiguous first (".guix-shell/manifest" perhaps?)
> and maybe also provide further options after manifest.scm (e.g. build-
> aux/guix.scm or etc/guix.scm)
This issue was considered unlikely:
Ludovic Courtès wrote:
> You mean a directory that contains a file named ‘guix.scm’ or
> ‘manifest.scm’ but that happens to do something completely unrelated?
>
> We can never rule this out, but I’d say it’s unlikely (these two
> conventions are rather well established) and it’s up to the user to pay
> attention.
>
> WDYT?
Later shown to be incorrect on the top-level of the Guix source tree
more explicitly:
Maxime Devos wrote:
> Guix itself doesn't follow this convention: the guix source tree has an unrelated
> "guix.scm" file, that doesn't evaluate to a package. I'd expect that running
> "guix shell" within the guix source tree would be equivalent to
> "guix environment guix", but currently this doesn't seem to be the case.
As such, it was proposed to leave out auto-detection of ‘guix.scm’:
Liliana Marie Prikler wrote: > Leaving out the auto-detection of
‘guix.scm’ and ‘manifest.scm’ for now
> is a good idea, given that Guix itself would be an edge-case for that.
> [ proposed alternative solution ]
It was agreed that auto-detection fails here:
Ludovic Courtès wrote:
>> Guix itself doesn't follow this convention: the guix source tree has an unrelated
>> "guix.scm" file, that doesn't evaluate to a package.
>
> Indeed, but that’s because Guix predates the convention. :-)
>
> Toggle quote (4 lines)
>> I'd expect that running "guix shell" within the guix source tree would
>> be equivalent to "guix environment guix", but currently this doesn't
>> seem to be the case.
>
> Right, it would fail poorly in this particular case.
... and then ignored, AFAICT.
Greetings,
Maxime.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2022-09-25 16:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 14:06 git guix checkout automation for contributors Danny Milosavljevic
2022-09-25 15:04 ` Danny Milosavljevic
2022-09-25 16:36 ` Maxime Devos [this message]
2022-10-01 17:18 ` Ludovic Courtès
2022-10-05 3:18 ` Maxim Cournoyer
2022-11-02 18:41 ` zimoun
[not found] <mailman.14689.1664114844.1079.guix-devel@gnu.org>
2022-09-25 21:40 ` kiasoc5
2022-09-26 10:55 ` zimoun
2022-09-26 20:37 ` Josselin Poiret
2022-09-27 8:38 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487f1f43-cedd-eccb-6dbf-1317a800dde5@telenet.be \
--to=maximedevos@telenet.be \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).