From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id AHkFImr7MmOaqQAAbAwnHQ (envelope-from ) for ; Tue, 27 Sep 2022 15:32:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id UI8NImr7MmNpHgAA9RJhRA (envelope-from ) for ; Tue, 27 Sep 2022 15:32:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2ADCC27F09 for ; Tue, 27 Sep 2022 15:32:25 +0200 (CEST) Received: from localhost ([::1]:59654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odAhE-0003Um-Qh for larch@yhetil.org; Tue, 27 Sep 2022 09:32:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1od8u9-0007ca-ED for guix-devel@gnu.org; Tue, 27 Sep 2022 07:37:43 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:46941) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1od8u5-0004Hd-Mx for guix-devel@gnu.org; Tue, 27 Sep 2022 07:37:37 -0400 Received: by mail-wr1-x42f.google.com with SMTP id bk15so6800658wrb.13 for ; Tue, 27 Sep 2022 04:37:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:from:to:cc:subject:date; bh=XWGdDr57MoJNBaOEqpTFFjq473uMu17lQIkN3l2fhH4=; b=YBgs2cK/OhCWXfeUq6YGTmwNciBneaFtbPzCuYkRLhDtPr5ZJDGHbOhbY8bulSMO3A TlwVBKfQ1z1tXfZOgU/EhcFn5fD8xO8u0ObFR+kvYlpyl0oNALZCgeIHYpiNX0o0r3bV xb5UDGlROKV+gfBs4vDYd8kaHJX3U91xEJKic76QZiQj0kdmX30qvOYjPZvfhYf4sZR9 Gq3lscJliFFQ58ZdRjiePj2h6/8Sjtph70O7RmBL1rt8D/zn9j6jmnBloE8viXcOxtsN caZDP2KBhiq78iMt2Qp/WMCw5DrwVSU9Zx9qyoarjIB0PT7+JBnDjefkyxjT9ipZqDHW rKmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:x-gm-message-state:from:to:cc:subject :date; bh=XWGdDr57MoJNBaOEqpTFFjq473uMu17lQIkN3l2fhH4=; b=E6KaxWD9ApkDTf+NnpOqXW5gu9JbcE7yMGqDselSkjx81Rx1oyD6BT30Rl/4Tt4kvR PXAH6vxSM/HDB9JWzUPihwxZLbezxW4VFLGsmiwkX6lRloH0YM7NTxangx3EpF6MshkR YWxldZOrWtvc7xnVQs7AeH5o69siH/WxYih8YRtF7hqGdT1gNlxkVVgxjjRXNwXWgy9P n1PpcGc2IMpNF0pC5kZAeixFYFQhi/TiQiSWhMpAvFv+N3tCT5NJZx5eooYUL+f7MoXp hFnvQNG87EY7UdZQ2Tz9zRjOq5QfUfBwqS2dy71z4/hu4DGVc1vO/MRU6VShndaFAs6l hDLw== X-Gm-Message-State: ACrzQf2JjLcHKA/uC0q7IscOXJzVG2kFwgc0FpKJL0CNXlf845yVOiyK oLDgraRF8DzrLDX34pEaMOE= X-Google-Smtp-Source: AMsMyM6GY6Q3Vvd1/+o9XnKrm2JczW+zQpCLYfBzmqqZ4lCsuk0Qrd7cJ0L6G0MH68nG0a9NBWbg7g== X-Received: by 2002:adf:d1c9:0:b0:225:f98:d602 with SMTP id b9-20020adfd1c9000000b002250f98d602mr16880565wrd.419.1664278650167; Tue, 27 Sep 2022 04:37:30 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id w10-20020a05600c474a00b003b4ac05a8a4sm17409313wmo.27.2022.09.27.04.37.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Sep 2022 04:37:29 -0700 (PDT) From: zimoun To: Josselin Poiret , kiasoc5 , guix-devel@gnu.org, Danny Milosavljevic Subject: Re: git guix checkout automation for contributors In-Reply-To: <878rm5c1od.fsf@jpoiret.xyz> References: <20220925214010.24cf55f0@aria> <878rm6csm9.fsf@gmail.com> <878rm5c1od.fsf@jpoiret.xyz> Date: Tue, 27 Sep 2022 10:38:35 +0200 Message-ID: <868rm5w6t0.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=zimon.toutoune@gmail.com; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664285546; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=XWGdDr57MoJNBaOEqpTFFjq473uMu17lQIkN3l2fhH4=; b=ocf8yeSClGylSkv6rYjVp+CuKJAJ/wpfnbI1JRUEisbvqQpvmfUNTWOrjVsYECSlzkT7jE r8XLX0NqNPDNcDmrG8WC4yLrYaqoEHRKVI24a/BDo/SI/gcqJMfBnLt6A2/h9v5RbC0/fS iMYXElJ1PO+02Rqw2mNVs+SGHvG9+IxHMUWcowreKvqz/E9RJ4qKwuRuhRIDCl8V5oPopd OZBO+SUSHP1YViVo22uRyQqARmVpCncDQC/PixxxaRl9upVM+2Z6caHPmwXiFPs+OZ6y3V pkVFW0ehk4zZQTm3OdmXTca9rU+NjI7TDpvPu2PLjVN3MT2C93bCQ9NsvhnQGw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664285546; a=rsa-sha256; cv=none; b=Pujeiiq+qcJzVuk++siKVg16SL/ONUH7+c1zS28BAZ6LR2HGEqTrDAvgEEA421L29OdeR6 xsiQOysOqMmvw77M5aPL1JfFW+sjkrj0i739paWsYScUc/yphOrlZT4n92ZLeRZfT/8iFa AfGmWSPSrducJLSp1AYlBX3zgLyc7fDRz7XhkY/QrceRA9vrfCQ/AugDgF+D6YjRO26CNh Gfo5QyjDxIM4LzwAwQOmziF4F7mgn82PugP/XdYg//IJ7NxUUBqQZEJK/6vZ/p+aAeeHJA QYN+a24dO8XCE34e6AUUb7j/TMVRJ+zVEYBc/M2HLFO7SLoBiPvIqUPjGvv24w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="YBgs2cK/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.34 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="YBgs2cK/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2ADCC27F09 X-Spam-Score: -2.34 X-Migadu-Scanner: scn1.migadu.com X-TUID: lU0Bw33brcJW Hi, On Mon, 26 Sep 2022 at 22:37, Josselin Poiret wrote: >> When running =E2=80=9Cguix time-machine=E2=80=9D (inferiors), all the ma= chinery >> =E2=80=9C./bootstrap && ./configure --localstatevar=3D/var && make=E2=80= =9D is >> transparently done. We discussed that at the 10 Years event with >> Josselin. > > Yes! Although FTR none of bootstrap, configure or make are actually run > when using time-machine, it's a totally different way of building :). Yeah, I simplified since it is somehow a detail. :-) Interested reader can read Josselin=E2=80=99s explanations [1] about the differences. 1: > The upshot is that we could even provide a flag like `guix time-machine > --issue=3DNNNNN` that would provide the corresponding guix branch at > https://git.guix-patches.cbaines.net/guix-patches/, and benefit from the > built substitutes if there are. It would need some more formal URL and > discussion around this feature, but everything's in place for it to > happen. Well, I think it would be better to have another subcommand. There is a =E2=80=9Cguix review=E2=80=9D draft somewhere but I do not currently find i= t. It could be nice to see if it already just work using =E2=80=99guix time-ma= chine -C channels.scm=E2=80=99 where the file channels.scm points to some QA. >> Therefore, we could imagine something similar for helping people to >> contribute: >> >> 1. use (test?) unmerged patches >> 2. update and/or create new patches > > I think the second part would need a bit of work though, refer to Chris' > mail [1] for what would need to be done (namely, making `git send-email` > easier and refactoring the contribution guidelines). I do not think git-send-email is the major roadblock here. From what I have seen two steps appear more difficult for infrequent contributors: a) commit message b) correct format-patch About a) it could be nice to have a tool roughly checking. For instance, we have Emacs yasnippets for adding packages; we could imagine a tool that check is the commit message respect some standards; at least help to detect many common =E2=80=9Cmistakes=E2=80=9C. About b), from the feedback I get, people used to Merge/Pull Request do not get at first why this step is required; since they usually git-pull and send a request. Then, many patches do not contain some base-commit information because people miss the option --base; implicitly self-contained with MR/PR. Idem the missing --reroll-count. Cheers, simon