* 01/02: packages: Adjust 'generate-package-cache' for Guile 3.0.9.
[not found] <20230125172010.9D0A7C00A7F@vcs2.savannah.gnu.org>
@ 2023-01-26 11:59 ` Simon Tournier
2023-01-30 21:52 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: Simon Tournier @ 2023-01-26 11:59 UTC (permalink / raw)
To: Guix Devel, Ludovic Courtès; +Cc: guix-commits
Hi,
Commit ba1b61a72d56600e7c6f9c490129e95ab9ba0c9e reads:
--8<---------------cut here---------------start------------->8---
packages: Adjust 'generate-package-cache' for Guile 3.0.9.
* gnu/packages.scm (generate-package-cache): Adjust for Guile 3.0.9.
[...]
@@ -442,10 +443,15 @@ (define exp
(lambda (port)
;; Store the cache as a '.go' file. This makes loading fast and reduces
;; heap usage since some of the static data is directly mmapped.
- (put-bytevector port
- (compile `'(,@exp)
- #:to 'bytecode
- #:opts '(#:to-file? #t)))))
+ (match (compile `'(,@exp)
+ #:to 'bytecode
+ #:opts '(#:to-file? #t))
+ ((? bytevector? bv)
+ (put-bytevector port bv))
+ (proc
+ ;; In Guile 3.0.9, the linker can return a procedure instead of a
+ ;; bytevector. Adjust to that.
+ (proc port)))))
cache-file)
--8<---------------cut here---------------end--------------->8---
Cool!
What are the performances about this change? Does it improve the
generation of the cache? Faster or slower?
Or the resulting cache, is it larger or smaller?
Cheers,
simon
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 01/02: packages: Adjust 'generate-package-cache' for Guile 3.0.9.
2023-01-26 11:59 ` 01/02: packages: Adjust 'generate-package-cache' for Guile 3.0.9 Simon Tournier
@ 2023-01-30 21:52 ` Ludovic Courtès
2023-01-31 10:03 ` Simon Tournier
0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2023-01-30 21:52 UTC (permalink / raw)
To: Simon Tournier; +Cc: Guix Devel, guix-commits
Hi!
Simon Tournier <zimon.toutoune@gmail.com> skribis:
> Commit ba1b61a72d56600e7c6f9c490129e95ab9ba0c9e reads:
>
> packages: Adjust 'generate-package-cache' for Guile 3.0.9.
>
> * gnu/packages.scm (generate-package-cache): Adjust for Guile 3.0.9.
[...]
> What are the performances about this change? Does it improve the
> generation of the cache? Faster or slower?
>
> Or the resulting cache, is it larger or smaller?
The resulting cache is unchanged and build time should be similar, but
memory usage is slightly reduced:
https://lists.gnu.org/archive/html/guile-devel/2023-01/msg00013.html
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 01/02: packages: Adjust 'generate-package-cache' for Guile 3.0.9.
2023-01-30 21:52 ` Ludovic Courtès
@ 2023-01-31 10:03 ` Simon Tournier
0 siblings, 0 replies; 3+ messages in thread
From: Simon Tournier @ 2023-01-31 10:03 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: Guix Devel, guix-commits
Hi Ludo,
On Mon, 30 Jan 2023 at 22:52, Ludovic Courtès <ludo@gnu.org> wrote:
>> What are the performances about this change? Does it improve the
>> generation of the cache? Faster or slower?
>>
>> Or the resulting cache, is it larger or smaller?
>
> The resulting cache is unchanged and build time should be similar, but
> memory usage is slightly reduced:
>
> https://lists.gnu.org/archive/html/guile-devel/2023-01/msg00013.html
Thanks for the pointer. Cool!
Cheers,
simon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-31 11:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230125172010.9D0A7C00A7F@vcs2.savannah.gnu.org>
2023-01-26 11:59 ` 01/02: packages: Adjust 'generate-package-cache' for Guile 3.0.9 Simon Tournier
2023-01-30 21:52 ` Ludovic Courtès
2023-01-31 10:03 ` Simon Tournier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).