unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Simon Tournier <zimon.toutoune@gmail.com>
To: "Guix Devel" <guix-devel@gnu.org>, "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-commits@gnu.org
Subject: 01/02: packages: Adjust 'generate-package-cache' for Guile 3.0.9.
Date: Thu, 26 Jan 2023 12:59:51 +0100	[thread overview]
Message-ID: <868rhpsdzc.fsf@gmail.com> (raw)
In-Reply-To: <20230125172010.9D0A7C00A7F@vcs2.savannah.gnu.org>

Hi,

Commit ba1b61a72d56600e7c6f9c490129e95ab9ba0c9e reads:

--8<---------------cut here---------------start------------->8---
packages: Adjust 'generate-package-cache' for Guile 3.0.9.

* gnu/packages.scm (generate-package-cache): Adjust for Guile 3.0.9.

[...]

@@ -442,10 +443,15 @@ (define exp
     (lambda (port)
       ;; Store the cache as a '.go' file.  This makes loading fast and reduces
       ;; heap usage since some of the static data is directly mmapped.
-      (put-bytevector port
-                      (compile `'(,@exp)
-                               #:to 'bytecode
-                               #:opts '(#:to-file? #t)))))
+      (match (compile `'(,@exp)
+                      #:to 'bytecode
+                      #:opts '(#:to-file? #t))
+        ((? bytevector? bv)
+         (put-bytevector port bv))
+        (proc
+         ;; In Guile 3.0.9, the linker can return a procedure instead of a
+         ;; bytevector.  Adjust to that.
+         (proc port)))))
   cache-file)
--8<---------------cut here---------------end--------------->8---

Cool!

What are the performances about this change?  Does it improve the
generation of the cache?  Faster or slower?

Or the resulting cache, is it larger or smaller?


Cheers,
simon


       reply	other threads:[~2023-01-26 13:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230125172010.9D0A7C00A7F@vcs2.savannah.gnu.org>
2023-01-26 11:59 ` Simon Tournier [this message]
2023-01-30 21:52   ` 01/02: packages: Adjust 'generate-package-cache' for Guile 3.0.9 Ludovic Courtès
2023-01-31 10:03     ` Simon Tournier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=868rhpsdzc.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=guix-commits@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).