* [PATCH] gnu: Add vis
@ 2016-12-05 21:34 José Miguel Sánchez García
2016-12-06 14:30 ` Marius Bakke
0 siblings, 1 reply; 3+ messages in thread
From: José Miguel Sánchez García @ 2016-12-05 21:34 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 138 bytes --]
Add vis (I hope it's finally correct!). Remember to add it after adding
libtermkey and lua-lpeg.
--
José Miguel Sánchez García
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-vis.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-vis.patch, Size: 2947 bytes --]
From 9bdbc2064c0dc62e66291d18718932ca8b7f67f0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Miguel=20S=C3=A1nchez=20Garc=C3=ADa?=
<jmi2k@openmailbox.org>
Date: Mon, 5 Dec 2016 15:17:40 +0100
Subject: [PATCH] gnu: Add vis.
---
gnu/packages/vis.scm | 58 ++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 58 insertions(+)
create mode 100644 gnu/packages/vis.scm
diff --git a/gnu/packages/vis.scm b/gnu/packages/vis.scm
new file mode 100644
index 0000000..39150dc
--- /dev/null
+++ b/gnu/packages/vis.scm
@@ -0,0 +1,57 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 José Miguel Sánchez García <jmi2k@openmailbox.org>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+; TODO: Installation succeeds, but vis complains about not finding base16-theme
+
+(define-module (gnu packages vis)
+ #:use-module (guix packages)
+ #:use-module (guix git-download)
+ #:use-module (guix build-system gnu)
+ #:use-module (guix licenses)
+ #:use-module (gnu packages ncurses)
+ #:use-module (gnu packages libtermkey)
+ #:use-module (gnu packages lua)
+ #:use-module (gnu packages lua-lpeg))
+
+(define-public vis
+ (package
+ (name "vis")
+ (version "0.2")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url (string-append "git://github.com/martanne/"
+ name ".git"))
+ (commit (string-append "v" version))))
+ (sha256
+ (base32 "05pxycrhx297hdwkgky00g9s78dqcaam3lhp3ba903ma605dn34f"))))
+ (build-system gnu-build-system)
+ (arguments '(
+ #:make-flags '("CFLAGS=-pie")
+ #:tests? #f))
+ (inputs `(("lua", lua)))
+ (native-inputs `(("ncurses", ncurses)
+ ("libtermkey", libtermkey)
+ ("lua-lpeg", lua-lpeg)))
+ (synopsis "Vim-like text editor")
+ (description
+ "Vis aims to be a modern, legacy free, simple yet efficient vim-like text
+editor. It extends vim's modal editing with built-in support for multiple
+cursors/selecctions and combines it with sam's structural regular expression
+based command language.")
+ (home-page "https://github.com/martanne/vis")
+ (license isc)))
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gnu: Add vis
2016-12-05 21:34 [PATCH] gnu: Add vis José Miguel Sánchez García
@ 2016-12-06 14:30 ` Marius Bakke
0 siblings, 0 replies; 3+ messages in thread
From: Marius Bakke @ 2016-12-06 14:30 UTC (permalink / raw)
To: José Miguel Sánchez García, guix-devel
[-- Attachment #1: Type: text/plain, Size: 4116 bytes --]
José Miguel Sánchez García <jmi2k@openmailbox.org> writes:
> Add vis (I hope it's finally correct!). Remember to add it after adding
> libtermkey and lua-lpeg.
Thanks! I only have very minor comments on this one ;-)
> --
> José Miguel Sánchez García
> From 9bdbc2064c0dc62e66291d18718932ca8b7f67f0 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Jos=C3=A9=20Miguel=20S=C3=A1nchez=20Garc=C3=ADa?=
> <jmi2k@openmailbox.org>
> Date: Mon, 5 Dec 2016 15:17:40 +0100
> Subject: [PATCH] gnu: Add vis.
>
> ---
> gnu/packages/vis.scm | 58 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 58 insertions(+)
> create mode 100644 gnu/packages/vis.scm
Could you name this 'text-editors.scm'? Currently we have a file for
each editor, but I think we should try to gather the ones without large
ecosystems into a single file. Please also add it to 'local.mk'. See the
commit log for examples, and how to format the commit message.
> diff --git a/gnu/packages/vis.scm b/gnu/packages/vis.scm
> new file mode 100644
> index 0000000..39150dc
> --- /dev/null
> +++ b/gnu/packages/vis.scm
> @@ -0,0 +1,57 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2016 José Miguel Sánchez García <jmi2k@openmailbox.org>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
> +
> +; TODO: Installation succeeds, but vis complains about not finding base16-theme
> +
> +(define-module (gnu packages vis)
> + #:use-module (guix packages)
> + #:use-module (guix git-download)
> + #:use-module (guix build-system gnu)
> + #:use-module (guix licenses)
> + #:use-module (gnu packages ncurses)
> + #:use-module (gnu packages libtermkey)
> + #:use-module (gnu packages lua)
> + #:use-module (gnu packages lua-lpeg))
> +
> +(define-public vis
> + (package
> + (name "vis")
> + (version "0.2")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url (string-append "git://github.com/martanne/"
> + name ".git"))
> + (commit (string-append "v" version))))
Since it uses a tagged release, downloading the tarball from
https://github.com/martanne/vis/releases is better. Git downloads use
more bandwidth, and are more likely to run into firewall problems.
> + (sha256
> + (base32 "05pxycrhx297hdwkgky00g9s78dqcaam3lhp3ba903ma605dn34f"))))
> + (build-system gnu-build-system)
> + (arguments '(
> + #:make-flags '("CFLAGS=-pie")
> + #:tests? #f))
> + (inputs `(("lua", lua)))
> + (native-inputs `(("ncurses", ncurses)
> + ("libtermkey", libtermkey)
> + ("lua-lpeg", lua-lpeg)))
All of these should probably be 'inputs' instead of 'native-inputs'.
> + (synopsis "Vim-like text editor")
> + (description
> + "Vis aims to be a modern, legacy free, simple yet efficient vim-like text
> +editor. It extends vim's modal editing with built-in support for multiple
> +cursors/selecctions and combines it with sam's structural regular expression
> +based command language.")
> + (home-page "https://github.com/martanne/vis")
> + (license isc)))
The rest looks good. I think this series can be committed after the
mentioned improvements. Thanks for your patience! :-)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] gnu: Add vis.
@ 2016-12-05 14:35 José Miguel Sánchez García
0 siblings, 0 replies; 3+ messages in thread
From: José Miguel Sánchez García @ 2016-12-05 14:35 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 419 bytes --]
Add vis after fixing some inconveniences found in my last attempt
<http://lists.gnu.org/archive/html/guix-devel/2016-12/msg00068.html>. I
can't run guix lint on it now, but I haven't changed anything too
important, so it should be fine.
This package requires libtermkey and lua-lpeg, for which I submitted two
patches (see my last two messages). Be sure to add them before.
José Miguel Sánchez García
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-vis.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-vis.patch, Size: 2863 bytes --]
From 9bdbc2064c0dc62e66291d18718932ca8b7f67f0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Miguel=20S=C3=A1nchez=20Garc=C3=ADa?=
<jmi2k@openmailbox.org>
Date: Mon, 5 Dec 2016 15:17:40 +0100
Subject: [PATCH] gnu: Add vis.
---
gnu/packages/vis.scm | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 57 insertions(+)
create mode 100644 gnu/packages/vis.scm
diff --git a/gnu/packages/vis.scm b/gnu/packages/vis.scm
new file mode 100644
index 0000000..39150dc
--- /dev/null
+++ b/gnu/packages/vis.scm
@@ -0,0 +1,57 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 José Miguel Sánchez García <jmi2k@openmailbox.org>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+; TODO: Installation succeeds, but vis complains about not finding base16-theme
+
+(define-module (gnu packages vis)
+ #:use-module (guix packages)
+ #:use-module (guix git-download)
+ #:use-module (guix build-system gnu)
+ #:use-module (guix licenses)
+ #:use-module (gnu packages ncurses)
+ #:use-module (gnu packages libtermkey)
+ #:use-module (gnu packages lua)
+ #:use-module (gnu packages lua-lpeg))
+
+(define-public vis
+ (package
+ (name "vis")
+ (version "0.2")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "git://github.com/martanne/vis.git")
+ (commit "v0.2")))
+ (sha256
+ (base32 "05pxycrhx297hdwkgky00g9s78dqcaam3lhp3ba903ma605dn34f"))))
+ (build-system gnu-build-system)
+ (arguments '(
+ #:make-flags '("CFLAGS=-pie")
+ #:tests? #f))
+ (inputs `(("lua", lua)))
+ (native-inputs `(("ncurses", ncurses)
+ ("libtermkey", libtermkey)
+ ("lua-lpeg", lua-lpeg)))
+ (synopsis "Vim-like text editor")
+ (description
+ "Vis aims to be a modern, legacy free, simple yet efficient vim-like text
+editor. It extends vim's modal editing with built-in support for multiple
+cursors/selecctions and combines it with sam's structural regular expression
+based command language.")
+ (home-page "https://github.com/martanne/vis")
+ (license isc)))
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-06 14:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-05 21:34 [PATCH] gnu: Add vis José Miguel Sánchez García
2016-12-06 14:30 ` Marius Bakke
-- strict thread matches above, loose matches on Subject: below --
2016-12-05 14:35 José Miguel Sánchez García
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).