From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: Add vis Date: Tue, 06 Dec 2016 15:30:15 +0100 Message-ID: <87lgvtm8p4.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <3eaab06915fb6ffe8860d63e27e66926@openmailbox.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47595) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cEGlD-0001Jy-EO for guix-devel@gnu.org; Tue, 06 Dec 2016 09:30:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cEGl8-0002QL-Qe for guix-devel@gnu.org; Tue, 06 Dec 2016 09:30:23 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:53036) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cEGl8-0002Pa-K5 for guix-devel@gnu.org; Tue, 06 Dec 2016 09:30:18 -0500 In-Reply-To: <3eaab06915fb6ffe8860d63e27e66926@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?utf-8?Q?Jos=C3=A9?= Miguel =?utf-8?Q?S=C3=A1nchez_Garc=C3=ADa?= , guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jos=C3=A9 Miguel S=C3=A1nchez Garc=C3=ADa writes: > Add vis (I hope it's finally correct!). Remember to add it after adding=20 > libtermkey and lua-lpeg. Thanks! I only have very minor comments on this one ;-) > --=20 > Jos=C3=A9 Miguel S=C3=A1nchez Garc=C3=ADa > From 9bdbc2064c0dc62e66291d18718932ca8b7f67f0 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Jos=3DC3=3DA9=3D20Miguel=3D20S=3DC3=3DA1nchez=3D20Garc= =3DC3=3DADa?=3D > > Date: Mon, 5 Dec 2016 15:17:40 +0100 > Subject: [PATCH] gnu: Add vis. > > --- > gnu/packages/vis.scm | 58 ++++++++++++++++++++++++++++++++++++++++++++++= ++++++ > 1 file changed, 58 insertions(+) > create mode 100644 gnu/packages/vis.scm Could you name this 'text-editors.scm'? Currently we have a file for each editor, but I think we should try to gather the ones without large ecosystems into a single file. Please also add it to 'local.mk'. See the commit log for examples, and how to format the commit message. > diff --git a/gnu/packages/vis.scm b/gnu/packages/vis.scm > new file mode 100644 > index 0000000..39150dc > --- /dev/null > +++ b/gnu/packages/vis.scm > @@ -0,0 +1,57 @@ > +;;; GNU Guix --- Functional package management for GNU > +;;; Copyright =C2=A9 2016 Jos=C3=A9 Miguel S=C3=A1nchez Garc=C3=ADa > +;;; > +;;; This file is part of GNU Guix. > +;;; > +;;; GNU Guix is free software; you can redistribute it and/or modify it > +;;; under the terms of the GNU General Public License as published by > +;;; the Free Software Foundation; either version 3 of the License, or (at > +;;; your option) any later version. > +;;; > +;;; GNU Guix is distributed in the hope that it will be useful, but > +;;; WITHOUT ANY WARRANTY; without even the implied warranty of > +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +;;; GNU General Public License for more details. > +;;; > +;;; You should have received a copy of the GNU General Public License > +;;; along with GNU Guix. If not, see . > + > +; TODO: Installation succeeds, but vis complains about not finding base1= 6-theme > + > +(define-module (gnu packages vis) > + #:use-module (guix packages) > + #:use-module (guix git-download) > + #:use-module (guix build-system gnu) > + #:use-module (guix licenses) > + #:use-module (gnu packages ncurses) > + #:use-module (gnu packages libtermkey) > + #:use-module (gnu packages lua) > + #:use-module (gnu packages lua-lpeg)) > + > +(define-public vis > + (package > + (name "vis") > + (version "0.2") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url (string-append "git://github.com/martanne/" > + name ".git")) > + (commit (string-append "v" version)))) Since it uses a tagged release, downloading the tarball from https://github.com/martanne/vis/releases is better. Git downloads use more bandwidth, and are more likely to run into firewall problems. > + (sha256 > + (base32 "05pxycrhx297hdwkgky00g9s78dqcaam3lhp3ba903ma605= dn34f")))) > + (build-system gnu-build-system) > + (arguments '( > + #:make-flags '("CFLAGS=3D-pie") > + #:tests? #f)) > + (inputs `(("lua", lua))) > + (native-inputs `(("ncurses", ncurses) > + ("libtermkey", libtermkey) > + ("lua-lpeg", lua-lpeg))) All of these should probably be 'inputs' instead of 'native-inputs'. > + (synopsis "Vim-like text editor") > + (description > + "Vis aims to be a modern, legacy free, simple yet efficient vim-li= ke text > +editor. It extends vim's modal editing with built-in support for multip= le > +cursors/selecctions and combines it with sam's structural regular expres= sion > +based command language.") > + (home-page "https://github.com/martanne/vis") > + (license isc))) The rest looks good. I think this series can be committed after the mentioned improvements. Thanks for your patience! :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlhGy3gACgkQoqBt8qM6 VPrKUAf/X9emqXezQJ8n5vI0NXlCrYNu5QtoTmN5nv8RuRaH3HVgBybmSmJsOZWR Fm0RiRtCmY+I2Z79grADZSBMtQy0/00LLUA7WRStl3vRjM/tXHsfk+OFVe5u9M9j cW1WUMdc+w202FEA7mZi96NxiKvxCBNTMmidLmahqMyrWsErxMZ/xUISj5/YoNAF MqJCLU7x5x78mwM0FGp1h8W2oLWiZEymOTfUXzo0ZKdbEW/cXUZ59a1Z6lKRfdeK b0wFOm8eBnBSchJx90mS1ZpgrDrE57h89uclJp7F+1IqEb2g+GNh+vZuM6LX5PNQ TaLB3d5EDOBlC1ItbobIN9WJ87K0rQ== =3KiR -----END PGP SIGNATURE----- --=-=-=--