From: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
To: Christopher Baines <mail@cbaines.net>
Cc: "Ludovic Courtès" <ludo@gnu.org>,
61894@debbugs.gnu.org, guix-maintainers@gnu.org,
guix-devel@gnu.org
Subject: Re: [bug#61894] [PATCH RFC] Team approval for patches
Date: Wed, 1 Mar 2023 18:59:19 +0100 [thread overview]
Message-ID: <20230301185919.56734797@tangletp> (raw)
In-Reply-To: <871qm8wf8e.fsf@cbaines.net>
[-- Attachment #1: Type: text/plain, Size: 1430 bytes --]
On Wed, 01 Mar 2023 17:15:26 +0000
Christopher Baines <mail@cbaines.net> wrote:
> I guess I'm still a team sceptic, I think the idea is interesting and
> I have added myself as a member of some teams. But the main impact on
> me so far is that I've just been getting some unwanted personal email,
> messages that previously wouldn't have landed in my inbox have been
> doing so.
>
> Regarding this change specifically though, I'm unclear how it would
> impact the things I push for others. I pushed some patches today,
> would this mean that I'd have to look at what team/teams are involved
> (according to /etc/teams.scm.in) for each commit/series, and then
> either continue if I'm a member of that team, or skip it if I'm not?
I'm on Chris' side. We need less burden to review/push, instead of more
formal rules/obligations.
Speaking about me, I'm in the Java team, where my knowledge is best, but
in the past I also "wildered" in the Python and Ruby areas. I think
I always tried to be cautious with my reviews though: If I saw it was
just a simple version update with no dependency changes, and it
builds/runs afterwards, I gave an OK and/or pushed it, although I'm not
the super-expert. If it was too hot for me, I left my fingers from it or
asked a known expert for help.
"Teams" are a nice hint (for example, adding a tag to the bug entry),
but I wouldn't make it too formal.
Björn
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2023-03-01 18:00 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 16:13 [bug#61894] [PATCH RFC] Team approval for patches Ludovic Courtès
2023-03-01 17:15 ` Christopher Baines
2023-03-01 17:59 ` Björn Höfling [this message]
2023-03-01 18:17 ` Christopher Baines
2023-03-01 19:21 ` Felix Lechner via Guix-patches via
2023-03-01 22:45 ` Ludovic Courtès
2023-03-02 11:04 ` Andreas Enge
2023-03-02 13:57 ` bug#61894: " bokr
2023-03-03 1:08 ` 宋文武
2023-03-07 1:53 ` [bug#61894] " 宋文武 via Guix-patches via
2023-03-07 10:36 ` bug#61894: " Andreas Enge
2023-03-07 12:22 ` Simon Tournier
2023-03-07 18:29 ` [bug#61894] " Maxim Cournoyer
2023-03-07 22:40 ` Leo Famulari
2023-03-08 18:58 ` bug#61894: " Maxim Cournoyer
2023-03-09 8:48 ` [bug#61894] " Simon Tournier
2023-03-08 9:12 ` bug#61894: " Efraim Flashner
2023-03-08 17:05 ` Maxim Cournoyer
2023-03-08 23:38 ` Vagrant Cascadian
2023-03-09 5:12 ` Maxim Cournoyer
2023-03-09 9:46 ` Simon Tournier
2023-03-10 4:36 ` Maxim Cournoyer
2023-03-10 17:22 ` Ludovic Courtès
2023-03-10 18:22 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-03-12 2:33 ` Maxim Cournoyer
2023-03-12 11:14 ` Simon Tournier
2023-03-12 3:26 ` Maxim Cournoyer
2023-03-12 11:52 ` Andreas Enge
2023-03-13 0:08 ` Maxim Cournoyer
2023-03-12 12:25 ` Simon Tournier
2023-03-15 16:08 ` Ludovic Courtès
2023-03-17 15:46 ` [bug#61894] " Maxim Cournoyer
2023-03-10 14:19 ` bug#61894: " Andreas Enge
2023-03-10 17:33 ` Simon Tournier
2023-03-10 23:19 ` Andreas Enge
2023-03-11 13:20 ` Simon Tournier
2023-03-07 15:21 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-03-06 15:48 ` [bug#61894] " Maxim Cournoyer
2023-03-06 21:42 ` Ludovic Courtès
2023-06-02 13:50 ` bug#61894: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230301185919.56734797@tangletp \
--to=bjoern.hoefling@bjoernhoefling.de \
--cc=61894@debbugs.gnu.org \
--cc=guix-devel@gnu.org \
--cc=guix-maintainers@gnu.org \
--cc=ludo@gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).