[PATCH v2 0/5] Add emacs-mu4e-alert.

[PATCH v2 0/5] Add emacs-mu4e-alert.

[Mathieu Othacehe]

The point of this serie is to add mu4e-alert and it's dependencies.
I used the importer for every package and rewrote incorrect descriptions.

Changelog:
*v2: Replace melpa repositories by github repositories.

Mathieu Othacehe (5):
  gnu: Add emacs-ht.
  gnu: Add emacs-log4e.
  gnu: Add emacs-gntp.
  gnu: Add emacs-alert.
  gnu: Add emacs-mu4e-alert.

 gnu/packages/emacs.scm | 130 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 130 insertions(+)

-- 
2.11.0

[PATCH v2 1/5] gnu: Add emacs-ht.

[Mathieu Othacehe]

* gnu/packages/emacs.scm (emacs-ht): New variable.
---
 gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index d3e64c04f..6c6d4db2f 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -3645,3 +3645,28 @@ Streams are implemented as delayed evaluation of cons cells.")
       (description "This package provides expression based interactive search
 procedures for emacs-lisp-mode.")
       (license license:gpl3+))))
+
+(define-public emacs-ht
+  (package
+  (name "emacs-ht")
+  (version "2.1")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append
+             "https://github.com/Wilfred/ht.el/archive/"
+             version
+             ".tar.gz"))
+      (sha256
+        (base32
+          "1lpba36kzxcc966fvsbrfpy8ah9gnvay0yk26gbyjil0rggrbqzj"))))
+  (build-system emacs-build-system)
+  (propagated-inputs `(("emacs-dash" ,emacs-dash)))
+  (home-page "https://github.com/Wilfred/ht.el")
+  (synopsis
+    "Hash table library for Emacs")
+  (description
+    "This package simplifies the use of hash tables in elisp. It also
+provides functions to convert hash tables from and to alists and plists.")
+  (license license:gpl3+)))
+
-- 
2.11.0

[PATCH v2 2/5] gnu: Add emacs-log4e.

[Mathieu Othacehe]

* gnu/packages/emacs.scm (emacs-log4e): New variable.
---
 gnu/packages/emacs.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 6c6d4db2f..35294a9bc 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -3670,3 +3670,32 @@ procedures for emacs-lisp-mode.")
 provides functions to convert hash tables from and to alists and plists.")
   (license license:gpl3+)))
 
+(define-public emacs-log4e
+  (package
+    (name "emacs-log4e")
+    (version "0.3.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/aki2o/log4e/archive/"
+             "v" version ".tar.gz"))
+       (sha256
+        (base32
+         "0nbdpbw353snda3v19l9hsm6gimppwnpxj18amm350bm81lyim2g"))))
+    (build-system emacs-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after
+             'unpack 'remove-tests
+           ;; Guile complains of null characters in some strings of
+           ;; test files. Remove the test folder fixes it.
+           (lambda _
+             (delete-file-recursively "test"))))))
+    (home-page "https://github.com/aki2o/log4e")
+    (synopsis "Logging framework for elisp.")
+    (description
+     "This package provides a logging framework for elisp. It allows to deal with
+multiple log levels.")
+    (license license:gpl3+)))
-- 
2.11.0

[PATCH v2 3/5] gnu: Add emacs-gntp.

[Mathieu Othacehe]

* gnu/packages/emacs.scm (emacs-gntp): New variable.
---
 gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 35294a9bc..aaa67615f 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -3699,3 +3699,27 @@ provides functions to convert hash tables from and to alists and plists.")
      "This package provides a logging framework for elisp. It allows to deal with
 multiple log levels.")
     (license license:gpl3+)))
+
+(define-public emacs-gntp
+  (package
+    (name "emacs-gntp")
+    (version "0.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/tekai/gntp.el/archive/"
+             "v" version ".tar.gz"))
+       (sha256
+        (base32
+         "16c1dfkia9yhl206bdhjr3b8kfvqcqr38jl5lq8qsyrrzsnmghny"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/tekai/gntp.el")
+    (synopsis
+     "Growl Notification Protocol for Emacs")
+    (description
+     "This package implements the Growl Notification Protocol GNTP
+described at http://www.growlforwindows.com/gfw/help/gntp.aspx
+It is incomplete as it only lets you send but not receive
+notifications.")
+    (license license:gpl3+)))
-- 
2.11.0

[PATCH v2 4/5] gnu: Add emacs-alert.

[Mathieu Othacehe]

* gnu/packages/emacs.scm (emacs-alert): New variable.
---
 gnu/packages/emacs.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index aaa67615f..81cefa541 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -3723,3 +3723,29 @@ described at http://www.growlforwindows.com/gfw/help/gntp.aspx
 It is incomplete as it only lets you send but not receive
 notifications.")
     (license license:gpl3+)))
+
+(define-public emacs-alert
+  (package
+    (name "emacs-alert")
+    (version "1.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/jwiegley/alert/archive/"
+             "v" version ".tar.gz"))
+       (sha256
+        (base32
+         "1693kck3k2iz5zhpmxwqyafxm68hr6gzs60lkxd3j1wlp2c9fwyr"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-gntp" ,emacs-gntp)
+       ("emacs-log4e" ,emacs-log4e)))
+    (home-page "https://github.com/jwiegley/alert")
+    (synopsis
+     "Growl-style notification system for Emacs")
+    (description
+     "Alert is a Growl-workalike for Emacs which uses a common notification
+interface and multiple, selectable \"styles\", whose use is fully
+customizable by the user.")
+    (license license:gpl3+)))
-- 
2.11.0

[PATCH v2 5/5] gnu: Add emacs-mu4e-alert.

[Mathieu Othacehe]

* gnu/packages/emacs.scm (emacs-mu4e-alert): New variable.
---
 gnu/packages/emacs.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 81cefa541..3f93b867e 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -3749,3 +3749,29 @@ notifications.")
 interface and multiple, selectable \"styles\", whose use is fully
 customizable by the user.")
     (license license:gpl3+)))
+
+(define-public emacs-mu4e-alert
+  (package
+    (name "emacs-mu4e-alert")
+    (version "0.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/iqbalansari/mu4e-alert/archive/"
+             "v" version ".tar.gz"))
+       (sha256
+        (base32
+         "1m63vyb2v5r9swmqv56q80jca8172nk5vaxl7bcm5zbfs8zsvr4b"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-alert" ,emacs-alert)
+       ("emacs-s" ,emacs-s)
+       ("emacs-ht" ,emacs-ht)))
+    (home-page
+     "https://github.com/iqbalansari/mu4e-alert")
+    (synopsis "Desktop notification for mu4e")
+    (description
+     "This package provides desktop notifications for mu4e, additionally it can
+display the number of unread emails in the modeline.")
+    (license license:gpl3+)))
-- 
2.11.0

Re: [PATCH v2 0/5] Add emacs-mu4e-alert.

[Alex Kost]

Mathieu Othacehe (2017-01-27 14:43 +0100) wrote:

> The point of this serie is to add mu4e-alert and it's dependencies.
> I used the importer for every package and rewrote incorrect descriptions.
>
> Changelog:
> *v2: Replace melpa repositories by github repositories.
>
> Mathieu Othacehe (5):
>   gnu: Add emacs-ht.
>   gnu: Add emacs-log4e.
>   gnu: Add emacs-gntp.
>   gnu: Add emacs-alert.
>   gnu: Add emacs-mu4e-alert.
>
>  gnu/packages/emacs.scm | 130 +++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 130 insertions(+)

Thanks, I have added a copyright line for you in the beginning of
"gnu/packages/emacs.scm" and committed these patches.  I have 2 major
notes:

1) Please check the licenses, as they are not necessarily gpl3+.

2) Make sure to run "guix lint" next time ;-)

As there were several warnings reported by:

  guix lint emacs-mu4e-alert emacs-alert emacs-gntp emacs-log4e emacs-ht

particularly, double spaces between sentences, synopsis shouldn't end
with a space, and about source file names.

-- 
Alex

Re: [PATCH v2 4/5] gnu: Add emacs-alert.

[Alex Kost]

Mathieu Othacehe (2017-01-27 14:43 +0100) wrote:

> * gnu/packages/emacs.scm (emacs-alert): New variable.
> ---
>  gnu/packages/emacs.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index aaa67615f..81cefa541 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -3723,3 +3723,29 @@ described at http://www.growlforwindows.com/gfw/help/gntp.aspx
>  It is incomplete as it only lets you send but not receive
>  notifications.")
>      (license license:gpl3+)))
> +
> +(define-public emacs-alert
> +  (package
> +    (name "emacs-alert")
> +    (version "1.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/jwiegley/alert/archive/"
> +             "v" version ".tar.gz"))

Also there should be ‘file-name’ field here (and in the other packages).
Otherwise this source would have the following store file name:
"/gnu/store/…-v1.2.tar.gz" while we want it to be
"/gnu/store/…-emacs-alert-1.2.tar.gz".

> +       (sha256
> +        (base32
> +         "1693kck3k2iz5zhpmxwqyafxm68hr6gzs60lkxd3j1wlp2c9fwyr"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("emacs-gntp" ,emacs-gntp)
> +       ("emacs-log4e" ,emacs-log4e)))
> +    (home-page "https://github.com/jwiegley/alert")
> +    (synopsis
> +     "Growl-style notification system for Emacs")
> +    (description
> +     "Alert is a Growl-workalike for Emacs which uses a common notification
> +interface and multiple, selectable \"styles\", whose use is fully
> +customizable by the user.")
> +    (license license:gpl3+)))

This should be 'gpl2+' as you can see in the header of
<https://github.com/jwiegley/alert/blob/master/alert.el>

-- 
Alex

Re: [PATCH v2 3/5] gnu: Add emacs-gntp.

[Alex Kost]

Mathieu Othacehe (2017-01-27 14:43 +0100) wrote:

> * gnu/packages/emacs.scm (emacs-gntp): New variable.
> ---
>  gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 35294a9bc..aaa67615f 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -3699,3 +3699,27 @@ provides functions to convert hash tables from and to alists and plists.")
>       "This package provides a logging framework for elisp. It allows to deal with
>  multiple log levels.")
>      (license license:gpl3+)))
> +
> +(define-public emacs-gntp
> +  (package
> +    (name "emacs-gntp")
> +    (version "0.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/tekai/gntp.el/archive/"
> +             "v" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "16c1dfkia9yhl206bdhjr3b8kfvqcqr38jl5lq8qsyrrzsnmghny"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/tekai/gntp.el")
> +    (synopsis
> +     "Growl Notification Protocol for Emacs")
> +    (description
> +     "This package implements the Growl Notification Protocol GNTP
> +described at http://www.growlforwindows.com/gfw/help/gntp.aspx

I made it @uref{http://www.growlforwindows.com/gfw/help/gntp.aspx} to
make it displayed properly by "guix package -s emacs-gntp" and in other
places.

> +It is incomplete as it only lets you send but not receive
> +notifications.")
> +    (license license:gpl3+)))

This should be 'bsd-3'.  Compare:

  https://github.com/tekai/gntp.el/blob/master/gntp.el

and

  http://directory.fsf.org/wiki/License:BSD_3Clause

-- 
Alex