From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH v2 0/5] Add emacs-mu4e-alert. Date: Sat, 28 Jan 2017 12:42:49 +0300 Message-ID: <874m0j34h2.fsf@gmail.com> References: <20170127134348.29162-1-m.othacehe@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47239) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXPX9-0004gK-37 for guix-devel@gnu.org; Sat, 28 Jan 2017 04:42:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXPX4-0006Yg-5D for guix-devel@gnu.org; Sat, 28 Jan 2017 04:42:59 -0500 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:34976) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXPX3-0006Vi-V7 for guix-devel@gnu.org; Sat, 28 Jan 2017 04:42:54 -0500 Received: by mail-lf0-x242.google.com with SMTP id v186so27681559lfa.2 for ; Sat, 28 Jan 2017 01:42:52 -0800 (PST) In-Reply-To: <20170127134348.29162-1-m.othacehe@gmail.com> (Mathieu Othacehe's message of "Fri, 27 Jan 2017 14:43:43 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mathieu Othacehe Cc: guix-devel@gnu.org Mathieu Othacehe (2017-01-27 14:43 +0100) wrote: > The point of this serie is to add mu4e-alert and it's dependencies. > I used the importer for every package and rewrote incorrect descriptions. > > Changelog: > *v2: Replace melpa repositories by github repositories. > > Mathieu Othacehe (5): > gnu: Add emacs-ht. > gnu: Add emacs-log4e. > gnu: Add emacs-gntp. > gnu: Add emacs-alert. > gnu: Add emacs-mu4e-alert. > > gnu/packages/emacs.scm | 130 +++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 130 insertions(+) Thanks, I have added a copyright line for you in the beginning of "gnu/packages/emacs.scm" and committed these patches. I have 2 major notes: 1) Please check the licenses, as they are not necessarily gpl3+. 2) Make sure to run "guix lint" next time ;-) As there were several warnings reported by: guix lint emacs-mu4e-alert emacs-alert emacs-gntp emacs-log4e emacs-ht particularly, double spaces between sentences, synopsis shouldn't end with a space, and about source file names. -- Alex