From mboxrd@z Thu Jan  1 00:00:00 1970
From: John Darrington <john@darrington.wattle.id.au>
Subject: Re: [PATCH] gnu: file-system-shepherd-service: Use mount-file-system.
Date: Fri, 2 Dec 2016 12:32:56 +0100
Message-ID: <20161202113256.GA30350@jocasta.intra>
References: <1480444419-32288-1-git-send-email-jmd@gnu.org>
	<87k2blku5w.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="huq684BweRXVnRxX"
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42889)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <john@darrington.wattle.id.au>) id 1cCm5a-00051B-8A
	for guix-devel@gnu.org; Fri, 02 Dec 2016 06:33:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <john@darrington.wattle.id.au>) id 1cCm5Z-0002kO-Ci
	for guix-devel@gnu.org; Fri, 02 Dec 2016 06:33:14 -0500
Content-Disposition: inline
In-Reply-To: <87k2blku5w.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ludovic Court??s <ludo@gnu.org>
Cc: guix-devel@gnu.org, John Darrington <jmd@gnu.org>


--huq684BweRXVnRxX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 30, 2016 at 01:51:23PM +0100, Ludovic Court??s wrote:
     John Darrington <jmd@gnu.org> skribis:
    =20
     > * gnu/services/base.scm (file-system-shepherd-service): Use mount-fi=
le-system
     > instead of manually mounting the file system.
    =20
     [...]
    =20
     > +		       #$(if create?
     > +			     #~(mkdir-p #$target)
     > +			     #~#t)
    =20
     #~#t is equivalent to #t.
    =20
     > +		       (mount-file-system
     > +			`(#$device #$title #$target #$type #$flags #$options
     > +				   #$check?) #:root "/")
     >                         #t))
    =20
     #t must be align with the parent of ???(mount-file-system???.
    =20
     If you confirmed that at least ???make check-system TESTS=3Dbasic??? p=
asses,
     fine with me.
    =20

Perhaps somebody who already has a copy of qemu in their store could check =
that
for me?

Currently I cannot run any system tests because of bug #25036

J'



--=20
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3=20
fingerprint =3D 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


--huq684BweRXVnRxX
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlhBW+gACgkQimdxnC3oJ7OrfACdFdkW2WyPmPupswwwEM8OcJtJ
bfoAnRVtpFpV9U7RfvRyHmA52oNu9j/H
=xk3W
-----END PGP SIGNATURE-----

--huq684BweRXVnRxX--