unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Mathieu Lirzin <mthl@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 3/7] gnu: efl: Update to 1.15.1.
Date: Thu, 10 Sep 2015 20:52:59 +0300	[thread overview]
Message-ID: <20150910205259.615562b2@debian-netbook> (raw)
In-Reply-To: <87r3m6p5x1.fsf@openmailbox.org>


[-- Attachment #1.1: Type: text/plain, Size: 2594 bytes --]

On Thu, 10 Sep 2015 18:58:50 +0200
Mathieu Lirzin <mthl@openmailbox.org> wrote:

> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> > * gnu/packages/enlightenment.scm (efl): Update to 1.15.1.
> >   Align package to 80 width columns.
>     ^^^
>     This is not necessary to notify indentation changes in commit
>     messages.
> 
> > ---
> >  gnu/packages/enlightenment.scm | 17 +++++++++--------
> >  1 file changed, 9 insertions(+), 8 deletions(-)
> >
> > diff --git a/gnu/packages/enlightenment.scm
> > b/gnu/packages/enlightenment.scm index 2470d1e..6b1257a 100644
> > --- a/gnu/packages/enlightenment.scm
> > +++ b/gnu/packages/enlightenment.scm
> > @@ -51,14 +51,14 @@
> >  (define-public efl
> >    (package
> >      (name "efl")
> > -    (version "1.14.2")
> > +    (version "1.15.1")
> >      (source (origin
> > -              (method url-fetch)
> > -              (uri (string-append
> > -
> > "https://download.enlightenment.org/rel/libs/efl/efl-"
> > -                    version ".tar.xz"))
> > -              (sha256
> > -               (base32
> > "0kg51v63ljq1z4dj65aiyxaqhq54gkl4hx53ifwbci6ihammandr"))))
> > +             (method url-fetch)
> > +             (uri (string-append
> > +                   "https://download.enlightenment.org/rel/libs/efl/efl-"
> > +                   version ".tar.xz"))
> > +             (sha256
> > +              (base32
> > "1n2l2n09lys5dph9lrnsv5z3qbgzp7bi0vidal2fvy18hflbbvsn")))) (build-system
> > gnu-build-system) (native-inputs
> >       `(("pkg-config" ,pkg-config)))
> > @@ -127,7 +127,8 @@
> >  for Enlightenment.  Libraries covers data serialization, wide support for
> >  graphics rendering, UI layout and themes, interaction with OS, access to
> >  removable devices or support for multimedia.")
> > -    (license (list license:bsd-2 license:lgpl2.1 license:zlib)))) ;
> > different parts under different licenses
> > +    (license (list license:bsd-2 license:lgpl2.1 license:zlib)))) 
> > +				;;; different parts under different
> > licenses
> 
> There is a trailing white space here. ";;;" is not adapted for this type of
> comment I would suggest this
> 
>     ;; Different parts are under different licenses.
>     (license (list license:bsd-2 license:lgpl2.1 license:zlib))))
> 
> Can you send the updated patch?
> 
> --
> Mathieu Lirzin



-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0003-gnu-efl-Update-to-1.15.1.patch --]
[-- Type: text/x-patch, Size: 1914 bytes --]

From ebe9bd82af5b8d28ab69958f1caea89078007496 Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Thu, 10 Sep 2015 16:23:37 +0300
Subject: [PATCH 3/7] gnu: efl: Update to 1.15.1.

* gnu/packages/enlightenment.scm (efl): Update to 1.15.1.
---
 gnu/packages/enlightenment.scm | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/enlightenment.scm b/gnu/packages/enlightenment.scm
index 5d05254..bebd963 100644
--- a/gnu/packages/enlightenment.scm
+++ b/gnu/packages/enlightenment.scm
@@ -51,14 +51,14 @@
 (define-public efl
   (package
     (name "efl")
-    (version "1.14.2")
+    (version "1.15.1")
     (source (origin
-              (method url-fetch)
-              (uri (string-append
-                    "https://download.enlightenment.org/rel/libs/efl/efl-"
-                    version ".tar.xz"))
-              (sha256
-               (base32 "0kg51v63ljq1z4dj65aiyxaqhq54gkl4hx53ifwbci6ihammandr"))))
+             (method url-fetch)
+             (uri (string-append
+                   "https://download.enlightenment.org/rel/libs/efl/efl-"
+                   version ".tar.xz"))
+             (sha256
+              (base32 "1n2l2n09lys5dph9lrnsv5z3qbgzp7bi0vidal2fvy18hflbbvsn"))))
     (build-system gnu-build-system)
     (native-inputs
      `(("pkg-config" ,pkg-config)))
@@ -127,7 +127,8 @@
 for Enlightenment.  Libraries covers data serialization, wide support for
 graphics rendering, UI layout and themes, interaction with OS, access to
 removable devices or support for multimedia.")
-    (license (list license:bsd-2 license:lgpl2.1 license:zlib)))) ; different parts under different licenses
+    ;; Different parts are under different licenses.
+    (license (list license:bsd-2 license:lgpl2.1 license:zlib)))) 
 
 (define-public elementary
   (package
-- 
2.5.1


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-09-10 17:56 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-10 13:47 [PATCH 0/7] Misc updates Efraim Flashner
2015-09-10 13:47 ` [PATCH 1/7] gnu: ncdu: Update to 1.11 Efraim Flashner
2015-09-10 16:26   ` Mathieu Lirzin
2015-09-10 17:53     ` Efraim Flashner
2015-09-10 19:18     ` Ludovic Courtès
2015-09-10 19:23       ` Efraim Flashner
2015-09-10 13:47 ` [PATCH 2/7] gnu: terminology: Update to 0.9.0 Efraim Flashner
2015-09-10 16:57   ` Mathieu Lirzin
2015-09-10 17:53     ` Efraim Flashner
2015-09-10 13:47 ` [PATCH 3/7] gnu: efl: Update to 1.15.1 Efraim Flashner
2015-09-10 16:58   ` Mathieu Lirzin
2015-09-10 17:52     ` Efraim Flashner [this message]
2015-09-10 13:47 ` [PATCH 4/7] gnu: elementary: " Efraim Flashner
2015-09-10 17:09   ` Mathieu Lirzin
2015-09-10 17:52     ` Efraim Flashner
2015-09-10 13:47 ` [PATCH 5/7] gnu: evas-generic-loaders: Update to 1.15.0 Efraim Flashner
2015-09-10 17:19   ` Mathieu Lirzin
2015-09-10 13:47 ` [PATCH 6/7] gnu: emotion-generic-players: " Efraim Flashner
2015-09-10 17:34   ` Mathieu Lirzin
2015-09-10 17:52     ` Efraim Flashner
2015-09-10 13:47 ` [PATCH 7/7] gnu: enlightenment: Update to 0.19.9 Efraim Flashner
2015-09-10 17:42   ` Mathieu Lirzin
2015-09-10 17:51     ` Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150910205259.615562b2@debian-netbook \
    --to=efraim@flashner.co.il \
    --cc=guix-devel@gnu.org \
    --cc=mthl@openmailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).