From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= Subject: Re: [PATCH] gnu: sdcv: Add new variable. Date: Wed, 18 Mar 2015 13:25:19 +0100 Message-ID: <20150318122519.GB525@venom.suse.cz> References: <1426497533-7895-1-git-send-email-sleep_walker@gnu.org> <874mpilmwa.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5/uDoXvLw7AC5HRs" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYD2L-0004G5-AA for guix-devel@gnu.org; Wed, 18 Mar 2015 08:25:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYD2H-0007Pi-6t for guix-devel@gnu.org; Wed, 18 Mar 2015 08:25:25 -0400 Received: from cantor2.suse.de ([195.135.220.15]:46310 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYD2G-0007PO-W6 for guix-devel@gnu.org; Wed, 18 Mar 2015 08:25:21 -0400 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id B0A99ABF1 for ; Wed, 18 Mar 2015 12:25:19 +0000 (UTC) Content-Disposition: inline In-Reply-To: <874mpilmwa.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: guix-devel@gnu.org --5/uDoXvLw7AC5HRs Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 18, 2015 at 09:39:49AM +0100, Ludovic Court=C3=A8s wrote: >Tom=C3=A1=C5=A1 =C4=8Cech skribis: > >> * gnu/packages/dictionaries.scm (sdcv): New variable. > >You pushed it already but I have some comments anyway: Oh, I took that there are no objections already. Sorry about that. > >> +(define-public sdcv >> + (package >> + (name "sdcv") >> + (version "0.5.0-beta4") > >The policy is to provide only stable versions, unless there=E2=80=99s a ve= ry >good reason to do otherwise. Could we use the previous version until >0.5.0 is out? Previous version of this tool is 0.4.2, which is 8 years old, it won't work= with recent compilers (it's their statement, not my experiment though), co= uld suffer with allignment issues on more exotic architectures (ARM among t= hem). I can add comment with the reasoning. >> + (synopsis "Command line variant of StarDict") > >Could you change it to be self-contained=E2=80=93i.e., without referring to >StarDict (which I don=E2=80=99t know, and perhaps is not very well known.) sdcv stands for - StarDict Command line Variant This is where I took the synopsis from. It's hard to believe that you have never heard of StarDict. I'm not aware of any offline sotfware dictionary software which does not support StarDict dictionary format and doesn't state it's relation to stardict - be it GoldenDict, QStardict or this sdcv. Is "Command line offline dictionary" satisfactory? >> + (description >> + "Sdcv is command line dictionary utility, which supports StarDict = dictinary >> +format.") > >Typo: =E2=80=9Cdictionary=E2=80=9D. Thanks. > >Please expound, explaining what it does concretely. Perhaps get >inspiration from the README or web page. I'm afraid that their web or README is useless for this case. Is this satisfactory?: "Sdcv is command line dictionary utility with support of StarDict dictionary format. For word in one language it can find translation in all installed dictionaries at the same time and without specifying original language. With proper dictionary it can also work as encyclopedic dictionary." --5/uDoXvLw7AC5HRs Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlUJbq0ACgkQ37XrCapiVCMyRQCfRf8hwiWgsftdq7mocN6iVR6b 1wIAoL2JKKeKthI3pjFgIwDIoYHgIQna =aIu6 -----END PGP SIGNATURE----- --5/uDoXvLw7AC5HRs--