From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= Subject: Re: [PATCH] gnu: agg: New variable. Date: Tue, 17 Mar 2015 11:44:45 +0100 Message-ID: <20150317104445.GB31584@crashnator.suse.cz> References: <1426497311-25364-1-git-send-email-sleep_walker@gnu.org> <87pp88ouov.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZfOjI3PrQbgiZnxM" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXozT-000584-Qq for guix-devel@gnu.org; Tue, 17 Mar 2015 06:44:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXozO-00029J-Ss for guix-devel@gnu.org; Tue, 17 Mar 2015 06:44:51 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34551 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXozO-00029B-Me for guix-devel@gnu.org; Tue, 17 Mar 2015 06:44:46 -0400 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 6F973AAC8 for ; Tue, 17 Mar 2015 10:44:45 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87pp88ouov.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: guix-devel@gnu.org --ZfOjI3PrQbgiZnxM Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Thanks for review, it seems that I'm getting too chaotic as I work on many packages simultaneously. Sorry about that. On Tue, Mar 17, 2015 at 10:10:56AM +0100, Ludovic Court=C3=A8s wrote: >Tom=C3=A1=C5=A1 =C4=8Cech skribis: > >> * gnu/packages/graphics.scm (agg): New variable. > >Please adjust the commit=E2=80=99s subject line as Andreas suggested. Fixed. > >> + (uri (string-append "http://www.antigrain.com/agg-" >> + version ".tar.gz")) >> + (sha256 (base32 >> + "07wii4i824vy9qsvjsgqxppgqmfdxq0xa87i5yk53fijria= dq7mb")) > >Maybe put =E2=80=98base32=E2=80=99 on the next line, as is done in the res= t of this file >an elsewhere. Fixed. > >> + (patches (list (search-patch "am_c_prototype.patch") >> + (search-patch >> + "antigrain-geometry-no_rpath.patch"))))) > >Please add these two patches to the patch, and list them in >gnu-system.am. This is critical miss. > >> + (alist-cons-after >> + 'unpack 'autoreconf >> + (lambda _ >> + ;; let's call configure from configure phase and not now >> + (substitute* "autogen.sh" (("./configure") "# ./configure")) >> + (zero? (system* "sh" "autogen.sh"))) > >So the tarball they provide is not generated from =E2=80=98make dist=E2=80= =99? Bah. No, really, I'm glad I made it compile. >> + (synopsis "A high quality rendering engine for C++") > >=E2=80=9CHigh-quality 2D graphics rendering engine for C++=E2=80=9D The best text to be placed there is already taken by authors and wikipedia people. It's hard to divert :b Rest fixed as well. Thanks for the review. S_W --ZfOjI3PrQbgiZnxM Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlUIBZsACgkQ37XrCapiVCNOSgCgus+BMl4bDg+IfaTfiKzIn9Cq ZwMAnjc71ixHyxlWg0UEB4FHgFFbKR4i =Jlw7 -----END PGP SIGNATURE----- --ZfOjI3PrQbgiZnxM--