From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Sassmannshausen Subject: Re: dmd: Unload one or all services at runtime. Date: Wed, 19 Mar 2014 15:25:28 +0100 Message-ID: <1395239129-10136-1-git-send-email-alex.sassmannshausen@gmail.com> References: <87eh27gvd1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQHRJ-0002LF-Mt for guix-devel@gnu.org; Wed, 19 Mar 2014 10:26:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQHRA-0006k6-Bw for guix-devel@gnu.org; Wed, 19 Mar 2014 10:25:53 -0400 Received: from mail-ee0-x22b.google.com ([2a00:1450:4013:c00::22b]:40929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQHRA-0006je-4t for guix-devel@gnu.org; Wed, 19 Mar 2014 10:25:44 -0400 Received: by mail-ee0-f43.google.com with SMTP id e53so6677268eek.2 for ; Wed, 19 Mar 2014 07:25:43 -0700 (PDT) Received: from serenity.home ([91.177.0.8]) by mx.google.com with ESMTPSA id l42sm54982558eew.19.2014.03.19.07.25.40 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 19 Mar 2014 07:25:41 -0700 (PDT) In-Reply-To: <87eh27gvd1.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: guix-devel@gnu.org Hello, Please find an updated second patch which should arrive shortly. Ludovic Courtès writes: > Alex Sassmannshausen skribis: > >> * modules/dmd/service.scm (runtime-load): New procedure. >> (dmd-service): Re-factor 'load', add new action: 'reload'. >> * dmd.texi (The 'dmd' and 'unknown' services): Document 'reload'. >> * tests/basic.sh: Add 'reload' test. > > Again I would call everything ‘reload’, for instance. ‘runtime-load’ > sounds like a pleonasm to me. > > WDYT? The procedure in question is now actually used by the 'load' and 'reload' actions, so simply calling it 'reload' would not be correct. I can see it being a pleonasm, so I've renamed the procedure 'load-config'. To be clear, the new action itself IS called 'reload' (so you would use it by 'deco reload dmd $file_name'). I've implemented your other suggestions, the tests pass. Let me know if you have any other comments. Cheers, Alex