bug#28644: Pulseview with modular qt

bug#28644: Pulseview with modular qt

[Theodoros Foradis]

Hello,

commit b1e4c0fa514d94df9735685a037693e5c6efa5b2 changed the pulseview
package to build with modular qt.

Now, some icons do not appear at all in the gui. I had tried building
with modular qt before submitting the qt package, and this is why I
opted for "qt" as an input.

The two inputs from modular qt, namely qtbase and qtsvg, seem to be the
correct ones, seeing that other distibutions (e.g. Parabola/Arch) use
the same dependencies.

My guess (not being familiar with qt), is that somehow, having the two
inputs in different prefixes, causes the problem with the package's
build system. I gave a look at the cmake files, but couldn't locate the
issue/fix.

Any ideas?
-- 
Theodoros Foradis

bug#28644: Pulseview with modular qt

[Ricardo Wurmus]

Theodoros Foradis <theodoros@foradis.org> writes:

> My guess (not being familiar with qt), is that somehow, having the two
> inputs in different prefixes, causes the problem with the package's
> build system. I gave a look at the cmake files, but couldn't locate the
> issue/fix.

You could try to validate your hypothesis by using a union package such
as it was done for python-pyqt+qscintilla.  That package would have only
one prefix.  If that really does make a difference we might be able to
investigate the issue further.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

bug#28644: Pulseview with modular qt

[Theodoros Foradis]

Ricardo Wurmus writes:

> Theodoros Foradis <theodoros@foradis.org> writes:
>
>> My guess (not being familiar with qt), is that somehow, having the two
>> inputs in different prefixes, causes the problem with the package's
>> build system. I gave a look at the cmake files, but couldn't locate the
>> issue/fix.
>
> You could try to validate your hypothesis by using a union package such
> as it was done for python-pyqt+qscintilla.  That package would have only
> one prefix.  If that really does make a difference we might be able to
> investigate the issue further.

Thanks for the union package recommendation. I tried that, but
unfortunately it does not fix the icon issue.

I see that there is a wip-qt-paths branch in our git repo. I don't
really know its purpose, maybe it's worth to try rebasing it on
master and build pulseview with that?

Any other ideas?

-- 
Theodoros Foradis

bug#28644: Pulseview with modular qt

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]

Theodoros Foradis <theodoros@foradis.org> writes:

> Ricardo Wurmus writes:
>
>> Theodoros Foradis <theodoros@foradis.org> writes:
>>
>>> My guess (not being familiar with qt), is that somehow, having the two
>>> inputs in different prefixes, causes the problem with the package's
>>> build system. I gave a look at the cmake files, but couldn't locate the
>>> issue/fix.
>>
>> You could try to validate your hypothesis by using a union package such
>> as it was done for python-pyqt+qscintilla.  That package would have only
>> one prefix.  If that really does make a difference we might be able to
>> investigate the issue further.
>
> Thanks for the union package recommendation. I tried that, but
> unfortunately it does not fix the icon issue.
>
> I see that there is a wip-qt-paths branch in our git repo. I don't
> really know its purpose, maybe it's worth to try rebasing it on
> master and build pulseview with that?

Hello, and sorry for breaking this package!  I don't know what the
wip-qt-paths branch is for, but it looks like a good place to fix the
problem, and I'm sure Hartmut and 宋文武 would appreciate more testers.

Can you try rebasing it and see if it makes a difference?  I will try to
investigate more towards the weekend as I really want to get rid of the
monolithic Qt :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#28644: Missing icons in pulseview

[phodina via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

Hi,

recently I used Pulseview to debug eMMC issues.

I was also surprised why they are some icons and others are missing.

Based on the code some are implemented as png and some as svg.

I tried to add the qtsvg-5 but it did not work and made the resulting derivation larger.

Therefore there are 2 possibilites:

- Add support for SVG by adding qtsvg-5 and any additional packages [1]
This would be preferable as the images are displayed in the time series and the bitmaps will look ugly.

2. Convert all into pngs
This will save size but will require a big patch (which will be mostly binary)
What do you think?

[1] https://sigrok.org/bugzilla/show_bug.cgi?id=239

----
Petr

[-- Attachment #2: Type: text/html, Size: 1250 bytes --]

bug#28644: Pulseview with modular qt

[Maxim Cournoyer]

Hi,

phodina <phodina@protonmail.com> writes:

> Hi,
>
> recently I used Pulseview to debug eMMC issues.
>
> I was also surprised why they are some icons and others are missing.
>
> Based on the code some are implemented as png and some as svg.
>
> I tried to add the qtsvg-5 but it did not work and made the resulting derivation larger.
>
> Therefore there are 2 possibilites:
>
> - Add support for SVG by adding qtsvg-5 and any additional packages [1]
> This would be preferable as the images are displayed in the time series and the bitmaps will look ugly.
>
> 2. Convert all into pngs
> This will save size but will require a big patch (which will be mostly binary)
> What do you think?

Option 1 (simply adding qtsvg-5) sounds more reasonable to me.

-- 
Thanks,
Maxim