* bug#31844: [cuirass] Invalid specs are ignored, should be reported instead
@ 2018-06-15 12:37 Ricardo Wurmus
2021-03-25 13:56 ` Mathieu Othacehe
0 siblings, 1 reply; 2+ messages in thread
From: Ricardo Wurmus @ 2018-06-15 12:37 UTC (permalink / raw)
To: 31844
When Cuirass processes a list of specifications it silently ignores
those that would result in erroneous SQL statements.
Take for example a specification that does not include an #:arguments
field. The database schema says that “arguments” may not be NULL, but
db-add-specification will produce an INSERT statement that sets
“arguments” to NULL when it is not part of the specification alist.
Cuirass should either validate the specifications before passing them to
“db-add-specification” or report an error when “db-add-specification”
fails to add a table record.
--
Ricardo
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#31844: [cuirass] Invalid specs are ignored, should be reported instead
2018-06-15 12:37 bug#31844: [cuirass] Invalid specs are ignored, should be reported instead Ricardo Wurmus
@ 2021-03-25 13:56 ` Mathieu Othacehe
0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Othacehe @ 2021-03-25 13:56 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: 31844-done
Hello,
Invalid specifications are now reported, see for example:
--8<---------------cut here---------------start------------->8---
(list (specification
(namee "guix-master")
(build 'hello)))
--8<---------------cut here---------------end--------------->8---
gives,
--8<---------------cut here---------------start------------->8---
2021-03-25T14:52:46 running Fibers on 4 kernel threads
/home/mathieu/cuirass/examples/hello.scm:1:6: error: (specification (namee "guix-master") (build (quote hello))): extraneous field initializers (namee)
--8<---------------cut here---------------end--------------->8---
Closing this one,
Thanks,
Mathieu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-25 13:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-15 12:37 bug#31844: [cuirass] Invalid specs are ignored, should be reported instead Ricardo Wurmus
2021-03-25 13:56 ` Mathieu Othacehe
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).