From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: bug#31844: [cuirass] Invalid specs are ignored, should be reported instead Date: Fri, 15 Jun 2018 14:37:19 +0200 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTnzR-0002Bt-Jl for bug-guix@gnu.org; Fri, 15 Jun 2018 08:38:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTnzO-00019e-E8 for bug-guix@gnu.org; Fri, 15 Jun 2018 08:38:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:41187) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fTnzO-00019V-B6 for bug-guix@gnu.org; Fri, 15 Jun 2018 08:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fTnzO-0005rW-31 for bug-guix@gnu.org; Fri, 15 Jun 2018 08:38:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTnz2-0001sQ-O3 for bug-guix@gnu.org; Fri, 15 Jun 2018 08:37:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTnyz-0000qM-LU for bug-guix@gnu.org; Fri, 15 Jun 2018 08:37:40 -0400 Received: from pegasus.bbbm.mdc-berlin.de ([141.80.25.20]:55586) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fTnyz-0000nU-A9 for bug-guix@gnu.org; Fri, 15 Jun 2018 08:37:37 -0400 Received: from localhost (localhost [127.0.0.1]) by pegasus.bbbm.mdc-berlin.de (Postfix) with ESMTP id 3840E926FC9 for ; Fri, 15 Jun 2018 14:37:35 +0200 (CEST) Received: from pegasus.bbbm.mdc-berlin.de ([127.0.0.1]) by localhost (pegasus.bbbm.mdc-berlin.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y7JYoTOMit4R for ; Fri, 15 Jun 2018 14:37:30 +0200 (CEST) Received: from HTCAONE.mdc-berlin.net (puck.citx.mdc-berlin.de [141.80.36.101]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pegasus.bbbm.mdc-berlin.de (Postfix) with ESMTPS for ; Fri, 15 Jun 2018 14:37:29 +0200 (CEST) List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: 31844@debbugs.gnu.org When Cuirass processes a list of specifications it silently ignores those that would result in erroneous SQL statements. Take for example a specification that does not include an #:arguments field. The database schema says that =E2=80=9Carguments=E2=80=9D may not= be NULL, but db-add-specification will produce an INSERT statement that sets =E2=80=9Carguments=E2=80=9D to NULL when it is not part of the specificat= ion alist. Cuirass should either validate the specifications before passing them to =E2=80=9Cdb-add-specification=E2=80=9D or report an error when =E2=80=9Cd= b-add-specification=E2=80=9D fails to add a table record. -- Ricardo