* bug#54558: mcomix refuses to run, missing GTK libraries
@ 2022-03-24 20:08 Natalie
2022-03-25 20:37 ` bug#54558: [PATCH 1/2] gnu: mcomix: Update to 2.0.1 Liliana Marie Prikler
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Natalie @ 2022-03-24 20:08 UTC (permalink / raw)
To: 54558
Hi there,
I've just tried to install mcomix on Guix System, but have had no luck
running it.
Upon installing and trying to run it in the shell, it fails with:
> [MainThread] ERROR: You do not have the required versions of GTK+ 3.0 installed.
Does GTK need to be added to its inputs?
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#54558: [PATCH 1/2] gnu: mcomix: Update to 2.0.1.
2022-03-24 20:08 bug#54558: mcomix refuses to run, missing GTK libraries Natalie
@ 2022-03-25 20:37 ` Liliana Marie Prikler
2022-03-26 2:57 ` bug#54558: mcomix refuses to run, missing GTK libraries Maxim Cournoyer
2022-03-25 22:45 ` bug#54558: [PATCH 2/2] gnu: mcomix: Wrap missing paths Liliana Marie Prikler
2022-03-27 2:26 ` bug#54558: Mcomix 2.0.1 do not install locale data Feng Shu
2 siblings, 1 reply; 8+ messages in thread
From: Liliana Marie Prikler @ 2022-03-25 20:37 UTC (permalink / raw)
To: 54558; +Cc: batalie
* gnu/packages/image-viewers.scm (mcomix): Update to 2.0.1.
[source]: Use sourceforge once again.
[inputs]: Add ‘python’.
[arguments]: Convert to a list of G-Expressions.
<#:tests?>: Drop.
<#:phases>: Rename ‘configure’ to ‘patch-sources’. Also fix an assertion
error in "mcomix/image_tools.py".
No longer replace ‘build’ or ‘install’. Add ‘install-data’ phase after
‘install’. Use (this-package-input) to refer to the python input.
---
gnu/packages/image-viewers.scm | 123 +++++++++++----------------------
1 file changed, 42 insertions(+), 81 deletions(-)
diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index 6ab6cf3307..1c325cd8a7 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -662,91 +662,52 @@ (define-public luminance-hdr
;; CBR and RAR are currently unsupported, due to non-free dependencies.
(define-public mcomix
- ;; Official mcomix hasn't been updated since 2016, it's broken with
- ;; python-pillow 6+ and only supports Python 2. We use fork instead.
- (let ((commit "fea55a7a9369569eefed72209eed830409c4af98"))
- (package
- (name "mcomix")
- (version (git-version "1.2.1" "1" commit))
- (source
- (origin
- (method git-fetch)
- (uri (git-reference
- (url "https://github.com/multiSnow/mcomix3")
- (commit commit)))
- (file-name (git-file-name name version))
- (sha256
- (base32
- "05zl0dkjwbdcm2zlk4nz9w33amlqj8pbf32a8ymshc2356fqhhi5"))))
- (build-system python-build-system)
- (inputs
- (list p7zip python-pillow python-pygobject python-pycairo))
- (arguments
- `(#:tests? #f ; FIXME: How do we run tests?
- #:phases
- (modify-phases %standard-phases
- (add-after 'unpack 'configure
- (lambda* (#:key inputs #:allow-other-keys)
- (let ((p7zip (assoc-ref inputs "p7zip")))
- ;; insert absolute path to 7z executable
- (substitute* "mcomix/mcomix/archive/sevenzip_external.py"
- (("_7z_executable = -1")
- (string-append "_7z_executable = u'" p7zip "/bin/7z'"))))
- #t))
- (replace 'build
- (lambda* (#:key outputs #:allow-other-keys)
- (let* ((out (assoc-ref outputs "out"))
- (pyver ,(version-major+minor (package-version python)))
- (lib (string-append out "/lib/python" pyver)))
- (invoke (which "python") "installer.py" "--srcdir=mcomix"
- (string-append "--target=" lib))
- (rename-file (string-append lib "/mcomix")
- (string-append lib "/site-packages"))
- #t)))
- (replace 'install
- (lambda* (#:key outputs #:allow-other-keys)
- (let* ((out (assoc-ref outputs "out"))
- (share (string-append out "/share"))
- (bin (string-append out "/bin"))
- (pyver ,(version-major+minor (package-version python)))
- (lib (string-append out "/lib/python" pyver "/site-packages")))
- (mkdir-p bin)
- (rename-file (string-append lib "/mcomixstarter.py")
- (string-append bin "/mcomix"))
- (rename-file (string-append lib "/comicthumb.py")
- (string-append bin "/comicthumb"))
- (install-file "mime/mcomix.desktop"
- (string-append share "/applications"))
- (install-file "mime/mcomix.appdata.xml"
- (string-append share "/metainfo"))
- (install-file "mime/mcomix.xml"
- (string-append share "/mime/packages"))
- (install-file "mime/comicthumb.thumbnailer"
- (string-append share "/thumbnailers"))
- (install-file "man/mcomix.1" (string-append share "/man/man1"))
- (install-file "man/comicthumb.1" (string-append share "/man/man1"))
- (for-each
- (lambda (size)
- (install-file
- (format #f "mcomix/mcomix/images/~sx~s/mcomix.png" size size)
- (format #f "~a/icons/hicolor/~sx~s/apps/" share size size))
- (for-each
- (lambda (ext)
- (install-file
- (format #f "mime/icons/~sx~s/application-x-~a.png" size size ext)
- (format #f "~a/icons/hicolor/~sx~s/mimetypes/"
- share size size)))
- '("cb7" "cbr" "cbt" "cbz")))
- '(16 22 24 32 48))
- #t))))))
- (home-page "https://sourceforge.net/p/mcomix/wiki/Home/")
- (synopsis "Image viewer for comics")
- (description "MComix is a customizable image viewer that specializes as
+ (package
+ (name "mcomix")
+ (version "2.0.1")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "mirror://sourceforge/mcomix/MComix-" version "/"
+ "mcomix-" version ".tar.gz"))
+ (sha256
+ (base32
+ "187ca815vxb2in1ryvfiaf1zapi0bc9jxdac3c1bky0kr6x7xyap"))))
+ (build-system python-build-system)
+ (inputs
+ (list p7zip python python-pillow python-pygobject python-pycairo))
+ (arguments
+ (list
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'patch-source
+ (lambda* (#:key inputs #:allow-other-keys)
+ (let ((p7zip (assoc-ref inputs "p7zip")))
+ ;; insert absolute path to 7z executable
+ (substitute* "mcomix/archive/sevenzip_external.py"
+ (("_7z_executable = -1")
+ (string-append "_7z_executable = u'" p7zip "/bin/7z'")))
+
+ (substitute* "mcomix/image_tools.py"
+ (("assert name not in supported_formats_gdk")
+ "if name in supported_formats_gdk: continue")))))
+ (add-after 'install 'install-data
+ (lambda* (#:key outputs #:allow-other-keys)
+ (copy-recursively
+ "mcomix/images"
+ (string-append (assoc-ref outputs "out")
+ "/lib/python"
+ #$(version-major+minor
+ (package-version (this-package-input "python")))
+ "/site-packages/mcomix/images")))))))
+ (home-page "https://sourceforge.net/p/mcomix/wiki/Home/")
+ (synopsis "Image viewer for comics")
+ (description "MComix is a customizable image viewer that specializes as
a comic and manga reader. It supports a variety of container formats
including CBZ, CB7, CBT, LHA.
For PDF support, install the @emph{mupdf} package.")
- (license license:gpl2+))))
+ (license license:gpl2+)))
(define-public qview
(package
--
2.34.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* bug#54558: [PATCH 2/2] gnu: mcomix: Wrap missing paths.
2022-03-24 20:08 bug#54558: mcomix refuses to run, missing GTK libraries Natalie
2022-03-25 20:37 ` bug#54558: [PATCH 1/2] gnu: mcomix: Update to 2.0.1 Liliana Marie Prikler
@ 2022-03-25 22:45 ` Liliana Marie Prikler
2022-03-27 2:26 ` bug#54558: Mcomix 2.0.1 do not install locale data Feng Shu
2 siblings, 0 replies; 8+ messages in thread
From: Liliana Marie Prikler @ 2022-03-25 22:45 UTC (permalink / raw)
To: 54558; +Cc: batalie
* gnu/packages/image-viewers.scm (mcomix)[inputs]: Add gtk+.
[arguments]<#:imported-modules,#:modules>: New arguments.
<#:phases>: Add ‘glib-or-gtk-wrap’ and ‘gi-wrap’.
---
gnu/packages/image-viewers.scm | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index 1c325cd8a7..134ffc563a 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -675,9 +675,14 @@ (define-public mcomix
"187ca815vxb2in1ryvfiaf1zapi0bc9jxdac3c1bky0kr6x7xyap"))))
(build-system python-build-system)
(inputs
- (list p7zip python python-pillow python-pygobject python-pycairo))
+ (list p7zip python python-pillow python-pygobject python-pycairo gtk+))
(arguments
(list
+ #:imported-modules `(,@%python-build-system-modules
+ (guix build glib-or-gtk-build-system))
+ #:modules '((guix build python-build-system)
+ ((guix build glib-or-gtk-build-system) #:prefix glib-or-gtk:)
+ (guix build utils))
#:phases
#~(modify-phases %standard-phases
(add-after 'unpack 'patch-source
@@ -699,7 +704,17 @@ (define-public mcomix
"/lib/python"
#$(version-major+minor
(package-version (this-package-input "python")))
- "/site-packages/mcomix/images")))))))
+ "/site-packages/mcomix/images"))))
+ (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap
+ (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))
+ (add-after 'wrap 'gi-wrap
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
+ (for-each
+ (lambda (prog)
+ (wrap-program prog
+ `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH")))))
+ (list (string-append bin "/mcomix")))))))))
(home-page "https://sourceforge.net/p/mcomix/wiki/Home/")
(synopsis "Image viewer for comics")
(description "MComix is a customizable image viewer that specializes as
--
2.34.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* bug#54558: mcomix refuses to run, missing GTK libraries
2022-03-25 20:37 ` bug#54558: [PATCH 1/2] gnu: mcomix: Update to 2.0.1 Liliana Marie Prikler
@ 2022-03-26 2:57 ` Maxim Cournoyer
2022-03-26 8:01 ` Liliana Marie Prikler
0 siblings, 1 reply; 8+ messages in thread
From: Maxim Cournoyer @ 2022-03-26 2:57 UTC (permalink / raw)
To: Liliana Marie Prikler; +Cc: 54558, batalie
Hi Liliana,
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> * gnu/packages/image-viewers.scm (mcomix): Update to 2.0.1.
> [source]: Use sourceforge once again.
> [inputs]: Add ‘python’.
> [arguments]: Convert to a list of G-Expressions.
> <#:tests?>: Drop.
> <#:phases>: Rename ‘configure’ to ‘patch-sources’. Also fix an assertion
> error in "mcomix/image_tools.py".
> No longer replace ‘build’ or ‘install’. Add ‘install-data’ phase after
> ‘install’. Use (this-package-input) to refer to the python input.
> ---
> gnu/packages/image-viewers.scm | 123 +++++++++++----------------------
> 1 file changed, 42 insertions(+), 81 deletions(-)
>
> diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
> index 6ab6cf3307..1c325cd8a7 100644
> --- a/gnu/packages/image-viewers.scm
> +++ b/gnu/packages/image-viewers.scm
> @@ -662,91 +662,52 @@ (define-public luminance-hdr
>
> ;; CBR and RAR are currently unsupported, due to non-free dependencies.
> (define-public mcomix
> - ;; Official mcomix hasn't been updated since 2016, it's broken with
> - ;; python-pillow 6+ and only supports Python 2. We use fork instead.
> - (let ((commit "fea55a7a9369569eefed72209eed830409c4af98"))
> - (package
> - (name "mcomix")
> - (version (git-version "1.2.1" "1" commit))
> - (source
> - (origin
> - (method git-fetch)
> - (uri (git-reference
> - (url "https://github.com/multiSnow/mcomix3")
> - (commit commit)))
> - (file-name (git-file-name name version))
> - (sha256
> - (base32
> - "05zl0dkjwbdcm2zlk4nz9w33amlqj8pbf32a8ymshc2356fqhhi5"))))
> - (build-system python-build-system)
> - (inputs
> - (list p7zip python-pillow python-pygobject python-pycairo))
> - (arguments
> - `(#:tests? #f ; FIXME: How do we run tests?
> - #:phases
> - (modify-phases %standard-phases
> - (add-after 'unpack 'configure
> - (lambda* (#:key inputs #:allow-other-keys)
> - (let ((p7zip (assoc-ref inputs "p7zip")))
> - ;; insert absolute path to 7z executable
> - (substitute* "mcomix/mcomix/archive/sevenzip_external.py"
> - (("_7z_executable = -1")
> - (string-append "_7z_executable = u'" p7zip "/bin/7z'"))))
> - #t))
> - (replace 'build
> - (lambda* (#:key outputs #:allow-other-keys)
> - (let* ((out (assoc-ref outputs "out"))
> - (pyver ,(version-major+minor (package-version python)))
> - (lib (string-append out "/lib/python" pyver)))
> - (invoke (which "python") "installer.py" "--srcdir=mcomix"
> - (string-append "--target=" lib))
> - (rename-file (string-append lib "/mcomix")
> - (string-append lib "/site-packages"))
> - #t)))
> - (replace 'install
> - (lambda* (#:key outputs #:allow-other-keys)
> - (let* ((out (assoc-ref outputs "out"))
> - (share (string-append out "/share"))
> - (bin (string-append out "/bin"))
> - (pyver ,(version-major+minor (package-version python)))
> - (lib (string-append out "/lib/python" pyver "/site-packages")))
> - (mkdir-p bin)
> - (rename-file (string-append lib "/mcomixstarter.py")
> - (string-append bin "/mcomix"))
> - (rename-file (string-append lib "/comicthumb.py")
> - (string-append bin "/comicthumb"))
> - (install-file "mime/mcomix.desktop"
> - (string-append share "/applications"))
> - (install-file "mime/mcomix.appdata.xml"
> - (string-append share "/metainfo"))
> - (install-file "mime/mcomix.xml"
> - (string-append share "/mime/packages"))
> - (install-file "mime/comicthumb.thumbnailer"
> - (string-append share "/thumbnailers"))
> - (install-file "man/mcomix.1" (string-append share "/man/man1"))
> - (install-file "man/comicthumb.1" (string-append share "/man/man1"))
> - (for-each
> - (lambda (size)
> - (install-file
> - (format #f "mcomix/mcomix/images/~sx~s/mcomix.png" size size)
> - (format #f "~a/icons/hicolor/~sx~s/apps/" share size size))
> - (for-each
> - (lambda (ext)
> - (install-file
> - (format #f "mime/icons/~sx~s/application-x-~a.png" size size ext)
> - (format #f "~a/icons/hicolor/~sx~s/mimetypes/"
> - share size size)))
> - '("cb7" "cbr" "cbt" "cbz")))
> - '(16 22 24 32 48))
> - #t))))))
> - (home-page "https://sourceforge.net/p/mcomix/wiki/Home/")
> - (synopsis "Image viewer for comics")
> - (description "MComix is a customizable image viewer that specializes as
> + (package
> + (name "mcomix")
> + (version "2.0.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "mirror://sourceforge/mcomix/MComix-" version "/"
> + "mcomix-" version ".tar.gz"))
> + (sha256
> + (base32
> + "187ca815vxb2in1ryvfiaf1zapi0bc9jxdac3c1bky0kr6x7xyap"))))
> + (build-system python-build-system)
> + (inputs
> + (list p7zip python python-pillow python-pygobject python-pycairo))
> + (arguments
> + (list
> + #:phases
> + #~(modify-phases %standard-phases
> + (add-after 'unpack 'patch-source
> + (lambda* (#:key inputs #:allow-other-keys)
> + (let ((p7zip (assoc-ref inputs "p7zip")))
> + ;; insert absolute path to 7z executable
I know it's in the original, but since while we're revamping the
package, let's make this comment a proper complete sentence.
> + (substitute* "mcomix/archive/sevenzip_external.py"
> + (("_7z_executable = -1")
> + (string-append "_7z_executable = u'" p7zip "/bin/7z'")))
I'd use something like:
(format #f "_7z_executable = ~s"
(search-input-file inputs "bin/7z"))
For the replacement. That unicode string (u"something") is
obsolete/unnecessary (all strings are unicode in Python 3).
> + (substitute* "mcomix/image_tools.py"
> + (("assert name not in supported_formats_gdk")
> + "if name in supported_formats_gdk: continue")))))
> + (add-after 'install 'install-data
> + (lambda* (#:key outputs #:allow-other-keys)
> + (copy-recursively
> + "mcomix/images"
> + (string-append (assoc-ref outputs "out")
> + "/lib/python"
> + #$(version-major+minor
> + (package-version (this-package-input "python")))
> + "/site-packages/mcomix/images")))))))
> + (home-page "https://sourceforge.net/p/mcomix/wiki/Home/")
> + (synopsis "Image viewer for comics")
> + (description "MComix is a customizable image viewer that specializes as
> a comic and manga reader. It supports a variety of container formats
> including CBZ, CB7, CBT, LHA.
>
> For PDF support, install the @emph{mupdf} package.")
> - (license license:gpl2+))))
> + (license license:gpl2+)))
I haven't tried it, but LGTM with my above comments addressed.
Thank you!
Maxim
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#54558: mcomix refuses to run, missing GTK libraries
2022-03-26 2:57 ` bug#54558: mcomix refuses to run, missing GTK libraries Maxim Cournoyer
@ 2022-03-26 8:01 ` Liliana Marie Prikler
0 siblings, 0 replies; 8+ messages in thread
From: Liliana Marie Prikler @ 2022-03-26 8:01 UTC (permalink / raw)
To: Maxim Cournoyer; +Cc: 54558-done, batalie
Hi Maxim,
Am Freitag, dem 25.03.2022 um 22:57 -0400 schrieb Maxim Cournoyer:
> Hi Liliana,
>
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
>
> > [...]
> > + (let ((p7zip (assoc-ref inputs "p7zip")))
> > + ;; insert absolute path to 7z executable
>
> I know it's in the original, but since while we're revamping the
> package, let's make this comment a proper complete sentence.
Thanks, did that.
> > + (substitute* "mcomix/archive/sevenzip_external.py"
> > + (("_7z_executable = -1")
> > + (string-append "_7z_executable = u'" p7zip
> > "/bin/7z'")))
>
> I'd use something like:
>
> (format #f "_7z_executable = ~s"
> (search-input-file inputs "bin/7z"))
>
> For the replacement. That unicode string (u"something") is
> obsolete/unnecessary (all strings are unicode in Python 3).
Thanks, did that.
> I haven't tried it, but LGTM with my above comments addressed.
I tried it in a pure shell and apart from the usual missing icons, it
launched fine. Closing.
Cheers
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#54558: Mcomix 2.0.1 do not install locale data.
2022-03-24 20:08 bug#54558: mcomix refuses to run, missing GTK libraries Natalie
2022-03-25 20:37 ` bug#54558: [PATCH 1/2] gnu: mcomix: Update to 2.0.1 Liliana Marie Prikler
2022-03-25 22:45 ` bug#54558: [PATCH 2/2] gnu: mcomix: Wrap missing paths Liliana Marie Prikler
@ 2022-03-27 2:26 ` Feng Shu
2022-03-27 9:39 ` Feng Shu
2 siblings, 1 reply; 8+ messages in thread
From: Feng Shu @ 2022-03-27 2:26 UTC (permalink / raw)
To: 54558; +Cc: Feng Shu
I think Mcomix 2.0.1 do not install locale date.
--
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#54558: Mcomix 2.0.1 do not install locale data.
2022-03-27 2:26 ` bug#54558: Mcomix 2.0.1 do not install locale data Feng Shu
@ 2022-03-27 9:39 ` Feng Shu
2022-03-27 9:52 ` Feng Shu
0 siblings, 1 reply; 8+ messages in thread
From: Feng Shu @ 2022-03-27 9:39 UTC (permalink / raw)
To: 54558; +Cc: Feng Shu
[-- Attachment #1: Type: text/plain, Size: 114 bytes --]
"Feng Shu" <tumashu@163.com> writes:
> I think Mcomix 2.0.1 do not install locale date.
I try to code a patch:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-mcomix-Install-messages-directory.patch --]
[-- Type: text/x-patch, Size: 3693 bytes --]
From bc1627e85cde9569b96057daa863184566863858 Mon Sep 17 00:00:00 2001
From: Feng Shu <tumashu@163.com>
Date: Sun, 27 Mar 2022 17:35:13 +0800
Subject: [PATCH] gnu: mcomix: Install messages directory.
* gnu/packages/image-viewers.scm (mcomix)
[arguments]: Install messages directory.
---
gnu/packages/image-viewers.scm | 51 +++++++++++++++++-----------------
1 file changed, 26 insertions(+), 25 deletions(-)
diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index 05a8151c29..7410605077 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -695,31 +695,32 @@ (define-public mcomix
(substitute* "mcomix/image_tools.py"
(("assert name not in supported_formats_gdk")
"if name in supported_formats_gdk: continue"))))
- (add-after 'install 'install-data
- (lambda* (#:key outputs #:allow-other-keys)
- (copy-recursively
- "mcomix/images"
- (string-append (assoc-ref outputs "out")
- "/lib/python"
- #$(version-major+minor
- (package-version (this-package-input "python")))
- "/site-packages/mcomix/images"))))
- (add-after 'install 'install-messages
- (lambda* (#:key outputs #:allow-other-keys)
- (copy-recursively
- "mcomix/messages"
- (string-append (assoc-ref outputs "out")
- "/share/locale"))))
- (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap
- (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))
- (add-after 'wrap 'gi-wrap
- (lambda* (#:key outputs #:allow-other-keys)
- (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
- (for-each
- (lambda (prog)
- (wrap-program prog
- `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH")))))
- (list (string-append bin "/mcomix")))))))))
+ (add-after 'install 'install-data
+ (lambda* (#:key outputs #:allow-other-keys)
+ (copy-recursively
+ "mcomix/images"
+ (string-append (assoc-ref outputs "out")
+ "/lib/python"
+ #$(version-major+minor
+ (package-version (this-package-input "python")))
+ "/site-packages/mcomix/images"))
+ (copy-recursively
+ "mcomix/messages"
+ (string-append (assoc-ref outputs "out")
+ "/lib/python"
+ #$(version-major+minor
+ (package-version (this-package-input "python")))
+ "/site-packages/mcomix/messages"))))
+ (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap
+ (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))
+ (add-after 'wrap 'gi-wrap
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
+ (for-each
+ (lambda (prog)
+ (wrap-program prog
+ `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH")))))
+ (list (string-append bin "/mcomix")))))))))
(home-page "https://sourceforge.net/p/mcomix/wiki/Home/")
(synopsis "Image viewer for comics")
(description "MComix is a customizable image viewer that specializes as
--
2.34.0
[-- Attachment #3: Type: text/plain, Size: 6 bytes --]
--
^ permalink raw reply related [flat|nested] 8+ messages in thread
* bug#54558: Mcomix 2.0.1 do not install locale data.
2022-03-27 9:39 ` Feng Shu
@ 2022-03-27 9:52 ` Feng Shu
0 siblings, 0 replies; 8+ messages in thread
From: Feng Shu @ 2022-03-27 9:52 UTC (permalink / raw)
To: 54558; +Cc: Feng Shu
[-- Attachment #1: Type: text/plain, Size: 4054 bytes --]
"Feng Shu" <tumashu@163.com> writes:
> "Feng Shu" <tumashu@163.com> writes:
>
>> I think Mcomix 2.0.1 do not install locale date.
>
> I try to code a patch:
>
> From bc1627e85cde9569b96057daa863184566863858 Mon Sep 17 00:00:00 2001
> From: Feng Shu <tumashu@163.com>
> Date: Sun, 27 Mar 2022 17:35:13 +0800
> Subject: [PATCH] gnu: mcomix: Install messages directory.
>
> * gnu/packages/image-viewers.scm (mcomix)
> [arguments]: Install messages directory.
> ---
> gnu/packages/image-viewers.scm | 51 +++++++++++++++++-----------------
> 1 file changed, 26 insertions(+), 25 deletions(-)
>
> diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
> index 05a8151c29..7410605077 100644
> --- a/gnu/packages/image-viewers.scm
> +++ b/gnu/packages/image-viewers.scm
> @@ -695,31 +695,32 @@ (define-public mcomix
> (substitute* "mcomix/image_tools.py"
> (("assert name not in supported_formats_gdk")
> "if name in supported_formats_gdk: continue"))))
> - (add-after 'install 'install-data
> - (lambda* (#:key outputs #:allow-other-keys)
> - (copy-recursively
> - "mcomix/images"
> - (string-append (assoc-ref outputs "out")
> - "/lib/python"
> - #$(version-major+minor
> - (package-version (this-package-input "python")))
> - "/site-packages/mcomix/images"))))
> - (add-after 'install 'install-messages
> - (lambda* (#:key outputs #:allow-other-keys)
> - (copy-recursively
> - "mcomix/messages"
> - (string-append (assoc-ref outputs "out")
> - "/share/locale"))))
> - (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap
> - (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))
> - (add-after 'wrap 'gi-wrap
> - (lambda* (#:key outputs #:allow-other-keys)
> - (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
> - (for-each
> - (lambda (prog)
> - (wrap-program prog
> - `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH")))))
> - (list (string-append bin "/mcomix")))))))))
> + (add-after 'install 'install-data
> + (lambda* (#:key outputs #:allow-other-keys)
> + (copy-recursively
> + "mcomix/images"
> + (string-append (assoc-ref outputs "out")
> + "/lib/python"
> + #$(version-major+minor
> + (package-version (this-package-input "python")))
> + "/site-packages/mcomix/images"))
> + (copy-recursively
> + "mcomix/messages"
> + (string-append (assoc-ref outputs "out")
> + "/lib/python"
> + #$(version-major+minor
> + (package-version (this-package-input "python")))
> + "/site-packages/mcomix/messages"))))
> + (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap
> + (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))
> + (add-after 'wrap 'gi-wrap
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
> + (for-each
> + (lambda (prog)
> + (wrap-program prog
> + `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH")))))
> + (list (string-append bin "/mcomix")))))))))
> (home-page "https://sourceforge.net/p/mcomix/wiki/Home/")
> (synopsis "Image viewer for comics")
> (description "MComix is a customizable image viewer that specializes as
> --
> 2.34.0
Sorry, the above is wrong patch, please see below:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-mcomix-Install-messages-directory.patch --]
[-- Type: text/x-patch, Size: 3418 bytes --]
From a84f1c8d1ad923f2b90fdf40a0655f8015f122a8 Mon Sep 17 00:00:00 2001
From: Feng Shu <tumashu@163.com>
Date: Sun, 27 Mar 2022 17:47:52 +0800
Subject: [PATCH] gnu: mcomix: Install messages directory.
* gnu/packages/image-viewers.scm (mcomix)
[arguments]: Install messages directory.
---
gnu/packages/image-viewers.scm | 45 ++++++++++++++++++++--------------
1 file changed, 26 insertions(+), 19 deletions(-)
diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index 09c448e8f5..7410605077 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -695,25 +695,32 @@ (define-public mcomix
(substitute* "mcomix/image_tools.py"
(("assert name not in supported_formats_gdk")
"if name in supported_formats_gdk: continue"))))
- (add-after 'install 'install-data
- (lambda* (#:key outputs #:allow-other-keys)
- (copy-recursively
- "mcomix/images"
- (string-append (assoc-ref outputs "out")
- "/lib/python"
- #$(version-major+minor
- (package-version (this-package-input "python")))
- "/site-packages/mcomix/images"))))
- (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap
- (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))
- (add-after 'wrap 'gi-wrap
- (lambda* (#:key outputs #:allow-other-keys)
- (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
- (for-each
- (lambda (prog)
- (wrap-program prog
- `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH")))))
- (list (string-append bin "/mcomix")))))))))
+ (add-after 'install 'install-data
+ (lambda* (#:key outputs #:allow-other-keys)
+ (copy-recursively
+ "mcomix/images"
+ (string-append (assoc-ref outputs "out")
+ "/lib/python"
+ #$(version-major+minor
+ (package-version (this-package-input "python")))
+ "/site-packages/mcomix/images"))
+ (copy-recursively
+ "mcomix/messages"
+ (string-append (assoc-ref outputs "out")
+ "/lib/python"
+ #$(version-major+minor
+ (package-version (this-package-input "python")))
+ "/site-packages/mcomix/messages"))))
+ (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap
+ (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))
+ (add-after 'wrap 'gi-wrap
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
+ (for-each
+ (lambda (prog)
+ (wrap-program prog
+ `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH")))))
+ (list (string-append bin "/mcomix")))))))))
(home-page "https://sourceforge.net/p/mcomix/wiki/Home/")
(synopsis "Image viewer for comics")
(description "MComix is a customizable image viewer that specializes as
--
2.34.0
[-- Attachment #3: Type: text/plain, Size: 7 bytes --]
--
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-03-27 9:53 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-24 20:08 bug#54558: mcomix refuses to run, missing GTK libraries Natalie
2022-03-25 20:37 ` bug#54558: [PATCH 1/2] gnu: mcomix: Update to 2.0.1 Liliana Marie Prikler
2022-03-26 2:57 ` bug#54558: mcomix refuses to run, missing GTK libraries Maxim Cournoyer
2022-03-26 8:01 ` Liliana Marie Prikler
2022-03-25 22:45 ` bug#54558: [PATCH 2/2] gnu: mcomix: Wrap missing paths Liliana Marie Prikler
2022-03-27 2:26 ` bug#54558: Mcomix 2.0.1 do not install locale data Feng Shu
2022-03-27 9:39 ` Feng Shu
2022-03-27 9:52 ` Feng Shu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).