From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6DJGNUWBPmL+BgEAgWs5BA (envelope-from ) for ; Sat, 26 Mar 2022 03:58:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 4A2PMkWBPmLbdwAA9RJhRA (envelope-from ) for ; Sat, 26 Mar 2022 03:58:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6401DB5A7 for ; Sat, 26 Mar 2022 03:58:13 +0100 (CET) Received: from localhost ([::1]:53990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXwd2-0005c0-8T for larch@yhetil.org; Fri, 25 Mar 2022 22:58:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44100) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXwcs-0005ZF-RY for bug-guix@gnu.org; Fri, 25 Mar 2022 22:58:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58928) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nXwcs-0001Iz-Ip for bug-guix@gnu.org; Fri, 25 Mar 2022 22:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nXwcs-0003wk-Fe for bug-guix@gnu.org; Fri, 25 Mar 2022 22:58:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#54558: mcomix refuses to run, missing GTK libraries Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 26 Mar 2022 02:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54558 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Liliana Marie Prikler Received: via spool by 54558-submit@debbugs.gnu.org id=B54558.164826346015086 (code B ref 54558); Sat, 26 Mar 2022 02:58:02 +0000 Received: (at 54558) by debbugs.gnu.org; 26 Mar 2022 02:57:40 +0000 Received: from localhost ([127.0.0.1]:52825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXwcS-0003v3-0H for submit@debbugs.gnu.org; Fri, 25 Mar 2022 22:57:40 -0400 Received: from mail-qk1-f176.google.com ([209.85.222.176]:36776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXwcQ-0003ud-6s for 54558@debbugs.gnu.org; Fri, 25 Mar 2022 22:57:34 -0400 Received: by mail-qk1-f176.google.com with SMTP id v13so7398991qkv.3 for <54558@debbugs.gnu.org>; Fri, 25 Mar 2022 19:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=EnyCnqqobtbcnK0iBnqBe0bJXnmPn3V8FqLnHf1wW18=; b=bN104xSKBlfBJP16EVFoEuWVD2FPZiOcBqsW1aPN73/yJiM6k1f0Q09h0jwKG6cb6H wmQhdvHEQsS2cEHntxbvlqMutn8Axoy2kXD7b+P79v1z0NFInhWGP+DG59NF/xncKOWv rS882wJl+hhr+G32Qx6YtRG6jfEEuT7nIEtZG14oxUT5wY6qP4iQ9buEXzsgQHklv8nL /Ihn2OIA34o/OcQA93QP+D7koUNge9pdbyB3r7wBpCpkB7P3f392+jFWJZ017tZ0DDuF E3jPPvVrtbW31i0Pec7jM1dy4vuzOQfcsEAUXZQJwSV8CcsSYcfBncSMpBHx/9x4EaR6 97bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=EnyCnqqobtbcnK0iBnqBe0bJXnmPn3V8FqLnHf1wW18=; b=JiFI8vZj8DpfxuGYmDp3dio8l8aIPLB5/+T234/0uulF75Avwn63idFh4/kAfoP97/ W1SFiMsoQjqSU8DYTZYjp7Uk/tM3ZLeHYnml1UyMsg/SwfRtS3uF3wIUiBScfV+jwwh3 XD9N+2e9uwkWkKHNHf0lagrjZx46yGvpfRnvYmZrurVAs9CX5buGWXxBHWByfJhMyjFW O2qi5lreQPmN3xuUb5wy6YJc8FszFO6zSs61BnabPOGuuxTcVRpdFlLsi3CbmTAHJZBk qADa/SPiOxk9F2Uwxrfg23JwUPZZM7CWz0YVNdSj+hOcGFNVb9YluzWY4itYCmd+r0Ic 9/1A== X-Gm-Message-State: AOAM533NV6VMQ+rZ6ibtSRUNB/b/FgzjeLIY88AkGeFPCleS6aZ9Gl1Q yJV7Ro7/6CaLqqr/ayzihp8= X-Google-Smtp-Source: ABdhPJyI8rkUKc9L4w/FEwcMhDerxHLvewV/i0mzEUgIXZ5WAbO6tXLAa33X+dMERlSG+2Mly7QOaA== X-Received: by 2002:a05:620a:4541:b0:67e:4bb7:c11b with SMTP id u1-20020a05620a454100b0067e4bb7c11bmr8984746qkp.194.1648263448543; Fri, 25 Mar 2022 19:57:28 -0700 (PDT) Received: from hurd (dsl-157-48.b2b2c.ca. [66.158.157.48]) by smtp.gmail.com with ESMTPSA id 3-20020a370503000000b0067b03f03589sm4301738qkf.53.2022.03.25.19.57.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 19:57:27 -0700 (PDT) From: Maxim Cournoyer References: Date: Fri, 25 Mar 2022 22:57:26 -0400 In-Reply-To: (Liliana Marie Prikler's message of "Fri, 25 Mar 2022 21:37:01 +0100") Message-ID: <87czi9xvxl.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 54558@debbugs.gnu.org, batalie@riseup.net Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648263493; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=EnyCnqqobtbcnK0iBnqBe0bJXnmPn3V8FqLnHf1wW18=; b=qaAftS23gmDtiPxSDk3Kkk/fOpqwl+zkiQqQ8BQR91iaHDRL++ha4tt4Nmwb1amKK/eGDY UTp6kzFFt9CiQ0ugKWcYMw3zVhA8gM+Fa176JTOB5zha+KD109PqWBn6RVmLjMrtNShm6s K5/9YFBhc07JsHaANli6hsHc+AGb+owx7GYcZ4giLhha4csJ4Y9wOgL9atr3CYJvgTeBNF /SslDYckvejfoDU4TMSf/9oNElt6Wvvl1YLCjNU6lMmtyx102XzQpBlnEmKweTNSWEU+59 yuy6WAEsc2QN4nEKwIWOiQL033gryDTSKbhKWbetjWSTT2j2iKVc8AWLk6RZkQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648263493; a=rsa-sha256; cv=none; b=u13FT6qKu8sUsRx8zBvnrq6rJcwzZ+5j4yI9ErxdDDqmPd7nJj+kVLxRQ/5cmAmAErbyRV +XV2ZStLot3f96mZC5SUOWht5utm3nuFUwMht7P8tOCerx/S3LEayK4YslQhiI2My0uQCP Uyo6FR34F0VKvUfRMz118t8bUXU3IpbkgaFrRPJ4xjdntOdmIHprM6hvoJsoaIfFhdHWgV Yqq2CvgjFJOPmbAhXk3Y8+SrXcakb4ZhmZ7+DyiVlSU2+1l1eHIm3LUc+4JQAHSvxbdp0o dqqQIviowUSx51I3Exeq0L2lmMHkT9fig7FOvobBKKCrNevzISHzKrD/adDhAQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=bN104xSK; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.92 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=bN104xSK; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6401DB5A7 X-Spam-Score: 5.92 X-Migadu-Scanner: scn1.migadu.com X-TUID: rmMYPbtL0qbO Hi Liliana, Liliana Marie Prikler writes: > * gnu/packages/image-viewers.scm (mcomix): Update to 2.0.1. > [source]: Use sourceforge once again. > [inputs]: Add =E2=80=98python=E2=80=99. > [arguments]: Convert to a list of G-Expressions. > <#:tests?>: Drop. > <#:phases>: Rename =E2=80=98configure=E2=80=99 to =E2=80=98patch-sources= =E2=80=99. Also fix an assertion > error in "mcomix/image_tools.py". > No longer replace =E2=80=98build=E2=80=99 or =E2=80=98install=E2=80=99. = Add =E2=80=98install-data=E2=80=99 phase after > =E2=80=98install=E2=80=99. Use (this-package-input) to refer to the pyth= on input. > --- > gnu/packages/image-viewers.scm | 123 +++++++++++---------------------- > 1 file changed, 42 insertions(+), 81 deletions(-) > > diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.= scm > index 6ab6cf3307..1c325cd8a7 100644 > --- a/gnu/packages/image-viewers.scm > +++ b/gnu/packages/image-viewers.scm > @@ -662,91 +662,52 @@ (define-public luminance-hdr >=20=20 > ;; CBR and RAR are currently unsupported, due to non-free dependencies. > (define-public mcomix > - ;; Official mcomix hasn't been updated since 2016, it's broken with > - ;; python-pillow 6+ and only supports Python 2. We use fork instead. > - (let ((commit "fea55a7a9369569eefed72209eed830409c4af98")) > - (package > - (name "mcomix") > - (version (git-version "1.2.1" "1" commit)) > - (source > - (origin > - (method git-fetch) > - (uri (git-reference > - (url "https://github.com/multiSnow/mcomix3") > - (commit commit))) > - (file-name (git-file-name name version)) > - (sha256 > - (base32 > - "05zl0dkjwbdcm2zlk4nz9w33amlqj8pbf32a8ymshc2356fqhhi5")))) > - (build-system python-build-system) > - (inputs > - (list p7zip python-pillow python-pygobject python-pycairo)) > - (arguments > - `(#:tests? #f ; FIXME: How do we run tests? > - #:phases > - (modify-phases %standard-phases > - (add-after 'unpack 'configure > - (lambda* (#:key inputs #:allow-other-keys) > - (let ((p7zip (assoc-ref inputs "p7zip"))) > - ;; insert absolute path to 7z executable > - (substitute* "mcomix/mcomix/archive/sevenzip_external.p= y" > - (("_7z_executable =3D -1") > - (string-append "_7z_executable =3D u'" p7zip "/bin/7= z'")))) > - #t)) > - (replace 'build > - (lambda* (#:key outputs #:allow-other-keys) > - (let* ((out (assoc-ref outputs "out")) > - (pyver ,(version-major+minor (package-version pyth= on))) > - (lib (string-append out "/lib/python" pyver))) > - (invoke (which "python") "installer.py" "--srcdir=3Dmco= mix" > - (string-append "--target=3D" lib)) > - (rename-file (string-append lib "/mcomix") > - (string-append lib "/site-packages")) > - #t))) > - (replace 'install > - (lambda* (#:key outputs #:allow-other-keys) > - (let* ((out (assoc-ref outputs "out")) > - (share (string-append out "/share")) > - (bin (string-append out "/bin")) > - (pyver ,(version-major+minor (package-version pyth= on))) > - (lib (string-append out "/lib/python" pyver "/site= -packages"))) > - (mkdir-p bin) > - (rename-file (string-append lib "/mcomixstarter.py") > - (string-append bin "/mcomix")) > - (rename-file (string-append lib "/comicthumb.py") > - (string-append bin "/comicthumb")) > - (install-file "mime/mcomix.desktop" > - (string-append share "/applications")) > - (install-file "mime/mcomix.appdata.xml" > - (string-append share "/metainfo")) > - (install-file "mime/mcomix.xml" > - (string-append share "/mime/packages")) > - (install-file "mime/comicthumb.thumbnailer" > - (string-append share "/thumbnailers")) > - (install-file "man/mcomix.1" (string-append share "/man= /man1")) > - (install-file "man/comicthumb.1" (string-append share "= /man/man1")) > - (for-each > - (lambda (size) > - (install-file > - (format #f "mcomix/mcomix/images/~sx~s/mcomix.png" = size size) > - (format #f "~a/icons/hicolor/~sx~s/apps/" share siz= e size)) > - (for-each > - (lambda (ext) > - (install-file > - (format #f "mime/icons/~sx~s/application-x-~a.pn= g" size size ext) > - (format #f "~a/icons/hicolor/~sx~s/mimetypes/" > - share size size))) > - '("cb7" "cbr" "cbt" "cbz"))) > - '(16 22 24 32 48)) > - #t)))))) > - (home-page "https://sourceforge.net/p/mcomix/wiki/Home/") > - (synopsis "Image viewer for comics") > - (description "MComix is a customizable image viewer that specializ= es as > + (package > + (name "mcomix") > + (version "2.0.1") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "mirror://sourceforge/mcomix/MComix-" version= "/" > + "mcomix-" version ".tar.gz")) > + (sha256 > + (base32 > + "187ca815vxb2in1ryvfiaf1zapi0bc9jxdac3c1bky0kr6x7xyap")))) > + (build-system python-build-system) > + (inputs > + (list p7zip python python-pillow python-pygobject python-pycairo)) > + (arguments > + (list > + #:phases > + #~(modify-phases %standard-phases > + (add-after 'unpack 'patch-source > + (lambda* (#:key inputs #:allow-other-keys) > + (let ((p7zip (assoc-ref inputs "p7zip"))) > + ;; insert absolute path to 7z executable I know it's in the original, but since while we're revamping the package, let's make this comment a proper complete sentence. > + (substitute* "mcomix/archive/sevenzip_external.py" > + (("_7z_executable =3D -1") > + (string-append "_7z_executable =3D u'" p7zip "/bin/7z= '"))) I'd use something like: (format #f "_7z_executable =3D ~s" (search-input-file inputs "bin/7z")) For the replacement. That unicode string (u"something") is obsolete/unnecessary (all strings are unicode in Python 3). > + (substitute* "mcomix/image_tools.py" > + (("assert name not in supported_formats_gdk") > + "if name in supported_formats_gdk: continue"))))) > + (add-after 'install 'install-data > + (lambda* (#:key outputs #:allow-other-keys) > + (copy-recursively > + "mcomix/images" > + (string-append (assoc-ref outputs "out") > + "/lib/python" > + #$(version-major+minor > + (package-version (this-package-input "py= thon"))) > + "/site-packages/mcomix/images"))))))) > + (home-page "https://sourceforge.net/p/mcomix/wiki/Home/") > + (synopsis "Image viewer for comics") > + (description "MComix is a customizable image viewer that specializes= as > a comic and manga reader. It supports a variety of container formats > including CBZ, CB7, CBT, LHA. >=20=20 > For PDF support, install the @emph{mupdf} package.") > - (license license:gpl2+)))) > + (license license:gpl2+))) I haven't tried it, but LGTM with my above comments addressed. Thank you! Maxim