From: Arun Isaac <arunisaac@systemreboot.net>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: Alex Kost <alezost@gmail.com>, 27222@debbugs.gnu.org
Subject: bug#27222: [PATCH] emacs-build-system install phase doesn't honor directory hierarchy
Date: Mon, 05 Jun 2017 15:33:28 +0530 [thread overview]
Message-ID: <dd6c87a4.AEQALMWm9gUAAAAAAAAAAAPHPfoAAAACwQwAAAAAAAW9WABZNSx9@mailjet.com> (raw)
In-Reply-To: <87vaobnhtn.fsf@gmail.com>
> this might have to do with the fact that until recently most Elisp
> projects were organized as a single file of thousands of lines of code
> ;).
Exactly! :-)
> I've also factorized out the default args of the include and exclude
> option of the emacs-build-system install phase. Please see the two
> patches attached.
Thanks! Both patches LGTM. I just have a few doubts and minor comments.
> (define-module (guix build-system emacs)
> + #:use-module ((guix build emacs-build-system)
> + #:select (%default-include %default-exclude))
Interesting solution to the problem. I didn't think of this
earlier. Importing host side to build side would be a problem, but you
are importing build side to host side, and I think that's ok.
> #:use-module (guix store)
> #:use-module (guix utils)
> #:use-module (guix packages)
> @@ -28,7 +30,10 @@
> #:use-module (srfi srfi-26)
> #:export (%emacs-build-system-modules
> emacs-build
> - emacs-build-system))
> + emacs-build-system)
> + #:re-export (%default-include ;for convenience
> + %default-exclude))
What is this re-export for? ert-runner seems to build fine without
this. I don't understand what you mean by "convenience" here.
Also, perhaps we should deduplicate default values of arguments in the
gnu-build-system as well. But, I don't know if it is worth deduplicating
simple default values like #t. WDYT?
@Alex Kost:
Please make any other changes you think are necessary, and push. Thanks!
next prev parent reply other threads:[~2017-06-05 10:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-03 23:02 bug#27222: emacs-build-system install phase doesn't honor directory hierarchy Maxim Cournoyer
2017-06-04 6:53 ` bug#27222: [PATCH] " Maxim Cournoyer
2017-06-04 12:59 ` Alex Kost
2017-06-04 16:44 ` Maxim Cournoyer
2017-06-04 19:41 ` Alex Kost
2017-06-04 19:25 ` Arun Isaac
2017-06-05 5:07 ` Maxim Cournoyer
2017-06-05 10:03 ` Arun Isaac [this message]
[not found] ` <73a30871.AEQALMWm9gcAAAAAAAAAAAPHPfsAAAACwQwAAAAAAAW9WABZNSx9@mailjet.com>
2017-06-05 14:54 ` Maxim Cournoyer
[not found] ` <a444cf1b.AEQALMWm9gYAAAAAAAAAAAO2CsUAAAACwQwAAAAAAAW9WABZNSx9@mailjet.com>
2017-06-05 20:13 ` Alex Kost
2017-06-08 14:31 ` Arun Isaac
[not found] ` <ad8c9523.AEUALD4wqa8AAAAAAAAAAAPHPfsAAAACwQwAAAAAAAW9WABZOV_H@mailjet.com>
2017-06-08 14:58 ` Maxim Cournoyer
[not found] ` <0efe58d4.AEUAK47aAUsAAAAAAAAAAAO2CsUAAAACwQwAAAAAAAW9WABZNF6l@mailjet.com>
2017-06-05 20:07 ` Alex Kost
2017-06-06 17:44 ` Arun Isaac
2017-06-06 16:35 ` bug#27222: [PATCH] Fix ert-runner regression (was: emacs-build-system install phase doesn't honor directory hierarchy) Maxim Cournoyer
2017-06-06 23:02 ` bug#27222: [PATCH] Fix ert-runner regression Ludovic Courtès
2017-06-07 10:28 ` Arun Isaac
2017-06-07 20:11 ` Alex Kost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd6c87a4.AEQALMWm9gUAAAAAAAAAAAPHPfoAAAACwQwAAAAAAAW9WABZNSx9@mailjet.com \
--to=arunisaac@systemreboot.net \
--cc=27222@debbugs.gnu.org \
--cc=alezost@gmail.com \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).