From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arun Isaac Subject: bug#27222: [PATCH] emacs-build-system install phase doesn't honor directory hierarchy Date: Mon, 05 Jun 2017 15:33:28 +0530 Message-ID: References: <87h8zwptdn.fsf@gmail.com> <874lvwp7km.fsf@gmail.com> <87wp8rq57k.fsf@gmail.com> <87vaobnhtn.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHorm-0000Bp-6L for bug-guix@gnu.org; Mon, 05 Jun 2017 06:04:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHorj-0002FU-19 for bug-guix@gnu.org; Mon, 05 Jun 2017 06:04:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:53808) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dHori-0002Ew-Op for bug-guix@gnu.org; Mon, 05 Jun 2017 06:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dHori-0005dG-HA for bug-guix@gnu.org; Mon, 05 Jun 2017 06:04:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-reply-to: <87vaobnhtn.fsf@gmail.com> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Maxim Cournoyer Cc: Alex Kost , 27222@debbugs.gnu.org > this might have to do with the fact that until recently most Elisp > projects were organized as a single file of thousands of lines of code > ;). Exactly! :-) > I've also factorized out the default args of the include and exclude > option of the emacs-build-system install phase. Please see the two > patches attached. Thanks! Both patches LGTM. I just have a few doubts and minor comments. > (define-module (guix build-system emacs) > + #:use-module ((guix build emacs-build-system) > + #:select (%default-include %default-exclude)) Interesting solution to the problem. I didn't think of this earlier. Importing host side to build side would be a problem, but you are importing build side to host side, and I think that's ok. > #:use-module (guix store) > #:use-module (guix utils) > #:use-module (guix packages) > @@ -28,7 +30,10 @@ > #:use-module (srfi srfi-26) > #:export (%emacs-build-system-modules > emacs-build > - emacs-build-system)) > + emacs-build-system) > + #:re-export (%default-include ;for convenience > + %default-exclude)) What is this re-export for? ert-runner seems to build fine without this. I don't understand what you mean by "convenience" here. Also, perhaps we should deduplicate default values of arguments in the gnu-build-system as well. But, I don't know if it is worth deduplicating simple default values like #t. WDYT? @Alex Kost: Please make any other changes you think are necessary, and push. Thanks! =