From: Alex Kost <alezost@gmail.com>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: Maxim Cournoyer <maxim.cournoyer@gmail.com>, 27222@debbugs.gnu.org
Subject: bug#27222: [PATCH] emacs-build-system install phase doesn't honor directory hierarchy
Date: Mon, 05 Jun 2017 23:07:52 +0300 [thread overview]
Message-ID: <87o9u2kxk7.fsf@gmail.com> (raw)
In-Reply-To: <0efe58d4.AEUAK47aAUsAAAAAAAAAAAO2CsUAAAACwQwAAAAAAAW9WABZNF6l@mailjet.com> (Arun Isaac's message of "Mon, 05 Jun 2017 00:55:11 +0530")
Arun Isaac (2017-06-05 00:55 +0530) wrote:
[...]
>> I also think these arguments are redundant! I suggested to remove this
>> duplication at:
>>
>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26559#41
>
> And, I did respond at
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26559#53
Sure, I didn't mean I was ignored, I just wanted to say that I got the
same thought about those arguments as Maxim.
>> ... but I think the include/exclude arguments need to be duplicated in
>> two places. For example, look at arguments #:strip-flags and
>> #:strip-directories in the `strip' phase of the gnu-build-system. Even
>> there, the default values of the arguments are repeated in two places.
>
> Do you know of some way in which we can avoid duplication of the
> arguments?
As I said, I think this duplication can be avoided simply by removing
the values of 'include'/'exclude' arguments from 'install' procedures of
(guix build emacs-build-system) module.
> Even the gnu-build-system duplicates default values of arguments.
I don't know about gnu-build-system, but I don't see a reason to have
these values in 'install' procedure of emacs-build-system.
--
Alex
next prev parent reply other threads:[~2017-06-05 20:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-03 23:02 bug#27222: emacs-build-system install phase doesn't honor directory hierarchy Maxim Cournoyer
2017-06-04 6:53 ` bug#27222: [PATCH] " Maxim Cournoyer
2017-06-04 12:59 ` Alex Kost
2017-06-04 16:44 ` Maxim Cournoyer
2017-06-04 19:41 ` Alex Kost
2017-06-04 19:25 ` Arun Isaac
2017-06-05 5:07 ` Maxim Cournoyer
2017-06-05 10:03 ` Arun Isaac
[not found] ` <73a30871.AEQALMWm9gcAAAAAAAAAAAPHPfsAAAACwQwAAAAAAAW9WABZNSx9@mailjet.com>
2017-06-05 14:54 ` Maxim Cournoyer
[not found] ` <a444cf1b.AEQALMWm9gYAAAAAAAAAAAO2CsUAAAACwQwAAAAAAAW9WABZNSx9@mailjet.com>
2017-06-05 20:13 ` Alex Kost
2017-06-08 14:31 ` Arun Isaac
[not found] ` <ad8c9523.AEUALD4wqa8AAAAAAAAAAAPHPfsAAAACwQwAAAAAAAW9WABZOV_H@mailjet.com>
2017-06-08 14:58 ` Maxim Cournoyer
[not found] ` <0efe58d4.AEUAK47aAUsAAAAAAAAAAAO2CsUAAAACwQwAAAAAAAW9WABZNF6l@mailjet.com>
2017-06-05 20:07 ` Alex Kost [this message]
2017-06-06 17:44 ` Arun Isaac
2017-06-06 16:35 ` bug#27222: [PATCH] Fix ert-runner regression (was: emacs-build-system install phase doesn't honor directory hierarchy) Maxim Cournoyer
2017-06-06 23:02 ` bug#27222: [PATCH] Fix ert-runner regression Ludovic Courtès
2017-06-07 10:28 ` Arun Isaac
2017-06-07 20:11 ` Alex Kost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9u2kxk7.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=27222@debbugs.gnu.org \
--cc=arunisaac@systemreboot.net \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).