From: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
To: 25258@debbugs.gnu.org
Subject: bug#25258: Bashisms when building 0.11.0
Date: Sat, 24 Dec 2016 08:26:27 +0100 [thread overview]
Message-ID: <c3eb8da7-acf5-f661-48d1-fd70d322560d@pelzflorian.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 884 bytes --]
Hello,
Guix' testsuite uses the non-POSIX bashism `type -P guile` in
tests/guix-packages.sh which causes a test failure when using
Dash to provide /bin/sh instead of Bash. Additionally gnu/local.mk uses
brace expansion which is not part of POSIX and does not work on Dash.
When building Guix on Parabola GNU/Linux-libre modified to use Dash as
/bin/sh,[1] this causes the Guix build to fail. For building, the guix
0.11.0 package from AUR[2] was used. The attached “patch” allows for a
successful build but is not what we want.
Guix should probably not use bashisms in its Makefile includes and
either not use bashisms in its test suite or make sure the test suite is
executed explicitly with Bash and not /bin/sh.
Regards,
Florian Pelz
[1] https://wiki.archlinux.org/index.php/Dash#Use_DASH_as_.2Fbin.2Fsh
[2] https://aur.archlinux.org/packages/guix/
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: guix-remove-bashisms.patch --]
[-- Type: text/x-patch; name="guix-remove-bashisms.patch", Size: 1140 bytes --]
diff -aur guix-0.11.0.pristine/gnu/local.mk guix-0.11.0.new/gnu/local.mk
--- guix-0.11.0.pristine/gnu/local.mk 2016-12-23 16:24:51.501094452 +0100
+++ guix-0.11.0.new/gnu/local.mk 2016-12-23 17:26:55.651112436 +0100
@@ -903,7 +903,10 @@
# Those files must remain executable, so they remain executable once
# imported into the store.
set-bootstrap-executable-permissions:
- chmod +x $(DESTDIR)$(bootstrapdir)/*/{bash,mkdir,tar,xz}
+ chmod +x $(DESTDIR)$(bootstrapdir)/*/bash
+ chmod +x $(DESTDIR)$(bootstrapdir)/*/mkdir
+ chmod +x $(DESTDIR)$(bootstrapdir)/*/tar
+ chmod +x $(DESTDIR)$(bootstrapdir)/*/xz
DISTCLEANFILES = \
$(nodist_bootstrap_x86_64_linux_DATA) \
diff -aur guix-0.11.0.pristine/Makefile.am guix-0.11.0.new/Makefile.am
--- guix-0.11.0.pristine/Makefile.am 2016-12-23 16:24:49.007702057 +0100
+++ guix-0.11.0.new/Makefile.am 2016-12-23 16:25:39.372217348 +0100
@@ -275,7 +275,6 @@
tests/guix-download.sh \
tests/guix-gc.sh \
tests/guix-hash.sh \
- tests/guix-package.sh \
tests/guix-package-net.sh \
tests/guix-system.sh \
tests/guix-archive.sh \
next reply other threads:[~2016-12-24 7:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-24 7:26 pelzflorian (Florian Pelz) [this message]
2019-02-13 1:46 ` bug#25258: Bashisms when building 0.11.0 Leo Famulari
2020-03-22 20:28 ` Leo Famulari
2020-05-16 6:33 ` bug#25258: Bashisms in make rules elaexuotee--- via Bug reports for GNU Guix
2020-05-17 16:42 ` Vincent Legoll
2020-05-17 17:34 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3eb8da7-acf5-f661-48d1-fd70d322560d@pelzflorian.de \
--to=pelzflorian@pelzflorian.de \
--cc=25258@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).