unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Bug reports for GNU Guix <bug-guix@gnu.org>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: 25258@debbugs.gnu.org
Subject: bug#25258: Bashisms in make rules
Date: Sun, 17 May 2020 19:34:51 +0200	[thread overview]
Message-ID: <87y2pqtqh0.fsf@nckx> (raw)
In-Reply-To: <4c16cf7b-0a55-b7f2-4c49-a34ce1f815a1@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 993 bytes --]

Vincent,

Vincent Legoll 写道:
> I don't know guix team's stance on that kind ow work (I still 
> have not
> polished my work enough for review). But it looks like you 
> stumbled on
> some painful items, that ought to be resolved one way or the 
> other.

The only reason for Guix to have any shell code at all is to run 
in places where Guile isn't (yet) available.  Therefore it should 
be portable between GNU systems, or it might as well be Guile.  I 
don't believe GNU implies bash.

> It would be nice to hear that those are actionable items that 
> will
> receive positive feedback before doing substantial work. (Looks 
> like
> I should have asked that earlier, before falling into the rabbit
> hole...)

Big upz from me.  Thanks for being proactive :-)

The challenge is keeping new bashisms out, so sudo please try to 
include some automated tests.  Maybe you can use shellcheck; our 
test suite could use a GHC dependency.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

      reply	other threads:[~2020-05-17 17:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-24  7:26 bug#25258: Bashisms when building 0.11.0 pelzflorian (Florian Pelz)
2019-02-13  1:46 ` Leo Famulari
2020-03-22 20:28   ` Leo Famulari
2020-05-16  6:33 ` bug#25258: Bashisms in make rules elaexuotee--- via Bug reports for GNU Guix
2020-05-17 16:42 ` Vincent Legoll
2020-05-17 17:34   ` Tobias Geerinckx-Rice via Bug reports for GNU Guix [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2pqtqh0.fsf@nckx \
    --to=bug-guix@gnu.org \
    --cc=25258@debbugs.gnu.org \
    --cc=me@tobias.gr \
    --cc=vincent.legoll@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).