From mboxrd@z Thu Jan 1 00:00:00 1970 From: "pelzflorian (Florian Pelz)" Subject: bug#25258: Bashisms when building 0.11.0 Date: Sat, 24 Dec 2016 08:26:27 +0100 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------4C3B973F2B05E7C1C08D144A" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKh8b-0005Ui-N2 for bug-guix@gnu.org; Sat, 24 Dec 2016 02:53:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cKh8Y-0003WI-Ib for bug-guix@gnu.org; Sat, 24 Dec 2016 02:53:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:37762) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cKh8Y-0003WA-B2 for bug-guix@gnu.org; Sat, 24 Dec 2016 02:53:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cKh8Y-0002Xb-1o for bug-guix@gnu.org; Sat, 24 Dec 2016 02:53:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKgiw-0001VP-Bb for bug-guix@gnu.org; Sat, 24 Dec 2016 02:26:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cKgit-0004kn-7i for bug-guix@gnu.org; Sat, 24 Dec 2016 02:26:34 -0500 Received: from pelzflorian.de ([5.45.111.108]:33618 helo=mail.pelzflorian.de) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cKgis-0004iX-Tf for bug-guix@gnu.org; Sat, 24 Dec 2016 02:26:31 -0500 Received: from [192.168.178.21] (ip5f58bf63.dynamic.kabel-deutschland.de [95.88.191.99]) by mail.pelzflorian.de (Postfix) with ESMTPSA id F3BC1360003 for ; Sat, 24 Dec 2016 08:26:28 +0100 (CET) List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: 25258@debbugs.gnu.org This is a multi-part message in MIME format. --------------4C3B973F2B05E7C1C08D144A Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, Guix' testsuite uses the non-POSIX bashism `type -P guile` in tests/guix-packages.sh which causes a test failure when using Dash to provide /bin/sh instead of Bash. Additionally gnu/local.mk uses brace expansion which is not part of POSIX and does not work on Dash. When building Guix on Parabola GNU/Linux-libre modified to use Dash as /bin/sh,[1] this causes the Guix build to fail. For building, the guix 0.11.0 package from AUR[2] was used. The attached =E2=80=9Cpatch=E2=80=9D= allows for a successful build but is not what we want. Guix should probably not use bashisms in its Makefile includes and either not use bashisms in its test suite or make sure the test suite is executed explicitly with Bash and not /bin/sh. Regards, Florian Pelz [1] https://wiki.archlinux.org/index.php/Dash#Use_DASH_as_.2Fbin.2Fsh [2] https://aur.archlinux.org/packages/guix/ --------------4C3B973F2B05E7C1C08D144A Content-Type: text/x-patch; name="guix-remove-bashisms.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="guix-remove-bashisms.patch" diff -aur guix-0.11.0.pristine/gnu/local.mk guix-0.11.0.new/gnu/local.mk --- guix-0.11.0.pristine/gnu/local.mk 2016-12-23 16:24:51.501094452 +0100= +++ guix-0.11.0.new/gnu/local.mk 2016-12-23 17:26:55.651112436 +0100 @@ -903,7 +903,10 @@ # Those files must remain executable, so they remain executable once # imported into the store. set-bootstrap-executable-permissions: - chmod +x $(DESTDIR)$(bootstrapdir)/*/{bash,mkdir,tar,xz} + chmod +x $(DESTDIR)$(bootstrapdir)/*/bash + chmod +x $(DESTDIR)$(bootstrapdir)/*/mkdir + chmod +x $(DESTDIR)$(bootstrapdir)/*/tar + chmod +x $(DESTDIR)$(bootstrapdir)/*/xz =20 DISTCLEANFILES =3D \ $(nodist_bootstrap_x86_64_linux_DATA) \ diff -aur guix-0.11.0.pristine/Makefile.am guix-0.11.0.new/Makefile.am --- guix-0.11.0.pristine/Makefile.am 2016-12-23 16:24:49.007702057 +0100 +++ guix-0.11.0.new/Makefile.am 2016-12-23 16:25:39.372217348 +0100 @@ -275,7 +275,6 @@ tests/guix-download.sh \ tests/guix-gc.sh \ tests/guix-hash.sh \ - tests/guix-package.sh \ tests/guix-package-net.sh \ tests/guix-system.sh \ tests/guix-archive.sh \ --------------4C3B973F2B05E7C1C08D144A--