From: Maxime Devos <maximedevos@telenet.be>
To: zimoun <zimon.toutoune@gmail.com>, 52316@debbugs.gnu.org
Subject: bug#52316: Package example from cookbook has bugs
Date: Mon, 06 Dec 2021 15:10:59 +0000 [thread overview]
Message-ID: <bc2c9257d22665d3b532557e63f67605cc6514f4.camel@telenet.be> (raw)
In-Reply-To: <86lf0xolfw.fsf@gmail.com>
Hi,
zimoun schreef op ma 06-12-2021 om 15:30 [+0100]:
> [....]
> > #:tests? is unconditionally set to #true. This is bad for cross-
> > compilation and --without-tests=PACKAGE reasons, and would be
> > flagged
> > by the linter.
>
> For cross-compilation, yes. For ’--without-tests’, it is not an
> issue,
> IMHO, or why is it?
I was mistaken, unconditional #true is unproblematic for --without-
tests, because --without-tests replaces the #true by #false IIUC.
> > In the new 'check' phase, libgit2_clar is invoked unconditionally.
> > This
> > would be flagged by the linter.
>
> Since it is an example showing non-trivial things, maybe it can be
> pedagogical to have something half good, if and only if, “guix lint”
> reports the half bad. And add an explanation. WDYT?
I don't know what would be best from a pedagogical perspective: showing
the right code directly (showing more non-trivial things and not
showing any bugs, but possibly showing too much at once), or writing
the half-right code (with a short comment telling there's a bug that
will be explained later).
The second thing doesn't seem bad to me, but IANAP (I am not a
pedagogue).
Greetings,
Maxime
prev parent reply other threads:[~2021-12-06 15:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-05 19:18 bug#52316: Package example from cookbook has bugs Maxime Devos
2021-12-06 14:30 ` zimoun
2021-12-06 15:10 ` Maxime Devos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc2c9257d22665d3b532557e63f67605cc6514f4.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=52316@debbugs.gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).