From: zimoun <zimon.toutoune@gmail.com>
To: Maxime Devos <maximedevos@telenet.be>, 52316@debbugs.gnu.org
Subject: bug#52316: Package example from cookbook has bugs
Date: Mon, 06 Dec 2021 15:30:11 +0100 [thread overview]
Message-ID: <86lf0xolfw.fsf@gmail.com> (raw)
In-Reply-To: <c28989ee4519f5c7b8bfaf6652b8dfbcb54d733c.camel@telenet.be>
Hi Maxime,
On Sun, 05 Dec 2021 at 19:18, Maxime Devos <maximedevos@telenet.be> wrote:
> The example at
> https://guix.gnu.org/cookbook/en/html_node/Extended-example.html has
> two bugs:
>
> #:tests? is unconditionally set to #true. This is bad for cross-
> compilation and --without-tests=PACKAGE reasons, and would be flagged
> by the linter.
For cross-compilation, yes. For ’--without-tests’, it is not an issue,
IMHO, or why is it?
> In the new 'check' phase, libgit2_clar is invoked unconditionally. This
> would be flagged by the linter.
Since it is an example showing non-trivial things, maybe it can be
pedagogical to have something half good, if and only if, “guix lint”
reports the half bad. And add an explanation. WDYT?
> Also, not exactly a bug, but still bad practice: the web page suggests:
>
> #:make-flags (list (string-append "prefix=" (assoc-ref %outputs "out"))
> "CC=gcc")
>
> however, hardcoding gcc is bad for cross-compilation reasons. It should
> use (cc-for-target) instead.
I agree.
Cheers,
simon
next prev parent reply other threads:[~2021-12-06 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-05 19:18 bug#52316: Package example from cookbook has bugs Maxime Devos
2021-12-06 14:30 ` zimoun [this message]
2021-12-06 15:10 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86lf0xolfw.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=52316@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).