From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kEbADt4ormGnDgEAgWs5BA (envelope-from ) for ; Mon, 06 Dec 2021 16:14:38 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id CISMCt4ormGTdwAA1q6Kng (envelope-from ) for ; Mon, 06 Dec 2021 15:14:38 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 032D938C0C for ; Mon, 6 Dec 2021 16:14:38 +0100 (CET) Received: from localhost ([::1]:49796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1muFhN-0006PO-6m for larch@yhetil.org; Mon, 06 Dec 2021 10:14:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muFes-0003ru-JX for bug-guix@gnu.org; Mon, 06 Dec 2021 10:12:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51816) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1muFes-00038h-Bu for bug-guix@gnu.org; Mon, 06 Dec 2021 10:12:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1muFes-0005bi-6o for bug-guix@gnu.org; Mon, 06 Dec 2021 10:12:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#52316: Package example from cookbook has bugs Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 06 Dec 2021 15:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52316 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: zimoun , 52316@debbugs.gnu.org Received: via spool by 52316-submit@debbugs.gnu.org id=B52316.163880346521462 (code B ref 52316); Mon, 06 Dec 2021 15:12:02 +0000 Received: (at 52316) by debbugs.gnu.org; 6 Dec 2021 15:11:05 +0000 Received: from localhost ([127.0.0.1]:35129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muFdx-0005a5-LA for submit@debbugs.gnu.org; Mon, 06 Dec 2021 10:11:05 -0500 Received: from baptiste.telenet-ops.be ([195.130.132.51]:51184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muFdt-0005ZF-RQ for 52316@debbugs.gnu.org; Mon, 06 Dec 2021 10:11:03 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by baptiste.telenet-ops.be with bizsmtp id T3B0260014UW6Th013B0iy; Mon, 06 Dec 2021 16:11:00 +0100 Message-ID: From: Maxime Devos Date: Mon, 06 Dec 2021 15:10:59 +0000 In-Reply-To: <86lf0xolfw.fsf@gmail.com> References: <86lf0xolfw.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1638803460; bh=FI4WBiKbHfd/jiVi4mepn1ZLyYm7F6nJz3RtytBqKg8=; h=Subject:From:To:Date:In-Reply-To:References; b=iVTIwpdLSNDf1XGV9Id1liuhP82Qxb2X8mB8jXzYSxO/+NV9NY4D5ksA2Z2cEDRBn ObtrwOZ89sG0Fz/IM/nRSb+nQgBFQK8eVuv65s0o3d8JBu2SdLA+zRQnXO+WQakKmZ nwzzoSlpLt8I3/0wjORT/v+hVWb/eC6KQGwzXCEXHnkOLSRJYR5FHDWtlBBaJA3zrX V4DtXAGMyPxStMtU4aXWEJQVug+w0aiVXfEHKyaH5BJU2YEYyx5Z/nGz93+4lWsAAs J7bEr/QwLtKj1wijsoJgaZ40snMTmMVMhHbJ/7U5iOuSm7MyEn9MpYdcbmTAOT0y1b zmy9nhea74cdA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638803678; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=FI4WBiKbHfd/jiVi4mepn1ZLyYm7F6nJz3RtytBqKg8=; b=jyeGBKFGey6ThSay+iksgx1+iRqdXxx0gyfmjRTg5E1a5gXQf6yeQ1Gp6x9DCHzOxHDSwa 1mMBoHrtm882Rl/Te6ie9ycXKggvsFLduVtWvvtfgz/DQSFN/bfcVFU4CBWc/92vQeGmfi 5Bp6WCuCeK90auLDMFxC+amLHEoZTooVvtWITHlIF91bGZMITrrHpgnWAtGnRarfDqgXM/ bgz+F7KnP35ecNWTX06IFK7POytBsnszIEw5RuxmDVF0Wq+9tZSI6sqy0jq+2BKg8Ej2np Vpbf/KGjG0KfxrvJ0kbPA1RPWupR+RC0GZMp6blo9Gx5xickGP36/n7MslprZQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638803678; a=rsa-sha256; cv=none; b=S4fbAV64TGyD1Mf4hYZV3bWIo9yZVHQMIRSj29kkbSlLRt3itDK7Etng/My4Tzwp1cxlOG VARhMLnKn6YgrejKT1Cfwpq1V4J+Ix86harvyHQZeO9tEwhlat40dHK3qHYYOdR6adrklW N3288qvdXrwkcZKstlae2h/x16HvflAjdtSxj226GXIJfyPCwJnLrcGETxkpRdEHRwdJyE Hq9pTbh1ZjsAaH9ZWJYVK5uwokrYyrc5aLW8VtswGSUDocIUt9kkJhnqgKXqW0eUmiu2Il Ke/qdPyVjMdMxRCV0EmsWeeJ3nXwj75SS243Z6IcVgNS9Jlp1yWv8Oryr1V0iw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=iVTIwpdL; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.94 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=iVTIwpdL; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 032D938C0C X-Spam-Score: -1.94 X-Migadu-Scanner: scn0.migadu.com X-TUID: fY1EQ62zEVn0 Hi, zimoun schreef op ma 06-12-2021 om 15:30 [+0100]: > [....] > > #:tests? is unconditionally set to #true. This is bad for cross- > > compilation and --without-tests=PACKAGE reasons, and would be > > flagged > > by the linter. > > For cross-compilation, yes.  For ’--without-tests’, it is not an > issue, > IMHO, or why is it? I was mistaken, unconditional #true is unproblematic for --without- tests, because --without-tests replaces the #true by #false IIUC. > > In the new 'check' phase, libgit2_clar is invoked unconditionally. > > This > > would be flagged by the linter. > > Since it is an example showing non-trivial things, maybe it can be > pedagogical to have something half good, if and only if, “guix lint” > reports the half bad.  And add an explanation.  WDYT? I don't know what would be best from a pedagogical perspective: showing the right code directly (showing more non-trivial things and not showing any bugs, but possibly showing too much at once), or writing the half-right code (with a short comment telling there's a bug that will be explained later). The second thing doesn't seem bad to me, but IANAP (I am not a pedagogue). Greetings, Maxime