unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#61292: define-public fontconfig vs. fontconfig-minimal as its name
@ 2023-02-05 11:43 Attila Lendvai
  2023-02-16  3:24 ` Maxim Cournoyer
  2023-08-03 15:32 ` bug#61292: fontconfig -> fontconfig-minimal Attila Lendvai
  0 siblings, 2 replies; 3+ messages in thread
From: Attila Lendvai @ 2023-02-05 11:43 UTC (permalink / raw)
  To: 61292

(define-public fontconfig
[...]
     (name "fontconfig-minimal")

this tripped me up. is this a mistake?

if not, then please add a comment that explains this anomaly.

-- 
• attila lendvai
• PGP: 963F 5D5F 45C7 DFCD 0A39
--
“We're all going to die, all of us, what a circus! That alone should make us love each other but it doesn't. We are terrorized and flattened by trivialities, we are eaten up by nothing.”
	— Charles Bukowski (1920–1994)





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#61292: define-public fontconfig vs. fontconfig-minimal as its name
  2023-02-05 11:43 bug#61292: define-public fontconfig vs. fontconfig-minimal as its name Attila Lendvai
@ 2023-02-16  3:24 ` Maxim Cournoyer
  2023-08-03 15:32 ` bug#61292: fontconfig -> fontconfig-minimal Attila Lendvai
  1 sibling, 0 replies; 3+ messages in thread
From: Maxim Cournoyer @ 2023-02-16  3:24 UTC (permalink / raw)
  To: Attila Lendvai; +Cc: 61292

Hi,

Attila Lendvai <attila@lendvai.name> writes:

> (define-public fontconfig
> [...]
>      (name "fontconfig-minimal")
>
> this tripped me up. is this a mistake?
>
> if not, then please add a comment that explains this anomaly.

There's already a comment above fontconfig-with-documentation that
reads:

  This is intentionally named 'fontconfig', as it's intended as the
  user-facing fontconfig package

The original fontconfig was renamed fontconfig-minimal but the variable
was not renamed to avoid having to adjust the rest of the code base.  It
could be done, and then the fontconfig-with-documentation *variable*
could be renamed to simply fontconfig.

That'd be more conventional.

Would you like to give it a try?  It shouldn't cause any rebuild, I
think.

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#61292: fontconfig -> fontconfig-minimal
  2023-02-05 11:43 bug#61292: define-public fontconfig vs. fontconfig-minimal as its name Attila Lendvai
  2023-02-16  3:24 ` Maxim Cournoyer
@ 2023-08-03 15:32 ` Attila Lendvai
  1 sibling, 0 replies; 3+ messages in thread
From: Attila Lendvai @ 2023-08-03 15:32 UTC (permalink / raw)
  To: 61292@debbugs.gnu.org

close 61292
stop

i started doing the rename of the variable, but the change quickly grew extensive, so i gave up. it's probably not worth the trouble.

there are 332 grep matches, and the majority requries a change.

-- 
• attila lendvai
• PGP: 963F 5D5F 45C7 DFCD 0A39
--
“Beware the stories you read or tell; subtly, at night, beneath the waters of consciousness, they are altering your world.”
	— Ben Okri (1959–)





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-08-03 15:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-05 11:43 bug#61292: define-public fontconfig vs. fontconfig-minimal as its name Attila Lendvai
2023-02-16  3:24 ` Maxim Cournoyer
2023-08-03 15:32 ` bug#61292: fontconfig -> fontconfig-minimal Attila Lendvai

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).